Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1376348/?format=api
{ "id": 1376348, "url": "http://patchwork.ozlabs.org/api/patches/1376348/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20201003185121.12370-1-trix@redhat.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20201003185121.12370-1-trix@redhat.com>", "list_archive_url": null, "date": "2020-10-03T18:51:21", "name": "net: mvneta: fix double free of txq->buf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8eb5700b46a677c48f7112774a33213eb2b7d9df", "submitter": { "id": 77700, "url": "http://patchwork.ozlabs.org/api/people/77700/?format=api", "name": "Tom Rix", "email": "trix@redhat.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20201003185121.12370-1-trix@redhat.com/mbox/", "series": [ { "id": 205830, "url": "http://patchwork.ozlabs.org/api/series/205830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=205830", "date": "2020-10-03T18:51:21", "name": "net: mvneta: fix double free of txq->buf", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/205830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1376348/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1376348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=redhat.com", "ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cBfMyvUM;\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C3bYr4gfPz9sT6\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Sun, 4 Oct 2020 05:51:44 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1725855AbgJCSvd (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Sat, 3 Oct 2020 14:51:33 -0400", "from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55019 \"EHLO\n us-smtp-delivery-124.mimecast.com\" rhost-flags-OK-OK-OK-OK)\n by vger.kernel.org with ESMTP id S1725839AbgJCSvc (ORCPT\n <rfc822;netdev@vger.kernel.org>); Sat, 3 Oct 2020 14:51:32 -0400", "from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-394-G3h89TDAM3GGy8lDsGcVsQ-1; Sat, 03 Oct 2020 14:51:29 -0400", "by mail-qt1-f200.google.com with SMTP id a16so3643749qtj.7\n for <netdev@vger.kernel.org>; Sat, 03 Oct 2020 11:51:29 -0700 (PDT)", "from trix.remote.csb (075-142-250-213.res.spectrum.com.\n [75.142.250.213])\n by smtp.gmail.com with ESMTPSA id\n v15sm3731672qkg.108.2020.10.03.11.51.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 03 Oct 2020 11:51:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1601751091;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc; bh=PpQx6m8qbEXm3p16DACdfvVJytaY8r/kOwzsRi4ZXfs=;\n b=cBfMyvUM0kw6OiZiywZ4116eXZxfqNxy5evD6fOux/mfbzi9GkuOTtweDa3Q73YC6xuNog\n rkdKwRLnb4RwYhnsPLu/guBvlTPYwZ65rYvVOSZAAEbcgDX+ymOBAUF/pbpzmeJoTPiL2p\n 60yjRXnVKXeG0z0eU4fBTWTt2YboaKk=", "X-MC-Unique": "G3h89TDAM3GGy8lDsGcVsQ-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=PpQx6m8qbEXm3p16DACdfvVJytaY8r/kOwzsRi4ZXfs=;\n b=I4ykUSHrYAudpBi2bGtzKx1itoVF3ZC3J3N98KALJkgqEFYqQdnAApVQ/BO8j5aZ4h\n QhmmBcUBW/Pq/OsLTtWE58xZbc87qUvwEuGCJEov6oEzvTHJrSyIUiKeefncSn2ywV0g\n IMaxTiiUEChLJd3e5QdsuC9EWv/FJ7hw5y1CZ13aHaRCPCBtMP/pgvp3eOZLBwsNaKyv\n 6f9Su03EiHf/aW4dRvUVKoe3cl1KeWOVk7E9MoENPVnYxlGbUKc5IfC/1enle0C6Vslr\n C6cdywbl2K5/lNIADsp8hu5pt9cfaxpvI+2txPCvRANis0psv72lpnRaBsPwTb6K5Ibu\n wTvg==", "X-Gm-Message-State": "AOAM533AZLmlTYiKATVCp2JMVwaD4OJvrJw4EYt69boJj3wbidAKXeGN\n rIJ27nejhFFO0vSvXyzud4ts/BD+lmyYLngYkc5YXvVj57gQQgU6FVPh9hI8DnOGoxF57IvJoSr\n 28ymVjYCvfyfctO+2", "X-Received": [ "by 2002:ac8:1005:: with SMTP id z5mr7605653qti.130.1601751088989;\n Sat, 03 Oct 2020 11:51:28 -0700 (PDT)", "by 2002:ac8:1005:: with SMTP id z5mr7605637qti.130.1601751088732;\n Sat, 03 Oct 2020 11:51:28 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJycZfecxVOwp4U+Ss1sMQDY8Y7tRC1tEpgXkh9CGlzXlHbe4K/4sKNQWysyQe+dtCjHt3CMzg==", "From": "trix@redhat.com", "To": "thomas.petazzoni@bootlin.com, davem@davemloft.net, kuba@kernel.org,\n natechancellor@gmail.com, ndesaulniers@google.com,\n ezequiel.garcia@free-electrons.com", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n clang-built-linux@googlegroups.com, Tom Rix <trix@redhat.com>", "Subject": "[PATCH] net: mvneta: fix double free of txq->buf", "Date": "Sat, 3 Oct 2020 11:51:21 -0700", "Message-Id": "<20201003185121.12370-1-trix@redhat.com>", "X-Mailer": "git-send-email 2.18.1", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Tom Rix <trix@redhat.com>\n\nclang static analysis reports this problem:\n\ndrivers/net/ethernet/marvell/mvneta.c:3465:2: warning:\n Attempt to free released memory\n kfree(txq->buf);\n ^~~~~~~~~~~~~~~\n\nWhen mvneta_txq_sw_init() fails to alloc txq->tso_hdrs,\nit frees without poisoning txq->buf. The error is caught\nin the mvneta_setup_txqs() caller which handles the error\nby cleaning up all of the txqs with a call to\nmvneta_txq_sw_deinit which also frees txq->buf.\n\nSince mvneta_txq_sw_deinit is a general cleaner, all of the\npartial cleaning in mvneta_txq_sw_deinit()'s error handling\nis not needed.\n\nFixes: 2adb719d74f6 (\"net: mvneta: Implement software TSO\")\nSigned-off-by: Tom Rix <trix@redhat.com>\n---\n drivers/net/ethernet/marvell/mvneta.c | 13 ++-----------\n 1 file changed, 2 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c\nindex d095718355d3..54b0bf574c05 100644\n--- a/drivers/net/ethernet/marvell/mvneta.c\n+++ b/drivers/net/ethernet/marvell/mvneta.c\n@@ -3397,24 +3397,15 @@ static int mvneta_txq_sw_init(struct mvneta_port *pp,\n \ttxq->last_desc = txq->size - 1;\n \n \ttxq->buf = kmalloc_array(txq->size, sizeof(*txq->buf), GFP_KERNEL);\n-\tif (!txq->buf) {\n-\t\tdma_free_coherent(pp->dev->dev.parent,\n-\t\t\t\t txq->size * MVNETA_DESC_ALIGNED_SIZE,\n-\t\t\t\t txq->descs, txq->descs_phys);\n+\tif (!txq->buf)\n \t\treturn -ENOMEM;\n-\t}\n \n \t/* Allocate DMA buffers for TSO MAC/IP/TCP headers */\n \ttxq->tso_hdrs = dma_alloc_coherent(pp->dev->dev.parent,\n \t\t\t\t\t txq->size * TSO_HEADER_SIZE,\n \t\t\t\t\t &txq->tso_hdrs_phys, GFP_KERNEL);\n-\tif (!txq->tso_hdrs) {\n-\t\tkfree(txq->buf);\n-\t\tdma_free_coherent(pp->dev->dev.parent,\n-\t\t\t\t txq->size * MVNETA_DESC_ALIGNED_SIZE,\n-\t\t\t\t txq->descs, txq->descs_phys);\n+\tif (!txq->tso_hdrs)\n \t\treturn -ENOMEM;\n-\t}\n \n \t/* Setup XPS mapping */\n \tif (txq_number > 1)\n", "prefixes": [] }