Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1374888/?format=api
{ "id": 1374888, "url": "http://patchwork.ozlabs.org/api/patches/1374888/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/41cca6ed-088c-da5d-94bd-4269b2071a9c@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<41cca6ed-088c-da5d-94bd-4269b2071a9c@gmail.com>", "list_archive_url": null, "date": "2020-10-01T07:23:02", "name": "[net] r8169: fix data corruption issue on RTL8402", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2fb97f56348feccaa99297602505aba7f40845a8", "submitter": { "id": 65365, "url": "http://patchwork.ozlabs.org/api/people/65365/?format=api", "name": "Heiner Kallweit", "email": "hkallweit1@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/41cca6ed-088c-da5d-94bd-4269b2071a9c@gmail.com/mbox/", "series": [ { "id": 205293, "url": "http://patchwork.ozlabs.org/api/series/205293/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=205293", "date": "2020-10-01T07:23:02", "name": "[net] r8169: fix data corruption issue on RTL8402", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/205293/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1374888/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1374888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=BbPsYL+L;\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C24NK6nh3z9sVH\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Thu, 1 Oct 2020 17:23:13 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1731534AbgJAHXM (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Thu, 1 Oct 2020 03:23:12 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:48654 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S1731498AbgJAHXL (ORCPT\n <rfc822;netdev@vger.kernel.org>); Thu, 1 Oct 2020 03:23:11 -0400", "from mail-ej1-x642.google.com (mail-ej1-x642.google.com\n [IPv6:2a00:1450:4864:20::642])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA41FC0613D0\n for <netdev@vger.kernel.org>; Thu, 1 Oct 2020 00:23:10 -0700 (PDT)", "by mail-ej1-x642.google.com with SMTP id md26so841867ejb.10\n for <netdev@vger.kernel.org>; Thu, 01 Oct 2020 00:23:10 -0700 (PDT)", "from ?IPv6:2003:ea:8f00:6a00:758b:d2db:8faf:4c9e?\n (p200300ea8f006a00758bd2db8faf4c9e.dip0.t-ipconnect.de.\n [2003:ea:8f00:6a00:758b:d2db:8faf:4c9e])\n by smtp.googlemail.com with ESMTPSA id\n o23sm3514440eju.17.2020.10.01.00.23.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 01 Oct 2020 00:23:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20161025;\n h=to:cc:from:subject:message-id:date:user-agent:mime-version\n :content-language:content-transfer-encoding;\n bh=euySubMLNn0hpcE/3ehb/nX++VODJcqhFgRzScT/BDo=;\n b=BbPsYL+LyQ0iDdWfm4g9SaQpkl2jEEkwScvdZWOFgI6EqO58T6T242c6IzUgSVIubx\n d5AxrbuWyjnaM3sd/RzwDCk1w2xyNR2PdyR0CeFGypIWvM5ySHSnGbvsI1Ss95MSDltw\n n0DXdanLVwrNvwNowU1++eNOmmSc3aVfGtjhKQWTKxciZXQoVklIVD9WkBe+fGBmyi1C\n YjFiuJMljBATrg7ajRkASyKIxVHuoIW4P+U9K/+Bh8wh3RQLBW+J4Gsylskz0R9w2l3o\n uuKWDu9QnMHp154fghLdSG2fJXiCsXeyvBx3GOFzgFGVMr64i9qWnM3qY7fRb+anIa5d\n 4nXA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent\n :mime-version:content-language:content-transfer-encoding;\n bh=euySubMLNn0hpcE/3ehb/nX++VODJcqhFgRzScT/BDo=;\n b=C2U3bS+H758ZSdX5gMe3/OCrQf/WZVwbz7tc+0y6bf2c1VZ8HPUTvUaI2YroBSyZ0h\n 4TFN0DcsX0A5VgFq/NHmUxZnwIVrBE6fNVSI2CwH44Ec+TvtPGOaN3meuZoUT3nKkoIa\n yBhaVS30H0nrmCeqpXjEntdx3+iVUcy7u/3eGAkPoghk3ysr2w0Tp3Ccg0S/kb/trsxw\n 4jdVlKreSY6ADiTB5MZ9BjTnZo+1kyqUrXvCSfMPEtB9MwXIq0z1AdTxRx1n+nminP/F\n yhVQrO9Qk8GXJvm8k+qzCaytciGOhbrSPPid72YXtSoLTXeQDCTxgoDXdHp7leYhjcAw\n pvRg==", "X-Gm-Message-State": "AOAM532ys+zyCsf6f8KiAmcr2BqNZwOZ7nRmyHjaNhQZFqp0patUqsbI\n 9M4cAHtfRTWjRrMp0McQLf8=", "X-Google-Smtp-Source": "\n ABdhPJy873iDtJZxUWOHwTbeOjftYDhaTPrlYsftcvcDZOhJtVNVniOBjpi8LZ5gBb2eEw85hf0VSw==", "X-Received": "by 2002:a17:906:1f42:: with SMTP id\n d2mr6548793ejk.407.1601536989345;\n Thu, 01 Oct 2020 00:23:09 -0700 (PDT)", "To": "Jakub Kicinski <kuba@kernel.org>,\n David Miller <davem@davemloft.net>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>", "Cc": "\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n Petr Tesarik <ptesarik@suse.cz>", "From": "Heiner Kallweit <hkallweit1@gmail.com>", "Subject": "[PATCH net] r8169: fix data corruption issue on RTL8402", "Message-ID": "<41cca6ed-088c-da5d-94bd-4269b2071a9c@gmail.com>", "Date": "Thu, 1 Oct 2020 09:23:02 +0200", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Petr reported that after resume from suspend RTL8402 partially\ntruncates incoming packets, and re-initializing register RxConfig\nbefore the actual chip re-initialization sequence is needed to avoid\nthe issue.\n\nReported-by: Petr Tesarik <ptesarik@suse.cz>\nProposed-by: Petr Tesarik <ptesarik@suse.cz>\nTested-by: Petr Tesarik <ptesarik@suse.cz>\nSigned-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n---\nHard to provide a Fixes tag because it seems the issue has been\nalways there. Due to frequent changes in function rtl8169_resume()\nwe would need a number of different fixes for the stable kernel\nversions. That the issue was reported only now indicates that chip\nversion RTL8402 is rare. Therefore treat this change mainly as an\nimprovement. This fix version applies from 5.9 after just submitted\nfix \"r8169: fix handling ether_clk\".\n---\n drivers/net/ethernet/realtek/r8169_main.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c\nindex 72351c5b0..0fa99298a 100644\n--- a/drivers/net/ethernet/realtek/r8169_main.c\n+++ b/drivers/net/ethernet/realtek/r8169_main.c\n@@ -4848,6 +4848,10 @@ static int __maybe_unused rtl8169_resume(struct device *device)\n \tif (!device_may_wakeup(tp_to_dev(tp)))\n \t\tclk_prepare_enable(tp->clk);\n \n+\t/* Reportedly at least Asus X453MA truncates packets otherwise */\n+\tif (tp->mac_version == RTL_GIGA_MAC_VER_37)\n+\t\trtl_init_rxcfg(tp);\n+\n \treturn rtl8169_net_resume(tp);\n }\n \n", "prefixes": [ "net" ] }