Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1372967/?format=api
{ "id": 1372967, "url": "http://patchwork.ozlabs.org/api/patches/1372967/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20200929015806.19171-1-xiangxia.m.yue@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200929015806.19171-1-xiangxia.m.yue@gmail.com>", "list_archive_url": null, "date": "2020-09-29T01:58:06", "name": "[net,v2] virtio-net: don't disable guest csum when disable LRO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53bed3136b4a03e703a6cb759981d746948b0e99", "submitter": { "id": 71877, "url": "http://patchwork.ozlabs.org/api/people/71877/?format=api", "name": "Tonghao Zhang", "email": "xiangxia.m.yue@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20200929015806.19171-1-xiangxia.m.yue@gmail.com/mbox/", "series": [ { "id": 204716, "url": "http://patchwork.ozlabs.org/api/series/204716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=204716", "date": "2020-09-29T01:58:06", "name": "[net,v2] virtio-net: don't disable guest csum when disable LRO", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/204716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1372967/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1372967/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=falqCPFR;\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C0jJv0vVRz9sPB\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Tue, 29 Sep 2020 12:00:31 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1727279AbgI2CA3 (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Mon, 28 Sep 2020 22:00:29 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:33918 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S1727205AbgI2CA3 (ORCPT\n <rfc822;netdev@vger.kernel.org>); Mon, 28 Sep 2020 22:00:29 -0400", "from mail-pf1-x442.google.com (mail-pf1-x442.google.com\n [IPv6:2607:f8b0:4864:20::442])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB91C061755\n for <netdev@vger.kernel.org>; Mon, 28 Sep 2020 19:00:28 -0700 (PDT)", "by mail-pf1-x442.google.com with SMTP id f18so2976105pfa.10\n for <netdev@vger.kernel.org>; Mon, 28 Sep 2020 19:00:28 -0700 (PDT)", "from localhost.localdomain ([50.236.19.102])\n by smtp.gmail.com with ESMTPSA id\n e21sm2567486pgi.91.2020.09.28.19.00.18\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 28 Sep 2020 19:00:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id;\n bh=KZ5xri8CQiZYZj5fH/BoFFdOUERtgpkqpdPrf8thG10=;\n b=falqCPFRNf4yuXs1tPP0AWaCUb9J9ze+NW/b219ZjILt2GTS3g3X0Jv0vSqGL1URZz\n Avazh/aSyNL0TEww1UyaGRV2bKrxl/tCnWZZ+CoZgXU+UwX0juTHPqgyUfSlkaGZrHTc\n AenTdX/6qPw6U2hJN0+5/9qH8wExSDe2Ln47DS1SVeHhgmDjvgatN2/rizaGrkiJR3MS\n QedeszadGVIroIVVa4osksE8agcll8/mGdbrW/wWNC5MSL9Xjd0H/53lL0oX5GMlLSg7\n aErt073q2Oz8YTIVQFz4hFIwXYqxf9IRICfn3ehyIuTq8qhom0uyl7bh8vpwZMjpUR/E\n J3Nw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=KZ5xri8CQiZYZj5fH/BoFFdOUERtgpkqpdPrf8thG10=;\n b=Buj8QVPFIhF39tn0lPhVBdm/aSYxlKOqXiIJ8uG/j3+V2f4H5CJxkzUKKyeIgbUlzF\n 0fvuqLQqUtAtZg6I4ui/e23dDlHqpMa9P1/gd5R1LUX88pSLbb5E1vwbiL3uygWoHfYw\n oWFm8ghyBfm2RareSNP9Lx+WnqNJLEihQRYRDrZTpiwvTNPE6UwnRY1bUi1EyGZ3n7Hq\n WNu41XirMNg+SWXZ3xqfbo0SBPbR9qIctXF81ok3D4NXvIzRAdrUEH5w+1Bx2A7nEgxs\n 8/GAXY3ndMPAWZ5G5fjR5YBJqcPD0MhkcOdXgY8e+qnLT+4Bo5EjMvjBwEuxt7+UDZ2t\n 7u0g==", "X-Gm-Message-State": "AOAM530t+iT72w2XIy1AhP/i9h3PBa2t8PZATPEF1QXLX4oVXNuXSWjS\n Dpd82dgHFW4aRlceG9FNrlk=", "X-Google-Smtp-Source": "\n ABdhPJwS7R20w5F0VpaYUmjll5GcEfWdzUhSgZ4eWTqyCvOG1XTY5MXYyKKK6VNYsyF84hW4pidqkg==", "X-Received": "by 2002:a63:801:: with SMTP id 1mr1497724pgi.48.1601344828521;\n Mon, 28 Sep 2020 19:00:28 -0700 (PDT)", "From": "xiangxia.m.yue@gmail.com", "To": "jasowang@redhat.com, mst@redhat.com, willemb@google.com", "Cc": "virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,\n Tonghao Zhang <xiangxia.m.yue@gmail.com>", "Subject": "[PATCH net v2] virtio-net: don't disable guest csum when disable LRO", "Date": "Tue, 29 Sep 2020 09:58:06 +0800", "Message-Id": "<20200929015806.19171-1-xiangxia.m.yue@gmail.com>", "X-Mailer": "git-send-email 2.15.0", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n\nOpen vSwitch and Linux bridge will disable LRO of the interface\nwhen this interface added to them. Now when disable the LRO, the\nvirtio-net csum is disable too. That drops the forwarding performance.\n\nFixes: a02e8964eaf9 (\"virtio-net: ethtool configurable LRO\")\nCc: Michael S. Tsirkin <mst@redhat.com>\nCc: Jason Wang <jasowang@redhat.com>\nCc: Willem de Bruijn <willemb@google.com>\nSigned-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n---\nv2:\n* change the fix-tag\n---\n drivers/net/virtio_net.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\nindex 7145c83c6c8c..21b71148c532 100644\n--- a/drivers/net/virtio_net.c\n+++ b/drivers/net/virtio_net.c\n@@ -63,6 +63,11 @@ static const unsigned long guest_offloads[] = {\n \tVIRTIO_NET_F_GUEST_CSUM\n };\n \n+#define GUEST_OFFLOAD_LRO_MASK ((1ULL << VIRTIO_NET_F_GUEST_TSO4) | \\\n+\t\t\t\t(1ULL << VIRTIO_NET_F_GUEST_TSO6) | \\\n+\t\t\t\t(1ULL << VIRTIO_NET_F_GUEST_ECN) | \\\n+\t\t\t\t(1ULL << VIRTIO_NET_F_GUEST_UFO))\n+\n struct virtnet_stat_desc {\n \tchar desc[ETH_GSTRING_LEN];\n \tsize_t offset;\n@@ -2531,7 +2536,8 @@ static int virtnet_set_features(struct net_device *dev,\n \t\tif (features & NETIF_F_LRO)\n \t\t\toffloads = vi->guest_offloads_capable;\n \t\telse\n-\t\t\toffloads = 0;\n+\t\t\toffloads = vi->guest_offloads_capable &\n+\t\t\t\t ~GUEST_OFFLOAD_LRO_MASK;\n \n \t\terr = virtnet_set_guest_offloads(vi, offloads);\n \t\tif (err)\n", "prefixes": [ "net", "v2" ] }