Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1372831/?format=api
{ "id": 1372831, "url": "http://patchwork.ozlabs.org/api/patches/1372831/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20200928183103.28442-1-xiyou.wangcong@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200928183103.28442-1-xiyou.wangcong@gmail.com>", "list_archive_url": null, "date": "2020-09-28T18:31:03", "name": "[net] net_sched: remove a redundant goto chain check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5e4a0b05c7536d5804ff87fbc180a29b8074cd68", "submitter": { "id": 211, "url": "http://patchwork.ozlabs.org/api/people/211/?format=api", "name": "Cong Wang", "email": "xiyou.wangcong@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20200928183103.28442-1-xiyou.wangcong@gmail.com/mbox/", "series": [ { "id": 204655, "url": "http://patchwork.ozlabs.org/api/series/204655/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=204655", "date": "2020-09-28T18:31:03", "name": "[net] net_sched: remove a redundant goto chain check", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/204655/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1372831/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1372831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=Chhh76Do;\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C0WLc0k9qz9sS8\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Tue, 29 Sep 2020 04:31:20 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1726666AbgI1SbT (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Mon, 28 Sep 2020 14:31:19 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:49246 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S1726638AbgI1SbS (ORCPT\n <rfc822;netdev@vger.kernel.org>); Mon, 28 Sep 2020 14:31:18 -0400", "from mail-pf1-x442.google.com (mail-pf1-x442.google.com\n [IPv6:2607:f8b0:4864:20::442])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF158C061755\n for <netdev@vger.kernel.org>; Mon, 28 Sep 2020 11:31:18 -0700 (PDT)", "by mail-pf1-x442.google.com with SMTP id k8so1849218pfk.2\n for <netdev@vger.kernel.org>; Mon, 28 Sep 2020 11:31:18 -0700 (PDT)", "from unknown.linux-6brj.site ([2600:1700:65a0:ab60::46])\n by smtp.gmail.com with ESMTPSA id\n s22sm2565934pfd.90.2020.09.28.11.31.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 28 Sep 2020 11:31:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=r3igR5FS7GPjO75PJm/VUDjHivrJMWVOtvekiljL88U=;\n b=Chhh76DobIx9RZAiT5K1eZDwNERB5zo6RXBFgAUQYbDGHPxvleiR5XjMzalDjkyqZS\n 1aIc5pIyJwoTHfQt8TuNePwDFDg9H5G6gbFEdnbq0EX4SPhwjqQ8LkgZC3asKRdktPho\n ecQDdIzq/NRVlyCS7cVT2+Tuo7vDqCHvu6CHseiTlLaAFLmgNZaak7mOSXgY85IFEQrg\n 2FsWWR6O/KDYEnw5Ms2EVSKdwaggt7U2EfKqfo2o4zARuc3UPzTXNgD3JFoVMGNkHGET\n EthxEESJaSrLZ94n5vuMS2rjgUXT3/LheFJkarE2X+V/SodW+ExOGk0Gv5EEqZpSefOp\n 7nPg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=r3igR5FS7GPjO75PJm/VUDjHivrJMWVOtvekiljL88U=;\n b=rr8vVHxYJzoSpoGYo3E2jdRgHfF7G7IMfHIajZviYYIpsMZJcyvkBLKfQ7QzRScPOs\n hzbQdNEJQZBJQ2XxBn4VWmHVNnp/Z8q4BcULlpe8H+AMd7XPia8iEo6wnDMkzNhkPhHX\n q1bn914L02Klf7s/EJa5eWqdDZrI+VdoUeN0jFpsl8YGnbi/lOIcNRNRvMD/ZAyHiF2a\n q1gUcM1UHwUdH7aLoHLMYdJH04jL7VX0sPGNp294VtNNalWn4WujmQ3327ryt60AV39F\n wmthjsrPV435THELJq8gW9Pregsxi/LpFxH9Jsp71TffF+RJGZHDF2ZlvL/rjh7EV4Rn\n /Nxg==", "X-Gm-Message-State": "AOAM532ofYbgq2xjv0iGnZ8LU7CFnOg58n1zj30u1Py62zTW5qwXzV5N\n iZi4tavnpw+KjN7RyrvRmOyAwPt/bH191w==", "X-Google-Smtp-Source": "\n ABdhPJxlZ5E3U72WvNXJ2F4C/DjJV4XlKHpozT5d1np600R17weF1e61bmqOKEl+7ngSzXSCkV38Xg==", "X-Received": "by 2002:aa7:9204:0:b029:14b:f92e:f57 with SMTP id\n 4-20020aa792040000b029014bf92e0f57mr496003pfo.16.1601317877325;\n Mon, 28 Sep 2020 11:31:17 -0700 (PDT)", "From": "Cong Wang <xiyou.wangcong@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "Cong Wang <xiyou.wangcong@gmail.com>,\n Vlad Buslov <vladbu@mellanox.com>,\n Davide Caratti <dcaratti@redhat.com>,\n Jamal Hadi Salim <jhs@mojatatu.com>,\n Jiri Pirko <jiri@resnulli.us>", "Subject": "[Patch net] net_sched: remove a redundant goto chain check", "Date": "Mon, 28 Sep 2020 11:31:03 -0700", "Message-Id": "<20200928183103.28442-1-xiyou.wangcong@gmail.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "All TC actions call tcf_action_check_ctrlact() to validate\ngoto chain, so this check in tcf_action_init_1() is actually\nredundant. Remove it to save troubles of leaking memory.\n\nFixes: e49d8c22f126 (\"net_sched: defer tcf_idr_insert() in tcf_action_init_1()\")\nReported-by: Vlad Buslov <vladbu@mellanox.com>\nSuggested-by: Davide Caratti <dcaratti@redhat.com>\nCc: Jamal Hadi Salim <jhs@mojatatu.com>\nCc: Jiri Pirko <jiri@resnulli.us>\nSigned-off-by: Cong Wang <xiyou.wangcong@gmail.com>\n---\n net/sched/act_api.c | 14 --------------\n 1 file changed, 14 deletions(-)", "diff": "diff --git a/net/sched/act_api.c b/net/sched/act_api.c\nindex 104b47f5184f..5612b336e18e 100644\n--- a/net/sched/act_api.c\n+++ b/net/sched/act_api.c\n@@ -722,13 +722,6 @@ int tcf_action_destroy(struct tc_action *actions[], int bind)\n \treturn ret;\n }\n \n-static int tcf_action_destroy_1(struct tc_action *a, int bind)\n-{\n-\tstruct tc_action *actions[] = { a, NULL };\n-\n-\treturn tcf_action_destroy(actions, bind);\n-}\n-\n static int tcf_action_put(struct tc_action *p)\n {\n \treturn __tcf_action_put(p, false);\n@@ -1000,13 +993,6 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,\n \tif (err < 0)\n \t\tgoto err_mod;\n \n-\tif (TC_ACT_EXT_CMP(a->tcfa_action, TC_ACT_GOTO_CHAIN) &&\n-\t !rcu_access_pointer(a->goto_chain)) {\n-\t\ttcf_action_destroy_1(a, bind);\n-\t\tNL_SET_ERR_MSG(extack, \"can't use goto chain with NULL chain\");\n-\t\treturn ERR_PTR(-EINVAL);\n-\t}\n-\n \tif (!name && tb[TCA_ACT_COOKIE])\n \t\ttcf_set_action_cookie(&a->act_cookie, cookie);\n \n", "prefixes": [ "net" ] }