Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1370346/?format=api
{ "id": 1370346, "url": "http://patchwork.ozlabs.org/api/patches/1370346/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20200924065845.30594-1-rohitm@chelsio.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200924065845.30594-1-rohitm@chelsio.com>", "list_archive_url": null, "date": "2020-09-24T06:58:45", "name": "net/tls: race causes kernel panic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5e2caaa3867605b4a4a512ea5f38821937acd8d3", "submitter": { "id": 78467, "url": "http://patchwork.ozlabs.org/api/people/78467/?format=api", "name": "Rohit Maheshwari", "email": "rohitm@chelsio.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20200924065845.30594-1-rohitm@chelsio.com/mbox/", "series": [ { "id": 203854, "url": "http://patchwork.ozlabs.org/api/series/203854/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=203854", "date": "2020-09-24T06:58:45", "name": "net/tls: race causes kernel panic", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/203854/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1370346/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1370346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=chelsio.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4Bxm9n0lkVz9s1t\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Thu, 24 Sep 2020 16:59:09 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1727005AbgIXG7H (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Thu, 24 Sep 2020 02:59:07 -0400", "from stargate.chelsio.com ([12.32.117.8]:35800 \"EHLO\n stargate.chelsio.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S1726902AbgIXG7H (ORCPT\n <rfc822;netdev@vger.kernel.org>); Thu, 24 Sep 2020 02:59:07 -0400", "from localhost.localdomain (redhouse.blr.asicdesigners.com\n [10.193.185.57])\n by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 08O6wpZY003518;\n Wed, 23 Sep 2020 23:58:52 -0700" ], "From": "Rohit Maheshwari <rohitm@chelsio.com>", "To": "kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net", "Cc": "vakul.garg@nxp.com, secdev@chelsio.com,\n Rohit Maheshwari <rohitm@chelsio.com>", "Subject": "[PATCH] net/tls: race causes kernel panic", "Date": "Thu, 24 Sep 2020 12:28:45 +0530", "Message-Id": "<20200924065845.30594-1-rohitm@chelsio.com>", "X-Mailer": "git-send-email 2.18.1", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "BUG: kernel NULL pointer dereference, address: 00000000000000b8\n #PF: supervisor read access in kernel mode\n #PF: error_code(0x0000) - not-present page\n PGD 80000008b6fef067 P4D 80000008b6fef067 PUD 8b6fe6067 PMD 0\n Oops: 0000 [#1] SMP PTI\n CPU: 12 PID: 23871 Comm: kworker/12:80 Kdump: loaded Tainted: G S\n 5.9.0-rc3+ #1\n Hardware name: Supermicro X10SRA-F/X10SRA-F, BIOS 2.1 03/29/2018\n Workqueue: events tx_work_handler [tls]\n RIP: 0010:tx_work_handler+0x1b/0x70 [tls]\n Code: dc fe ff ff e8 16 d4 a3 f6 66 0f 1f 44 00 00 0f 1f 44 00 00 55 53 48 8b\n 6f 58 48 8b bd a0 04 00 00 48 85 ff 74 1c 48 8b 47 28 <48> 8b 90 b8 00 00 00 83\n e2 02 75 0c f0 48 0f ba b0 b8 00 00 00 00\n RSP: 0018:ffffa44ace61fe88 EFLAGS: 00010286\n RAX: 0000000000000000 RBX: ffff91da9e45cc30 RCX: dead000000000122\n RDX: 0000000000000001 RSI: ffff91da9e45cc38 RDI: ffff91d95efac200\n RBP: ffff91da133fd780 R08: 0000000000000000 R09: 000073746e657665\n R10: 8080808080808080 R11: 0000000000000000 R12: ffff91dad7d30700\n R13: ffff91dab6561080 R14: 0ffff91dad7d3070 R15: ffff91da9e45cc38\n FS: 0000000000000000(0000) GS:ffff91dad7d00000(0000) knlGS:0000000000000000\n CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n CR2: 00000000000000b8 CR3: 0000000906478003 CR4: 00000000003706e0\n DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000\n DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400\n Call Trace:\n process_one_work+0x1a7/0x370\n worker_thread+0x30/0x370\n ? process_one_work+0x370/0x370\n kthread+0x114/0x130\n ? kthread_park+0x80/0x80\n ret_from_fork+0x22/0x30\n\ntls_sw_release_resources_tx() waits for encrypt_pending, which\ncan have race, so we need similar changes as in commit\n0cada33241d9de205522e3858b18e506ca5cce2c here as well.\n\nFixes: a42055e8d2c3 (\"net/tls: Add support for async encryption of records for performance\")\nSigned-off-by: Rohit Maheshwari <rohitm@chelsio.com>\n---\n net/tls/tls_sw.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c\nindex 9a3d9fedd7aa..95ab5545a931 100644\n--- a/net/tls/tls_sw.c\n+++ b/net/tls/tls_sw.c\n@@ -2143,10 +2143,15 @@ void tls_sw_release_resources_tx(struct sock *sk)\n \tstruct tls_context *tls_ctx = tls_get_ctx(sk);\n \tstruct tls_sw_context_tx *ctx = tls_sw_ctx_tx(tls_ctx);\n \tstruct tls_rec *rec, *tmp;\n+\tint pending;\n \n \t/* Wait for any pending async encryptions to complete */\n-\tsmp_store_mb(ctx->async_notify, true);\n-\tif (atomic_read(&ctx->encrypt_pending))\n+\tspin_lock_bh(&ctx->encrypt_compl_lock);\n+\tctx->async_notify = true;\n+\tpending = atomic_read(&ctx->encrypt_pending);\n+\tspin_unlock_bh(&ctx->encrypt_compl_lock);\n+\n+\tif (pending)\n \t\tcrypto_wait_req(-EINPROGRESS, &ctx->async_wait);\n \n \ttls_tx_records(sk, -1);\n", "prefixes": [] }