Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1326500/?format=api
{ "id": 1326500, "url": "http://patchwork.ozlabs.org/api/patches/1326500/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200710052340.737567-3-oohall@gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20200710052340.737567-3-oohall@gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20200710052340.737567-3-oohall@gmail.com/", "date": "2020-07-10T05:23:27", "name": "[02/15] powerpc/powernv/pci: Always tear down DMA windows on PE release", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "79393a81f755986e8be672b22ada701120741279", "submitter": { "id": 68108, "url": "http://patchwork.ozlabs.org/api/people/68108/?format=api", "name": "Oliver O'Halloran", "email": "oohall@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200710052340.737567-3-oohall@gmail.com/mbox/", "series": [ { "id": 188782, "url": "http://patchwork.ozlabs.org/api/series/188782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=188782", "date": "2020-07-10T05:23:26", "name": "[01/15] powernv/pci: Add pci_bus_to_pnvhb() helper", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/188782/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1326500/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1326500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4B31wT25Vgz9s1x\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Jul 2020 15:35:37 +1000 (AEST)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4B31wS63ZyzDrJv\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Jul 2020 15:35:36 +1000 (AEST)", "from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n [IPv6:2a00:1450:4864:20::443])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4B31g70bJLzDrJJ\n for <linuxppc-dev@lists.ozlabs.org>; Fri, 10 Jul 2020 15:24:02 +1000 (AEST)", "by mail-wr1-x443.google.com with SMTP id q5so4565619wru.6\n for <linuxppc-dev@lists.ozlabs.org>; Thu, 09 Jul 2020 22:24:02 -0700 (PDT)", "from 192-168-1-18.tpgi.com.au ([220.240.245.68])\n by smtp.gmail.com with ESMTPSA id 92sm9090941wrr.96.2020.07.09.22.23.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Jul 2020 22:23:58 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=pNsN0uDh;\n\tdkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::443;\n helo=mail-wr1-x443.google.com; envelope-from=oohall@gmail.com;\n receiver=<UNKNOWN>)", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=pNsN0uDh; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=lXRkeeomSnzWlNhk3einnwRSg9A1CKmlCnbKBOgIgwM=;\n b=pNsN0uDhC+raq+la47g5VqHvkO3ld2f8gn4frtfqyVqkriD0Ay5xGgEbUFZ7aK7lN2\n 2RQlXDClGyaMEVdHRXkeNks9fesfCM/8ibVNrPwneXhbuADNZ+nEPFFaKnGHvImCgbFF\n CmtlVgaj34CINHudfM1bzNU6BqVz6+uyJoTyFrg6pLHG+8xqp0wdsKHuZMYw0WQ8DnQG\n vreybVwzRVfNmOjA+quYxSKDdM1Ylwd7fZGymC/yUpMvMSOyy9LUDvlrl7VKdnRSVIdC\n lpk4tevMO3LvRPjfCdftMH28npwUuD53SIHudCM+wkHNgQxm8+GTOJkM2Tx4LAI6FpVt\n 3OnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=lXRkeeomSnzWlNhk3einnwRSg9A1CKmlCnbKBOgIgwM=;\n b=sb/QfXrd1jm4e/EV8IisxiE3Q4sTCmeGqzgvLXlpZYZDkoHnXOFRvl1ce86LmYT8bd\n OIv/AwlF1TZ08E8UVrA6kFQpet3YrJw2JEFDBcoLNPQ8BlKauxoyp1vwL3FurQpmpcFY\n 7o7RE/YkJpVfajNhkE9/wbEcvEOi6euPVVq4dMxjpHiV8w/3tKDWvnKl93srRQUQ4Roe\n 5Nho6A3uq+vzIDZSyWBWxDIFA5pJTRzv0dgI2ooFaAAHipQyNAEQ255LdwTdHAKDl3OR\n EY8Yo2oKg3ew5vqudix8vq/SSGEG1e+g33cwLXiYjfR5AAxGTDjt15nq72ESwssiZLUP\n BohQ==", "X-Gm-Message-State": "AOAM532HMwRttUohmnxxCLnU0Pbjk5/+THqfkcYJaQj25+Qblaj80MlA\n VrVMco5UqxJyDG9peVRHtZFThEwAan4=", "X-Google-Smtp-Source": "\n ABdhPJxrAvvWG4O+myh9rpk909e9iMpf5/aYTalAyL1vsIueL/AY23V2t7szzqLwDp4InjBPbG63Iw==", "X-Received": "by 2002:a05:6000:1283:: with SMTP id\n f3mr67157708wrx.106.1594358639288;\n Thu, 09 Jul 2020 22:23:59 -0700 (PDT)", "From": "Oliver O'Halloran <oohall@gmail.com>", "To": "linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 02/15] powerpc/powernv/pci: Always tear down DMA windows on PE\n release", "Date": "Fri, 10 Jul 2020 15:23:27 +1000", "Message-Id": "<20200710052340.737567-3-oohall@gmail.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200710052340.737567-1-oohall@gmail.com>", "References": "<20200710052340.737567-1-oohall@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Oliver O'Halloran <oohall@gmail.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Currently we have these two functions:\n\n\tpnv_pci_ioda2_release_dma_pe(), and\n\tpnv_pci_ioda2_release_pe_dma()\n\nThe first is used when tearing down VF PEs and the other is used for normal\ndevices. There's very little difference between the two though. The latter\n(non-VF) will skip a call to pnv_pci_ioda2_unset_window() unless\nCONFIG_IOMMU_API=y is set. There's no real point in doing this so fold the\ntwo together.\n\nSigned-off-by: Oliver O'Halloran <oohall@gmail.com>\n---\n arch/powerpc/platforms/powernv/pci-ioda.c | 30 +++--------------------\n 1 file changed, 3 insertions(+), 27 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c\nindex 687919db0347..bfb40607aa0e 100644\n--- a/arch/powerpc/platforms/powernv/pci-ioda.c\n+++ b/arch/powerpc/platforms/powernv/pci-ioda.c\n@@ -1422,26 +1422,7 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs)\n \treturn -EBUSY;\n }\n \n-static long pnv_pci_ioda2_unset_window(struct iommu_table_group *table_group,\n-\t\tint num);\n-\n-static void pnv_pci_ioda2_release_dma_pe(struct pci_dev *dev, struct pnv_ioda_pe *pe)\n-{\n-\tstruct iommu_table *tbl;\n-\tint64_t rc;\n-\n-\ttbl = pe->table_group.tables[0];\n-\trc = pnv_pci_ioda2_unset_window(&pe->table_group, 0);\n-\tif (rc)\n-\t\tpe_warn(pe, \"OPAL error %lld release DMA window\\n\", rc);\n-\n-\tpnv_pci_ioda2_set_bypass(pe, false);\n-\tif (pe->table_group.group) {\n-\t\tiommu_group_put(pe->table_group.group);\n-\t\tBUG_ON(pe->table_group.group);\n-\t}\n-\tiommu_tce_table_put(tbl);\n-}\n+static void pnv_pci_ioda2_release_pe_dma(struct pnv_ioda_pe *pe);\n \n static void pnv_ioda_release_vf_PE(struct pci_dev *pdev)\n {\n@@ -1455,11 +1436,12 @@ static void pnv_ioda_release_vf_PE(struct pci_dev *pdev)\n \tif (!pdev->is_physfn)\n \t\treturn;\n \n+\t/* FIXME: Use pnv_ioda_release_pe()? */\n \tlist_for_each_entry_safe(pe, pe_n, &phb->ioda.pe_list, list) {\n \t\tif (pe->parent_dev != pdev)\n \t\t\tcontinue;\n \n-\t\tpnv_pci_ioda2_release_dma_pe(pdev, pe);\n+\t\tpnv_pci_ioda2_release_pe_dma(pe);\n \n \t\t/* Remove from list */\n \t\tmutex_lock(&phb->ioda.pe_list_mutex);\n@@ -2429,7 +2411,6 @@ static long pnv_pci_ioda2_setup_default_config(struct pnv_ioda_pe *pe)\n \treturn 0;\n }\n \n-#if defined(CONFIG_IOMMU_API) || defined(CONFIG_PCI_IOV)\n static long pnv_pci_ioda2_unset_window(struct iommu_table_group *table_group,\n \t\tint num)\n {\n@@ -2453,7 +2434,6 @@ static long pnv_pci_ioda2_unset_window(struct iommu_table_group *table_group,\n \n \treturn ret;\n }\n-#endif\n \n #ifdef CONFIG_IOMMU_API\n unsigned long pnv_pci_ioda2_get_table_size(__u32 page_shift,\n@@ -3334,18 +3314,14 @@ static void pnv_pci_ioda2_release_pe_dma(struct pnv_ioda_pe *pe)\n {\n \tstruct iommu_table *tbl = pe->table_group.tables[0];\n \tunsigned int weight = pnv_pci_ioda_pe_dma_weight(pe);\n-#ifdef CONFIG_IOMMU_API\n \tint64_t rc;\n-#endif\n \n \tif (!weight)\n \t\treturn;\n \n-#ifdef CONFIG_IOMMU_API\n \trc = pnv_pci_ioda2_unset_window(&pe->table_group, 0);\n \tif (rc)\n \t\tpe_warn(pe, \"OPAL error %lld release DMA window\\n\", rc);\n-#endif\n \n \tpnv_pci_ioda2_set_bypass(pe, false);\n \tif (pe->table_group.group) {\n", "prefixes": [ "02/15" ] }