Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1317382/?format=api
{ "id": 1317382, "url": "http://patchwork.ozlabs.org/api/patches/1317382/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200626052141.1310945-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200626052141.1310945-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2020-06-26T05:21:41", "name": "[next-queue] ixgbe: Cleanup unneeded delay in ethtool test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7ece71a4613b72ef9616124603d98b106dae0c4d", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200626052141.1310945-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 185916, "url": "http://patchwork.ozlabs.org/api/series/185916/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185916", "date": "2020-06-26T05:21:41", "name": "[next-queue] ixgbe: Cleanup unneeded delay in ethtool test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185916/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1317382/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1317382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49tQH30vWtz9sQx\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 26 Jun 2020 15:21:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A55B186C52;\n\tFri, 26 Jun 2020 05:21:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NGwGiPLJ_srN; Fri, 26 Jun 2020 05:21:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 715E4869EB;\n\tFri, 26 Jun 2020 05:21:47 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 44F341BF5A1\n for <intel-wired-lan@lists.osuosl.org>; Fri, 26 Jun 2020 05:21:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id AF7172039E\n for <intel-wired-lan@lists.osuosl.org>; Fri, 26 Jun 2020 05:21:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Jnt9C2MTL3lb for <intel-wired-lan@lists.osuosl.org>;\n Fri, 26 Jun 2020 05:21:43 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by silver.osuosl.org (Postfix) with ESMTPS id DCFE82036B\n for <intel-wired-lan@lists.osuosl.org>; Fri, 26 Jun 2020 05:21:43 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jun 2020 22:21:43 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.86])\n by orsmga002.jf.intel.com with ESMTP; 25 Jun 2020 22:21:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 6N0tyb2XRXphHOwerXlIF5+JCtzgFJk59+ePcZ68y4EOIP6Q4Din8BXXwaBKWbNuqc86yVDI9o\n urb4hui4U1/A==", "\n 7RFW7SJ8S8g43/tCL4tFdW75sQkTDoXTzN63Yr4CadIBP2PjnP/RCk0zw+Ym9GD2V6+0Rox/Go\n zFA8/pwg+JnA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9663\"; a=\"229954049\"", "E=Sophos;i=\"5.75,282,1589266800\"; d=\"scan'208\";a=\"229954049\"", "E=Sophos;i=\"5.75,282,1589266800\"; d=\"scan'208\";a=\"294110814\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 25 Jun 2020 22:21:41 -0700", "Message-Id": "<20200626052141.1310945-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue] ixgbe: Cleanup unneeded delay in\n ethtool test", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Jack Vogel <jack.vogel@oracle.com>,\n Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There is a 4 seconds delay in ixgbe_diag_test() that is holding up other\nioctls such as SIOCGIFCONF that Oracle database applications use.\nOne of Oracle's product runs \"ethtool -t ethX online\" periodically for\nsystem monitoring and that is impacting database applications that use\nSIOCGIFCONF at that same time.\n\nThis 4 second delay was needed in out early 1GbE parts to give the PHY\ntime to recover from a reset. This code was carried forward to the 10 GbE\ndriver even it was not needed for the supported PHYs in the ixgbe driver.\n\nCC: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nCC: Jack Vogel <jack.vogel@oracle.com>\nReported-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex c4e4aa33c91d..121a3a3a76b6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -2156,7 +2156,7 @@ static void ixgbe_diag_test(struct net_device *netdev,\n \t\t\t\t\teth_test->flags |= ETH_TEST_FL_FAILED;\n \t\t\t\t\tclear_bit(__IXGBE_TESTING,\n \t\t\t\t\t\t &adapter->state);\n-\t\t\t\t\tgoto skip_ol_tests;\n+\t\t\t\t\treturn;\n \t\t\t\t}\n \t\t\t}\n \t\t}\n@@ -2228,9 +2228,6 @@ static void ixgbe_diag_test(struct net_device *netdev,\n \n \t\tclear_bit(__IXGBE_TESTING, &adapter->state);\n \t}\n-\n-skip_ol_tests:\n-\tmsleep_interruptible(4 * 1000);\n }\n \n static int ixgbe_wol_exclusion(struct ixgbe_adapter *adapter,\n", "prefixes": [ "next-queue" ] }