Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1317144/?format=api
{ "id": 1317144, "url": "http://patchwork.ozlabs.org/api/patches/1317144/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20200625184838.28172-14-philmd@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200625184838.28172-14-philmd@redhat.com>", "list_archive_url": null, "date": "2020-06-25T18:48:34", "name": "[13/17] block/nvme: Simplify completion trace events", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d51064d9d9617acb55faec957a0db3b1c8e46f09", "submitter": { "id": 74995, "url": "http://patchwork.ozlabs.org/api/people/74995/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20200625184838.28172-14-philmd@redhat.com/mbox/", "series": [ { "id": 185846, "url": "http://patchwork.ozlabs.org/api/series/185846/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=185846", "date": "2020-06-25T18:48:21", "name": "block/nvme: Various cleanups required to use multiple queues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185846/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1317144/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1317144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=eKqzdiEH;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49t8Ss0Ng2z9sQt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 26 Jun 2020 04:59:25 +1000 (AEST)", "from localhost ([::1]:48650 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1joX5m-0007Tf-Md\n\tfor incoming@patchwork.ozlabs.org; Thu, 25 Jun 2020 14:59:22 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40468)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@redhat.com>) id 1joWwV-0000Xx-5l\n for qemu-devel@nongnu.org; Thu, 25 Jun 2020 14:49:47 -0400", "from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58261\n helo=us-smtp-1.mimecast.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from <philmd@redhat.com>) id 1joWwT-0001Eb-GG\n for qemu-devel@nongnu.org; Thu, 25 Jun 2020 14:49:46 -0400", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-182-rM6LbJIcMcOQalWV-RDAtA-1; Thu, 25 Jun 2020 14:49:43 -0400", "by mail-wm1-f71.google.com with SMTP id b13so5759504wme.9\n for <qemu-devel@nongnu.org>; Thu, 25 Jun 2020 11:49:42 -0700 (PDT)", "from localhost.localdomain (1.red-83-51-162.dynamicip.rima-tde.net.\n [83.51.162.1])\n by smtp.gmail.com with ESMTPSA id o9sm32321361wrs.1.2020.06.25.11.49.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 25 Jun 2020 11:49:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1593110984;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nIyn1saCYFaGdm81Oq09Kelp7+BVTinz9yQeBa0Ppdk=;\n b=eKqzdiEHYDpWr3eIunwBJWZb0yNTIcwCtLx1rrJwB/5w8QlE01b53zlfxWg1FfMNWHpRMb\n u8stBlaTS3DtRL6KHjuRSaATYRfMMnSN9cnqftv6E3UawXyHEHo8mvgxC1OErjbJjiPA5S\n wMXDzAr+c/I1yw5utVgj76thyOvrBdw=", "X-MC-Unique": "rM6LbJIcMcOQalWV-RDAtA-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=nIyn1saCYFaGdm81Oq09Kelp7+BVTinz9yQeBa0Ppdk=;\n b=hHUenbVKrDVisnSYffdkjRsimUqdSoxG1pbrN0LeCDGz5Kl/mUBHZBkAkMPQVe5KYC\n hqfA8beUiwz9PC7onmSevtdBKpD7PGkY03S4WGcSjU5vf2lf5rSgzCcDxWkbqqczUOsN\n v+fQQScUA8AniqXBY5YMbGnjz85hBU0Ox6kJdq/++FkoBFUCVGexMn1BVzfVzC5eKpFQ\n 2Bn6Zcq9tLCqq3dXY2GSXpKxkqZEQ68Ig2Vx+5o4LLkelNuvkNan8RHncYP7g8b1ch64\n zE2nE1vD2khnVgbE+17OrYFcrolDBz9Hatnzs+4vxRI+BJrY/FjQTo4D+IlPQmkteSbt\n OyMQ==", "X-Gm-Message-State": "AOAM532Ql3yikNOYn30RP+5O5A2AHTheZzb0M657+xmVMKPgD4TVSQBf\n EpsdnKBQJLD150K/AQ9tNiZxTsb4+flLFCZRO+G4zsl3cnPyEAMelBw+hig0JI3LsD+ZA6cKz7q\n sdFffur5Ow1BRsIY=", "X-Received": [ "by 2002:a7b:cc92:: with SMTP id p18mr5116307wma.4.1593110981539;\n Thu, 25 Jun 2020 11:49:41 -0700 (PDT)", "by 2002:a7b:cc92:: with SMTP id p18mr5116294wma.4.1593110981383;\n Thu, 25 Jun 2020 11:49:41 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJxrN5WhKifX3bF6GBGntQNfgDBAxDswnG/6+iyql1L1EUDXPF1e2r0kZ4ACoEUb4ZtxxdaK4A==", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com>", "To": "qemu-devel@nongnu.org,\n\tStefan Hajnoczi <stefanha@redhat.com>", "Subject": "[PATCH 13/17] block/nvme: Simplify completion trace events", "Date": "Thu, 25 Jun 2020 20:48:34 +0200", "Message-Id": "<20200625184838.28172-14-philmd@redhat.com>", "X-Mailer": "git-send-email 2.21.3", "In-Reply-To": "<20200625184838.28172-1-philmd@redhat.com>", "References": "<20200625184838.28172-1-philmd@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8;\n\ttext/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com;\n helo=us-smtp-1.mimecast.com", "X-detected-operating-system": "by eggs.gnu.org: First seen = 2020/06/25 00:45:15", "X-ACL-Warn": "Detected OS = Linux 2.2.x-3.x [generic] [fuzzy]", "X-Spam_score_int": "-30", "X-Spam_score": "-3.1", "X-Spam_bar": "---", "X-Spam_report": "(-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,\n qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,\n Maxim Levitsky <mlevitsk@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The queues are tied to the hardware, logging the block\ndriver using them is irrelevant.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>\n---\n block/nvme.c | 6 +++---\n block/trace-events | 6 +++---\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/block/nvme.c b/block/nvme.c\nindex 4d2f31a9b3..7b983ba4e1 100644\n--- a/block/nvme.c\n+++ b/block/nvme.c\n@@ -323,9 +323,9 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q)\n NVMeRequest req;\n NvmeCqe *c;\n \n- trace_nvme_process_completion(s, q->index, q->inflight);\n+ trace_nvme_process_completion(q->index, q->inflight);\n if (q->busy || s->plugged) {\n- trace_nvme_process_completion_queue_busy(s, q->index);\n+ trace_nvme_process_completion_queue_busy(q->index);\n return false;\n }\n q->busy = true;\n@@ -347,7 +347,7 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q)\n continue;\n }\n assert(cid <= NVME_QUEUE_SIZE);\n- trace_nvme_complete_command(s, q->index, cid);\n+ trace_nvme_complete_command(q->index, cid);\n preq = &q->reqs[cid - 1];\n req = *preq;\n assert(req.cid == cid);\ndiff --git a/block/trace-events b/block/trace-events\nindex f0c476110b..8c29818093 100644\n--- a/block/trace-events\n+++ b/block/trace-events\n@@ -157,9 +157,9 @@ vxhs_get_creds(const char *cacert, const char *client_key, const char *client_ce\n nvme_kick(int queue) \"queue %d\"\n nvme_dma_flush_queue_wait(void *s) \"s %p\"\n nvme_error(int cmd_specific, int sq_head, int sqid, int cid, int status) \"cmd_specific %d sq_head %d sqid %d cid %d status 0x%x\"\n-nvme_process_completion(void *s, int index, int inflight) \"s %p queue %d inflight %d\"\n-nvme_process_completion_queue_busy(void *s, int index) \"s %p queue %d\"\n-nvme_complete_command(void *s, int index, int cid) \"s %p queue %d cid %d\"\n+nvme_process_completion(int index, int inflight) \"queue %d inflight %d\"\n+nvme_process_completion_queue_busy(int index) \"queue %d\"\n+nvme_complete_command(int index, int cid) \"queue %d cid %d\"\n nvme_submit_command(void *s, int index, int cid) \"s %p queue %d cid %d\"\n nvme_submit_command_raw(int c0, int c1, int c2, int c3, int c4, int c5, int c6, int c7) \"%02x %02x %02x %02x %02x %02x %02x %02x\"\n nvme_handle_event(void *s) \"s %p\"\n", "prefixes": [ "13/17" ] }