Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1316361/?format=api
{ "id": 1316361, "url": "http://patchwork.ozlabs.org/api/patches/1316361/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200624160422.58874-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200624160422.58874-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-06-24T16:04:22", "name": "iavf: Fix updating statistics", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "26d076d40148ff9a2aecb4bdedd29f5b7ced1e1c", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200624160422.58874-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 185587, "url": "http://patchwork.ozlabs.org/api/series/185587/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185587", "date": "2020-06-24T16:04:22", "name": "iavf: Fix updating statistics", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185587/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1316361/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1316361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49sSjQ0XqHz9sSJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 25 Jun 2020 02:07:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3D0A585F11;\n\tWed, 24 Jun 2020 16:07:52 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Q1gE2XKIJ2XM; Wed, 24 Jun 2020 16:07:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id ABE9585EBF;\n\tWed, 24 Jun 2020 16:07:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 435551BF578\n for <intel-wired-lan@lists.osuosl.org>; Wed, 24 Jun 2020 16:07:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 3DEB885EBF\n for <intel-wired-lan@lists.osuosl.org>; Wed, 24 Jun 2020 16:07:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id gwMXKNPgWVtl for <intel-wired-lan@lists.osuosl.org>;\n Wed, 24 Jun 2020 16:07:49 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 89B3A85EB8\n for <intel-wired-lan@lists.osuosl.org>; Wed, 24 Jun 2020 16:07:49 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jun 2020 09:07:48 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by orsmga004.jf.intel.com with ESMTP; 24 Jun 2020 09:07:48 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n Syscaz1OOwYsMBxxTH9Kp8gkSdx8qpG6Iju+vGuyjqDgtEFH9JpMt+hsy6i56oR/IEK3zAalcC\n YFy5QUwOrevQ==", "\n QZqQvBeDbAtfSHiagwA0oL/nW6vxKxX6ocW8FjIDG/JgP7zvl5PS1g0ABdb0ywWjkvNaQ0Wpwh\n 35/mHlNERSVA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9662\"; a=\"131957732\"", "E=Sophos;i=\"5.75,275,1589266800\"; d=\"scan'208\";a=\"131957732\"", "E=Sophos;i=\"5.75,275,1589266800\"; d=\"scan'208\";a=\"423421444\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 24 Jun 2020 09:04:22 -0700", "Message-Id": "<20200624160422.58874-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] iavf: Fix updating statistics", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit bac8486116b0 (\"iavf: Refactor the watchdog state machine\") inverted\nthe logic for when to update statistics. Statistics should be updated when\nno other commands are pending, instead they were only requested when a\ncommand was processed. iavf_request_stats() would see a pending request\nand not request statistics to be updated. This caused statistics to never\nbe updated; fix the logic.\n\nFixes: bac8486116b0 (\"iavf: Refactor the watchdog state machine\")\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_main.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex b90ad1abbabb..48c956d90b90 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -1937,7 +1937,10 @@ static void iavf_watchdog_task(struct work_struct *work)\n \t\t\t\tiavf_send_api_ver(adapter);\n \t\t\t}\n \t\t} else {\n-\t\t\tif (!iavf_process_aq_command(adapter) &&\n+\t\t\t/* An error will be returned if no commands were\n+\t\t\t * processed; use this opportunity to update stats\n+\t\t\t */\n+\t\t\tif (iavf_process_aq_command(adapter) &&\n \t\t\t adapter->state == __IAVF_RUNNING)\n \t\t\t\tiavf_request_stats(adapter);\n \t\t}\n", "prefixes": [] }