Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1315044/?format=api
{ "id": 1315044, "url": "http://patchwork.ozlabs.org/api/patches/1315044/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1592905458-850-4-git-send-email-magnus.karlsson@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1592905458-850-4-git-send-email-magnus.karlsson@intel.com>", "list_archive_url": null, "date": "2020-06-23T09:44:18", "name": "[net-next,v2,3/3] i40e: move check of full Tx ring to outside of send loop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "12845ee6ba3142f86cd66a7f0bab77a0ffb64be7", "submitter": { "id": 72726, "url": "http://patchwork.ozlabs.org/api/people/72726/?format=api", "name": "Magnus Karlsson", "email": "magnus.karlsson@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1592905458-850-4-git-send-email-magnus.karlsson@intel.com/mbox/", "series": [ { "id": 185220, "url": "http://patchwork.ozlabs.org/api/series/185220/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185220", "date": "2020-06-23T09:44:15", "name": "i40e: improve AF_XDP performance", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/185220/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1315044/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1315044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rhFl586dz9sRf\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 19:44:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3CE2B88371;\n\tTue, 23 Jun 2020 09:44:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6ftTkVe4i6Ik; Tue, 23 Jun 2020 09:44:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2BDAD88267;\n\tTue, 23 Jun 2020 09:44:41 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id 0B1C01BF294\n for <intel-wired-lan@lists.osuosl.org>; Tue, 23 Jun 2020 09:44:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id 077EA8908A\n for <intel-wired-lan@lists.osuosl.org>; Tue, 23 Jun 2020 09:44:40 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 8scs3X+H5WaF for <intel-wired-lan@lists.osuosl.org>;\n Tue, 23 Jun 2020 09:44:39 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by hemlock.osuosl.org (Postfix) with ESMTPS id 71BD988D67\n for <intel-wired-lan@lists.osuosl.org>; Tue, 23 Jun 2020 09:44:39 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jun 2020 02:44:39 -0700", "from mkarlsso-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n ([10.252.33.84])\n by orsmga004.jf.intel.com with ESMTP; 23 Jun 2020 02:44:34 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n TOA5HVmRlWyjwgOJ0phay1e6D2oXj/3fLTWGg9zF6oSGAuLQQ98bKZRFNbSjKbvIndPPU9IcSG\n FHViLO0L797A==", "\n ov4vznMNjrsw38oS0rlYt//dIoniJRr6uJlnFKrgLwTQ4kenjGWYRs/EMg8JqHlIRuv0h2yCZM\n Vuetisg4Qt8A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9660\"; a=\"162099571\"", "E=Sophos;i=\"5.75,270,1589266800\"; d=\"scan'208\";a=\"162099571\"", "E=Sophos;i=\"5.75,270,1589266800\"; d=\"scan'208\";a=\"422947161\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Magnus Karlsson <magnus.karlsson@intel.com>", "To": "magnus.karlsson@intel.com, bjorn.topel@intel.com,\n intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,\n sridhar.samudrala@intel.com", "Date": "Tue, 23 Jun 2020 11:44:18 +0200", "Message-Id": "<1592905458-850-4-git-send-email-magnus.karlsson@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1592905458-850-1-git-send-email-magnus.karlsson@intel.com>", "References": "<1592905458-850-1-git-send-email-magnus.karlsson@intel.com>", "Subject": "[Intel-wired-lan] [PATCH net-next v2 3/3] i40e: move check of full\n Tx ring to outside of send loop", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "maciejromanfijalkowski@gmail.com, maciej.fijalkowski@intel.com,\n netdev@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Move the check if the Hw Tx ring is full to outside the send\nloop. Currently it is checked for every single descriptor that we\nsend. Instead, tell the send loop to only process a maximum number of\npackets equal to the number of available slots in the Tx ring. This\nway, we can remove the check inside the send loop to and gain some\nperformance.\n\nSuggested-by: Sridhar Samudrala <sridhar.samudrala@intel.com>\nSigned-off-by: Magnus Karlsson <magnus.karlsson@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_xsk.c | 20 +++++---------------\n 1 file changed, 5 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\nindex 86635f5..081783a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n@@ -381,17 +381,10 @@ static bool i40e_xmit_zc(struct i40e_ring *xdp_ring, unsigned int budget)\n \tunsigned int sent_frames = 0, total_bytes = 0;\n \tstruct i40e_tx_desc *tx_desc = NULL;\n \tstruct i40e_tx_buffer *tx_bi;\n-\tbool work_done = true;\n \tstruct xdp_desc desc;\n \tdma_addr_t dma;\n \n \twhile (budget-- > 0) {\n-\t\tif (!unlikely(I40E_DESC_UNUSED(xdp_ring))) {\n-\t\t\txdp_ring->tx_stats.tx_busy++;\n-\t\t\twork_done = false;\n-\t\t\tbreak;\n-\t\t}\n-\n \t\tif (!xsk_umem_consume_tx(xdp_ring->xsk_umem, &desc))\n \t\t\tbreak;\n \n@@ -427,7 +420,7 @@ static bool i40e_xmit_zc(struct i40e_ring *xdp_ring, unsigned int budget)\n \t\ti40e_update_tx_stats(xdp_ring, sent_frames, total_bytes);\n \t}\n \n-\treturn !!budget && work_done;\n+\treturn !!budget;\n }\n \n /**\n@@ -448,19 +441,18 @@ static void i40e_clean_xdp_tx_buffer(struct i40e_ring *tx_ring,\n \n /**\n * i40e_clean_xdp_tx_irq - Completes AF_XDP entries, and cleans XDP entries\n+ * @vsi: Current VSI\n * @tx_ring: XDP Tx ring\n- * @tx_bi: Tx buffer info to clean\n *\n * Returns true if cleanup/tranmission is done.\n **/\n bool i40e_clean_xdp_tx_irq(struct i40e_vsi *vsi, struct i40e_ring *tx_ring)\n {\n-\tunsigned int ntc, budget = vsi->work_limit;\n \tstruct xdp_umem *umem = tx_ring->xsk_umem;\n \tu32 i, completed_frames, xsk_frames = 0;\n \tu32 head_idx = i40e_get_head(tx_ring);\n \tstruct i40e_tx_buffer *tx_bi;\n-\tbool xmit_done;\n+\tunsigned int ntc;\n \n \tif (head_idx < tx_ring->next_to_clean)\n \t\thead_idx += tx_ring->count;\n@@ -504,9 +496,7 @@ bool i40e_clean_xdp_tx_irq(struct i40e_vsi *vsi, struct i40e_ring *tx_ring)\n \tif (xsk_umem_uses_need_wakeup(tx_ring->xsk_umem))\n \t\txsk_set_tx_need_wakeup(tx_ring->xsk_umem);\n \n-\txmit_done = i40e_xmit_zc(tx_ring, budget);\n-\n-\treturn xmit_done;\n+\treturn i40e_xmit_zc(tx_ring, I40E_DESC_UNUSED(tx_ring));\n }\n \n /**\n@@ -570,7 +560,7 @@ void i40e_xsk_clean_rx_ring(struct i40e_ring *rx_ring)\n \n /**\n * i40e_xsk_clean_xdp_ring - Clean the XDP Tx ring on shutdown\n- * @xdp_ring: XDP Tx ring\n+ * @tx_ring: XDP Tx ring\n **/\n void i40e_xsk_clean_tx_ring(struct i40e_ring *tx_ring)\n {\n", "prefixes": [ "net-next", "v2", "3/3" ] }