Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1314629/?format=api
{ "id": 1314629, "url": "http://patchwork.ozlabs.org/api/patches/1314629/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-7-brgl@bgdev.pl/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200622100056.10151-7-brgl@bgdev.pl>", "list_archive_url": null, "date": "2020-06-22T10:00:51", "name": "[06/11] phy: un-inline devm_mdiobus_register()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "b6abf8166826376873845601d6e95327b435cd81", "submitter": { "id": 71346, "url": "http://patchwork.ozlabs.org/api/people/71346/?format=api", "name": "Bartosz Golaszewski", "email": "brgl@bgdev.pl" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-7-brgl@bgdev.pl/mbox/", "series": [ { "id": 185056, "url": "http://patchwork.ozlabs.org/api/series/185056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185056", "date": "2020-06-22T10:00:52", "name": "net: improve devres helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185056/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1314629/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1314629/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=bgdev.pl", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bgdev-pl.20150623.gappssmtp.com\n header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256\n header.s=20150623 header.b=hPCSBYPi;\n\tdkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rFh60qghz9sSF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 02:47:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5A11E89418;\n\tMon, 22 Jun 2020 16:47:32 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7FlYxK1--Smt; Mon, 22 Jun 2020 16:47:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 571C6893C0;\n\tMon, 22 Jun 2020 16:47:29 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 6D94F1BF3C8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:09:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 69E6485FDE\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:09:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id PGMroQAB_3lz for <intel-wired-lan@lists.osuosl.org>;\n Mon, 22 Jun 2020 10:09:45 +0000 (UTC)", "from mail-wm1-f68.google.com (mail-wm1-f68.google.com\n [209.85.128.68])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id C2245863E0\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:09:26 +0000 (UTC)", "by mail-wm1-f68.google.com with SMTP id y20so15120529wmi.2\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 03:09:26 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr.\n [2.15.156.232])\n by smtp.gmail.com with ESMTPSA id x205sm16822187wmx.21.2020.06.22.03.01.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Jun 2020 03:01:14 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bgdev-pl.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=SA+ksrlspcBtk66ickfbWi5/X69plQETLqM+T7sqDOM=;\n b=hPCSBYPijk+oW7o3W3ojF3NAaYsD4JrRPsGlfOOBzQ4ThECSIaaifu8iSYPR7zbUAx\n giQ4sowH3znExtSO3S964zh5IyteuZGXmP9B2ZvExrbuG0lv3RnqMa0dbDx7oKT3Cruf\n ntFtCt/KtwVdleh2QZcz+vD9bEurGJjeVbuXPkyeyA87kxRvFoIssYR99lkRq25sp0Dy\n 8ME3z0/l/PLLTultbtzKIRLt1ie8TS/eRQs7WOUniJkv9YG+Ya35j/vswWIOOkBzSz+Z\n KPipplT5rhQD8Nb/E1vu5Mffd1y2DmSUKnz0Ux1Df2rzIAqZgpQCiOI37E2WBb24Fa9I\n KUIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=SA+ksrlspcBtk66ickfbWi5/X69plQETLqM+T7sqDOM=;\n b=snNEcRPHKosDhxpTqRkmSl0KO87Eq68ZkasbG0Xx7jfwbCm1j6Ze0+101OJLbgPkRd\n 0P4W975oAdeiWsQayDDmitUDAeoIJuYV1bfPgD2iOpR6BjDsOjbjtRvWGmkXMcaJLtZS\n aALQjmqCTrf1kKjXBqTqA+Ba3n0TcTQP6hC4yXG52JpSCFyHEX9qbW74yUCAJYiZstjh\n Tvn07NkvFsYNjrLTq2VgyT2YoD3gqGKZgiyZ9UXwwG7LE2vv0rXVIfcBCMtEO1QRfntr\n khxBScUfZbBxo2vRLwkSqvGyisS95B21tp3qcZNMQVjPeqBONxlxSXehrO5zEkEJWPzf\n vYuA==", "X-Gm-Message-State": "AOAM5325AA91pyKgVZt3meV8+6wPTJp7ady+ome5REf8+BAGhbesip5A\n emLrHbq0sqELhetQIkclN5EL9aXxtNw=", "X-Google-Smtp-Source": "\n ABdhPJwWuhZqPJe1EH2uJKbIx2fxGg7cPQA+kFKd21eTb++TacoGNccIXkK+VSOvahqdHB0+R/2MHw==", "X-Received": "by 2002:a1c:bc55:: with SMTP id m82mr10040949wmf.92.1592820075474;\n Mon, 22 Jun 2020 03:01:15 -0700 (PDT)", "From": "Bartosz Golaszewski <brgl@bgdev.pl>", "To": "Jonathan Corbet <corbet@lwn.net>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S . Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>,\n Mark Lee <Mark-MC.Lee@mediatek.com>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>,\n Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n Florian Fainelli <f.fainelli@gmail.com>,\n Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,\n Frank Rowand <frowand.list@gmail.com>", "Date": "Mon, 22 Jun 2020 12:00:51 +0200", "Message-Id": "<20200622100056.10151-7-brgl@bgdev.pl>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200622100056.10151-1-brgl@bgdev.pl>", "References": "<20200622100056.10151-1-brgl@bgdev.pl>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 22 Jun 2020 16:47:24 +0000", "Subject": "[Intel-wired-lan] [PATCH 06/11] phy: un-inline\n devm_mdiobus_register()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org,\n Bartosz Golaszewski <bgolaszewski@baylibre.com>,\n Stephane Le Provost <stephane.leprovost@mediatek.com>,\n linux-doc@vger.kernel.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,\n linux-mediatek@lists.infradead.org,\n Andrew Perepech <andrew.perepech@mediatek.com>,\n Pedro Tsai <pedro.tsai@mediatek.com>, intel-wired-lan@lists.osuosl.org,\n linux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n\nFunctions should only be static inline if they're very short. This\ndevres helper is already over 10 lines and it will grow soon as we'll\nbe improving upon its approach. Pull it into mdio_devres.c.\n\nSigned-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n---\n drivers/net/phy/Makefile | 2 +-\n drivers/net/phy/mdio_devres.c | 18 ++++++++++++++++++\n include/linux/phy.h | 15 ++-------------\n 3 files changed, 21 insertions(+), 14 deletions(-)\n create mode 100644 drivers/net/phy/mdio_devres.c", "diff": "diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile\nindex dc9e53b511d6..896afdcac437 100644\n--- a/drivers/net/phy/Makefile\n+++ b/drivers/net/phy/Makefile\n@@ -3,7 +3,7 @@\n \n libphy-y\t\t\t:= phy.o phy-c45.o phy-core.o phy_device.o \\\n \t\t\t\t linkmode.o\n-mdio-bus-y\t\t\t+= mdio_bus.o mdio_device.o\n+mdio-bus-y\t\t\t+= mdio_bus.o mdio_device.o mdio_devres.o\n \n ifdef CONFIG_MDIO_DEVICE\n obj-y\t\t\t\t+= mdio-boardinfo.o\ndiff --git a/drivers/net/phy/mdio_devres.c b/drivers/net/phy/mdio_devres.c\nnew file mode 100644\nindex 000000000000..f0b4b6cfe5e3\n--- /dev/null\n+++ b/drivers/net/phy/mdio_devres.c\n@@ -0,0 +1,18 @@\n+// SPDX-License-Identifier: GPL-2.0-or-later\n+\n+#include <linux/phy.h>\n+\n+int __devm_mdiobus_register(struct mii_bus *bus, struct module *owner)\n+{\n+\tint ret;\n+\n+\tif (!bus->is_managed)\n+\t\treturn -EPERM;\n+\n+\tret = __mdiobus_register(bus, owner);\n+\tif (!ret)\n+\t\tbus->is_managed_registered = 1;\n+\n+\treturn ret;\n+}\n+EXPORT_SYMBOL(__devm_mdiobus_register);\ndiff --git a/include/linux/phy.h b/include/linux/phy.h\nindex 8c05d0fb5c00..62149945c5b3 100644\n--- a/include/linux/phy.h\n+++ b/include/linux/phy.h\n@@ -313,20 +313,9 @@ static inline struct mii_bus *mdiobus_alloc(void)\n }\n \n int __mdiobus_register(struct mii_bus *bus, struct module *owner);\n+int __devm_mdiobus_register(struct mii_bus *bus, struct module *owner);\n #define mdiobus_register(bus) __mdiobus_register(bus, THIS_MODULE)\n-static inline int devm_mdiobus_register(struct mii_bus *bus)\n-{\n-\tint ret;\n-\n-\tif (!bus->is_managed)\n-\t\treturn -EPERM;\n-\n-\tret = mdiobus_register(bus);\n-\tif (!ret)\n-\t\tbus->is_managed_registered = 1;\n-\n-\treturn ret;\n-}\n+#define devm_mdiobus_register(bus) __devm_mdiobus_register(bus, THIS_MODULE)\n \n void mdiobus_unregister(struct mii_bus *bus);\n void mdiobus_free(struct mii_bus *bus);\n", "prefixes": [ "06/11" ] }