Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1314626/?format=api
{ "id": 1314626, "url": "http://patchwork.ozlabs.org/api/patches/1314626/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-11-brgl@bgdev.pl/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200622100056.10151-11-brgl@bgdev.pl>", "list_archive_url": null, "date": "2020-06-22T10:00:55", "name": "[10/11] of: mdio: provide devm_of_mdiobus_register()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "b2f514fa6d86de479bf230a49e31001000d0abfa", "submitter": { "id": 71346, "url": "http://patchwork.ozlabs.org/api/people/71346/?format=api", "name": "Bartosz Golaszewski", "email": "brgl@bgdev.pl" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-11-brgl@bgdev.pl/mbox/", "series": [ { "id": 185056, "url": "http://patchwork.ozlabs.org/api/series/185056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185056", "date": "2020-06-22T10:00:52", "name": "net: improve devres helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185056/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1314626/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1314626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=bgdev.pl", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bgdev-pl.20150623.gappssmtp.com\n header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256\n header.s=20150623 header.b=PF+tNOmB;\n\tdkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rFh50KS2z9sSy\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 02:47:29 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 577FE893E1;\n\tMon, 22 Jun 2020 16:47:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hJ7bYPlkHw0M; Mon, 22 Jun 2020 16:47:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 88C84893AD;\n\tMon, 22 Jun 2020 16:47:26 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id DD3031BF3C8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id D5ABD885FB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id pERCGiGphgO6 for <intel-wired-lan@lists.osuosl.org>;\n Mon, 22 Jun 2020 10:07:48 +0000 (UTC)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n [209.85.128.67])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 9D262885DC\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:48 +0000 (UTC)", "by mail-wm1-f67.google.com with SMTP id t194so15105923wmt.4\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 03:07:48 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr.\n [2.15.156.232])\n by smtp.gmail.com with ESMTPSA id x205sm16822187wmx.21.2020.06.22.03.01.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Jun 2020 03:01:21 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bgdev-pl.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=0OwWR9e+WLqXjj7DZkBsabU1u86Gybrt82xzuKAKe9o=;\n b=PF+tNOmBYUtaXR59mgLImt5cydyQjc6gCPHU2lpTFbbnauDrYket1vtlbvya1ZFFaX\n gZcWbJjIa4v6QOhEmbOEpsuz/BzHnaMKaiIZawDoROmh5HVGhBYs/wDzYWqAlUjdnSUP\n UknHwa2e8E7lmYaNQ2ZInYopleBTBrQXkM3owc7xyhGa+IPJhFae9afW+yTnTVvNJVHO\n noPcA8CyypW5+/8+u8UidiqF8N8uVszPjCDi1HZeV9HdAcrfhH1rHUd12HGSNxazdHuY\n 1nHtMg93+nwFp/9FA+D2PC82dYeE4jCIN7biofp8SUU38ZY+Mu2iypl7deFI/1IGlFYE\n BSsg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=0OwWR9e+WLqXjj7DZkBsabU1u86Gybrt82xzuKAKe9o=;\n b=a+SajwHZ2mJM1tZScSYHfBC5uPW/smSdcvQI+MC6rygaH5dyCm2oj32uDtpESVYgVO\n 8w/AxzHtPb0VWS8As/d6fjffp1VBEZtJJ3cHtSzcNUl7lKj6GkWFdYdeeGluqMo3vbLk\n HwTzpoWlkUqtVKY7ortiJxUXr8m86kI5TIeU9JpTA8eUrGTvVir76i6rj8D6s63wES4Q\n lTsH55HorpRVVRT1oNkhR2sPWUh4uLW4RLD7BSPduk/g3kiAejI+p+XdZRAeCcsfUOFc\n 0/5dW45NYqOACRWgGBjJy0PmnGTfv63HKNZU2SFQ48tu08EyqZfcIYUKV4AXVBbxZCQB\n OOOg==", "X-Gm-Message-State": "AOAM533Pa2v5eldx7y/FqM4PUjghBq5WHh3A6a9WCR/lgxDHn+lItTW5\n 0h77PCKS1No9L787QbukM6Ip0b8V7yI=", "X-Google-Smtp-Source": "\n ABdhPJwvA59r+zUadSM89AyF+H+fxT/nf2nvFkXIaFeBdOLpCsO/8Bm7rv3uF+bD/IjDwAb9EKnqCw==", "X-Received": "by 2002:a05:600c:21d7:: with SMTP id\n x23mr18471470wmj.95.1592820082109;\n Mon, 22 Jun 2020 03:01:22 -0700 (PDT)", "From": "Bartosz Golaszewski <brgl@bgdev.pl>", "To": "Jonathan Corbet <corbet@lwn.net>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S . Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>,\n Mark Lee <Mark-MC.Lee@mediatek.com>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>,\n Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n Florian Fainelli <f.fainelli@gmail.com>,\n Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,\n Frank Rowand <frowand.list@gmail.com>", "Date": "Mon, 22 Jun 2020 12:00:55 +0200", "Message-Id": "<20200622100056.10151-11-brgl@bgdev.pl>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200622100056.10151-1-brgl@bgdev.pl>", "References": "<20200622100056.10151-1-brgl@bgdev.pl>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 22 Jun 2020 16:47:24 +0000", "Subject": "[Intel-wired-lan] [PATCH 10/11] of: mdio: provide\n devm_of_mdiobus_register()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org,\n Bartosz Golaszewski <bgolaszewski@baylibre.com>,\n Stephane Le Provost <stephane.leprovost@mediatek.com>,\n linux-doc@vger.kernel.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,\n linux-mediatek@lists.infradead.org,\n Andrew Perepech <andrew.perepech@mediatek.com>,\n Pedro Tsai <pedro.tsai@mediatek.com>, intel-wired-lan@lists.osuosl.org,\n linux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n\nImplement a managed variant of of_mdiobus_register(). We need to\nreimplement the devres structure and the release callback because we\ncan't put this function in drivers/net/phy/mdio_devres.c or we'd hit\ncircular dependencies between module symbols. We also don't want to\nbuild this bit if OF is not selected in Kconfig.\n\nSigned-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n---\n .../driver-api/driver-model/devres.rst | 1 +\n drivers/of/of_mdio.c | 43 +++++++++++++++++++\n include/linux/of_mdio.h | 3 ++\n 3 files changed, 47 insertions(+)", "diff": "diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst\nindex e0333d66a7f4..eaaaafc21134 100644\n--- a/Documentation/driver-api/driver-model/devres.rst\n+++ b/Documentation/driver-api/driver-model/devres.rst\n@@ -343,6 +343,7 @@ MDIO\n devm_mdiobus_alloc()\n devm_mdiobus_alloc_size()\n devm_mdiobus_register()\n+ devm_of_mdiobus_register()\n \n MEM\n devm_free_pages()\ndiff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c\nindex a04afe79529c..83e98c6ec96b 100644\n--- a/drivers/of/of_mdio.c\n+++ b/drivers/of/of_mdio.c\n@@ -330,6 +330,49 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)\n }\n EXPORT_SYMBOL(of_mdiobus_register);\n \n+/* This duplicates the devres code from drivers/net/phy/mdio_devres.c but\n+ * if we put devm_of_mdiobus_register() over there we'd hit circular symbol\n+ * dependencies between the libphy and of_mdio modules.\n+ */\n+struct mdiobus_devres {\n+\tstruct mii_bus *mii;\n+};\n+\n+static void devm_mdiobus_unregister(struct device *dev, void *this)\n+{\n+\tstruct mdiobus_devres *dr = this;\n+\n+\tmdiobus_unregister(dr->mii);\n+}\n+\n+/**\n+ * devm_of_mdiobus_register - Resource managed variant of of_mdiobus_register()\n+ * @dev:\tDevice to register mii_bus for\n+ * @mdio:\tMII bus structure to register\n+ * @np:\t\tDevice node to parse\n+ */\n+int devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio,\n+\t\t\t struct device_node *np)\n+{\n+\tstruct mdiobus_devres *dr;\n+\tint ret;\n+\n+\tdr = devres_alloc(devm_mdiobus_unregister, sizeof(*dr), GFP_KERNEL);\n+\tif (!dr)\n+\t\treturn -ENOMEM;\n+\n+\tret = of_mdiobus_register(mdio, np);\n+\tif (ret) {\n+\t\tdevres_free(dr);\n+\t\treturn ret;\n+\t}\n+\n+\tdr->mii = mdio;\n+\tdevres_add(dev, dr);\n+\treturn 0;\n+}\n+EXPORT_SYMBOL(devm_of_mdiobus_register);\n+\n /**\n * of_phy_find_device - Give a PHY node, find the phy_device\n * @phy_np: Pointer to the phy's device tree node\ndiff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h\nindex ba8e157f24ad..1efb88d9f892 100644\n--- a/include/linux/of_mdio.h\n+++ b/include/linux/of_mdio.h\n@@ -8,12 +8,15 @@\n #ifndef __LINUX_OF_MDIO_H\n #define __LINUX_OF_MDIO_H\n \n+#include <linux/device.h>\n #include <linux/phy.h>\n #include <linux/of.h>\n \n #if IS_ENABLED(CONFIG_OF_MDIO)\n bool of_mdiobus_child_is_phy(struct device_node *child);\n int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np);\n+int devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio,\n+\t\t\t struct device_node *np);\n struct phy_device *of_phy_find_device(struct device_node *phy_np);\n struct phy_device *\n of_phy_connect(struct net_device *dev, struct device_node *phy_np,\n", "prefixes": [ "10/11" ] }