Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1314625/?format=api
{ "id": 1314625, "url": "http://patchwork.ozlabs.org/api/patches/1314625/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-12-brgl@bgdev.pl/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200622100056.10151-12-brgl@bgdev.pl>", "list_archive_url": null, "date": "2020-06-22T10:00:56", "name": "[11/11] net: ethernet: mtk-star-emac: use devm_of_mdiobus_register()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "8adf6c1b7e11476bf080ef4967cf97ddd1e39942", "submitter": { "id": 71346, "url": "http://patchwork.ozlabs.org/api/people/71346/?format=api", "name": "Bartosz Golaszewski", "email": "brgl@bgdev.pl" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-12-brgl@bgdev.pl/mbox/", "series": [ { "id": 185056, "url": "http://patchwork.ozlabs.org/api/series/185056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185056", "date": "2020-06-22T10:00:52", "name": "net: improve devres helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185056/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1314625/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1314625/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=bgdev.pl", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bgdev-pl.20150623.gappssmtp.com\n header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256\n header.s=20150623 header.b=eaQDTmoI;\n\tdkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rFh31Cx7z9sRf\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 02:47:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C81F862E4;\n\tMon, 22 Jun 2020 16:47:28 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id I90Ral1TKqTD; Mon, 22 Jun 2020 16:47:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3C20D8625F;\n\tMon, 22 Jun 2020 16:47:27 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 3B60E1BF3C8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 1A9DF21F6F\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:07 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id A1JnFRZ7uVCR for <intel-wired-lan@lists.osuosl.org>;\n Mon, 22 Jun 2020 10:08:05 +0000 (UTC)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n [209.85.128.65])\n by silver.osuosl.org (Postfix) with ESMTPS id 35C2120784\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:08:05 +0000 (UTC)", "by mail-wm1-f65.google.com with SMTP id l17so14298511wmj.0\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 03:08:05 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr.\n [2.15.156.232])\n by smtp.gmail.com with ESMTPSA id x205sm16822187wmx.21.2020.06.22.03.01.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Jun 2020 03:01:23 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bgdev-pl.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=7pEL+pOqyLTkwaRij99JSBZiVqVmOtzJ61ge9c76alE=;\n b=eaQDTmoIva7YgqUT7n4mmFYcgVR8tYbiSv+EsIHLIkQIJviMpTReLXYVtvFOol2q0e\n LdphqNn3acWhpQSuesmQgbP86SDv2CFnYiE9kY21eMu86QB0XYrJByJRId49gHAlMstK\n B4PEF9TayTWp8MPD7056GMzylW6Q4ubJ6zSD88ao0ofMVT8s1OPaucGSs+G1NKXCU30e\n StG0ZCrSCfsoa1hh3rlMOqh0cMq2OsJKG43o3A8mXuwgeMr2MQBldeFEmmaxo9KTVZVr\n OFBWf0C3jGOzn1RbJXOwkVbboUkef6zzBQaj44aHFBunXxesBGFG26tktECmHQNvp0dY\n 2sXg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=7pEL+pOqyLTkwaRij99JSBZiVqVmOtzJ61ge9c76alE=;\n b=pDVOp7z1wuKDFwnwUQ0msuR25xJDSEQd924HWtYWTq6hlC/hRO8Wx3H1HXo7geCbB9\n M2rvdBhLNS19zIfYfEh6hPA1o1DGXw3srlkqG5nburSwgptjIzAepJoKFTDj01gdNa/C\n 5RSB3EYp2nkzrL3VxQvVg7hMbfth9p54fr8llDs/F48VgEmvhCIGPWsZQU0UFpM98XYB\n huGrCk3VKKD16B5571ssKH/HSCB3EWWR2D6mhFnCLTk3IAFTxS2+aRoSQsjNhqx9D0lq\n Tc+Hil2sNdVXTYZXvnh2XNCysZjD29T/2L6kFqhDXMW/QTL+cPBEkms8itr20ePVMCBg\n 6dbg==", "X-Gm-Message-State": "AOAM533aLNNsFyIMXhwnLQpDKqlDMlouYltp5GvCuLRs1udAQFGYXGKq\n AgBv8GUJTnYiOVRLLgJw8wnWuvvP7Zg=", "X-Google-Smtp-Source": "\n ABdhPJzbn3QUtTBkSaHKKRlQD+NAcxXoZjCO6pjuNjVVzgSeYV529/r6h+a5y21qbFYnMCH6f96pIg==", "X-Received": "by 2002:a1c:804c:: with SMTP id b73mr699546wmd.59.1592820083830;\n Mon, 22 Jun 2020 03:01:23 -0700 (PDT)", "From": "Bartosz Golaszewski <brgl@bgdev.pl>", "To": "Jonathan Corbet <corbet@lwn.net>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S . Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>,\n Mark Lee <Mark-MC.Lee@mediatek.com>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>,\n Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n Florian Fainelli <f.fainelli@gmail.com>,\n Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,\n Frank Rowand <frowand.list@gmail.com>", "Date": "Mon, 22 Jun 2020 12:00:56 +0200", "Message-Id": "<20200622100056.10151-12-brgl@bgdev.pl>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200622100056.10151-1-brgl@bgdev.pl>", "References": "<20200622100056.10151-1-brgl@bgdev.pl>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 22 Jun 2020 16:47:24 +0000", "Subject": "[Intel-wired-lan] [PATCH 11/11] net: ethernet: mtk-star-emac: use\n devm_of_mdiobus_register()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org,\n Bartosz Golaszewski <bgolaszewski@baylibre.com>,\n Stephane Le Provost <stephane.leprovost@mediatek.com>,\n linux-doc@vger.kernel.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,\n linux-mediatek@lists.infradead.org,\n Andrew Perepech <andrew.perepech@mediatek.com>,\n Pedro Tsai <pedro.tsai@mediatek.com>, intel-wired-lan@lists.osuosl.org,\n linux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n\nShrink the code by using the managed variant of of_mdiobus_register().\n\nSigned-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n---\n drivers/net/ethernet/mediatek/mtk_star_emac.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c\nindex 3e765bdcf9e1..13250553263b 100644\n--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c\n+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c\n@@ -1389,7 +1389,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)\n \tpriv->mii->write = mtk_star_mdio_write;\n \tpriv->mii->priv = priv;\n \n-\tret = of_mdiobus_register(priv->mii, mdio_node);\n+\tret = devm_of_mdiobus_register(dev, priv->mii, mdio_node);\n \n out_put_node:\n \tof_node_put(mdio_node);\n@@ -1441,13 +1441,6 @@ static void mtk_star_clk_disable_unprepare(void *data)\n \tclk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks);\n }\n \n-static void mtk_star_mdiobus_unregister(void *data)\n-{\n-\tstruct mtk_star_priv *priv = data;\n-\n-\tmdiobus_unregister(priv->mii);\n-}\n-\n static int mtk_star_probe(struct platform_device *pdev)\n {\n \tstruct device_node *of_node;\n@@ -1549,10 +1542,6 @@ static int mtk_star_probe(struct platform_device *pdev)\n \tif (ret)\n \t\treturn ret;\n \n-\tret = devm_add_action_or_reset(dev, mtk_star_mdiobus_unregister, priv);\n-\tif (ret)\n-\t\treturn ret;\n-\n \tret = eth_platform_get_mac_address(dev, ndev->dev_addr);\n \tif (ret || !is_valid_ether_addr(ndev->dev_addr))\n \t\teth_hw_addr_random(ndev);\n", "prefixes": [ "11/11" ] }