Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1314624/?format=api
{ "id": 1314624, "url": "http://patchwork.ozlabs.org/api/patches/1314624/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-3-brgl@bgdev.pl/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200622100056.10151-3-brgl@bgdev.pl>", "list_archive_url": null, "date": "2020-06-22T10:00:47", "name": "[02/11] net: ethernet: ixgbe: don't call devm_mdiobus_free()", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "c16c54f15b3f5327b0262dede9438dbb97bebd52", "submitter": { "id": 71346, "url": "http://patchwork.ozlabs.org/api/people/71346/?format=api", "name": "Bartosz Golaszewski", "email": "brgl@bgdev.pl" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200622100056.10151-3-brgl@bgdev.pl/mbox/", "series": [ { "id": 185056, "url": "http://patchwork.ozlabs.org/api/series/185056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=185056", "date": "2020-06-22T10:00:52", "name": "net: improve devres helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/185056/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1314624/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1314624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=bgdev.pl", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bgdev-pl.20150623.gappssmtp.com\n header.i=@bgdev-pl.20150623.gappssmtp.com header.a=rsa-sha256\n header.s=20150623 header.b=W5twYeDF;\n\tdkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49rFh428YZz9sSg\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Jun 2020 02:47:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D11AD23018;\n\tMon, 22 Jun 2020 16:47:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iGtCgpRaU4Xs; Mon, 22 Jun 2020 16:47:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id DD4EF204EE;\n\tMon, 22 Jun 2020 16:47:26 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id D5F551BF3C8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id D28F6885FB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 2iM5+XOHmEcu for <intel-wired-lan@lists.osuosl.org>;\n Mon, 22 Jun 2020 10:07:52 +0000 (UTC)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n [209.85.128.65])\n by whitealder.osuosl.org (Postfix) with ESMTPS id E4362885DC\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 10:07:51 +0000 (UTC)", "by mail-wm1-f65.google.com with SMTP id r15so15112801wmh.5\n for <intel-wired-lan@lists.osuosl.org>; Mon, 22 Jun 2020 03:07:51 -0700 (PDT)", "from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr.\n [2.15.156.232])\n by smtp.gmail.com with ESMTPSA id x205sm16822187wmx.21.2020.06.22.03.01.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Jun 2020 03:01:08 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bgdev-pl.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=nZJ9RrYkX//UjOI/5YYylQYoHuaDDR4YnVJY1VbZiK8=;\n b=W5twYeDFovUtibE54WQz/oY7xyAdsth+BrFOY/mwsKgJPsn0I8IXyw+KxwKQF1ccxI\n 0Vt4K58MBHihtcBcsAbduhBD/mpp6DDwwRtQDMg4DPDarSks61h5JkloiQmN5VvS0yn1\n 0MSYq3+hFxyViGeyscqGmPromya4jk9KRI0GNLYt2z3RxhbOM4E3fY3KBk6qoCm79iXc\n 3Hv1vs4zZ9h7EGmVIUsjsu72HT6azkCzrdmgJHG4VQQEoPysFHsyyrj5e60fdxVZexdD\n trJKHKTrt9CadDNiF6JYZkjIDKxYSRiSUtH8aF77wU6jWNuYEqz2A6dAA/jnuyrnG/K6\n JkAQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=nZJ9RrYkX//UjOI/5YYylQYoHuaDDR4YnVJY1VbZiK8=;\n b=Ij7jWn3GA14TDSXQ3Z05zbRK4lrhLSL19VKuPJqSqazp+8lPbd0pfvCqPLUbiswN4p\n ObXntbhSqyAQD4GyOItd9JHQtPciFA2vKIacKAweTPnNAdZJSfDB5YYrRVJ9VIeHD3Yw\n MOAKKPHWrJ+ZofTVjVZfCwqAE2R8FWc9J4tNXugFafHoV8ki3hGHhuCqhjXMfxk+5z5t\n NgQMX7KKL++8KYIj/n67Ke9D/HdMSOZPhByrw9iEGh/xVmzw0fSQAHaHJeBXdnokLc0w\n HqqJuhwa84YIK49tW5BUc+Fr6KADETb0Wau79qUB/D/I7kcd3ZUj1Nkcdz70SfwV85z6\n dmDA==", "X-Gm-Message-State": "AOAM5303PVCcgyNb00iF1yVA0VEWxPOmL9RuqgYElbRfpt1sNt4jM+8G\n 1MVzvWD/hBRwjeEFkUYFm84ct4JVJx4=", "X-Google-Smtp-Source": "\n ABdhPJz3Tx9rRuWOQsVP67dBEA0GfJ//6KQ3oIcn8+cDfu01dOKFVefKNNRcSbP+61lUU38AkDnLJw==", "X-Received": "by 2002:a05:600c:2dc1:: with SMTP id\n e1mr5037577wmh.108.1592820068560;\n Mon, 22 Jun 2020 03:01:08 -0700 (PDT)", "From": "Bartosz Golaszewski <brgl@bgdev.pl>", "To": "Jonathan Corbet <corbet@lwn.net>,\n Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S . Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>,\n Mark Lee <Mark-MC.Lee@mediatek.com>,\n Matthias Brugger <matthias.bgg@gmail.com>,\n Realtek linux nic maintainers <nic_swsd@realtek.com>,\n Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,\n Florian Fainelli <f.fainelli@gmail.com>,\n Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,\n Frank Rowand <frowand.list@gmail.com>", "Date": "Mon, 22 Jun 2020 12:00:47 +0200", "Message-Id": "<20200622100056.10151-3-brgl@bgdev.pl>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200622100056.10151-1-brgl@bgdev.pl>", "References": "<20200622100056.10151-1-brgl@bgdev.pl>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Mon, 22 Jun 2020 16:47:24 +0000", "Subject": "[Intel-wired-lan] [PATCH 02/11] net: ethernet: ixgbe: don't call\n devm_mdiobus_free()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "devicetree@vger.kernel.org,\n Bartosz Golaszewski <bgolaszewski@baylibre.com>,\n Stephane Le Provost <stephane.leprovost@mediatek.com>,\n linux-doc@vger.kernel.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,\n linux-mediatek@lists.infradead.org,\n Andrew Perepech <andrew.perepech@mediatek.com>,\n Pedro Tsai <pedro.tsai@mediatek.com>, intel-wired-lan@lists.osuosl.org,\n linux-arm-kernel@lists.infradead.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n\nThe idea behind devres is that the release callbacks are called if\nprobe fails. As we now check the return value of ixgbe_mii_bus_init(),\nwe can drop the call devm_mdiobus_free() in error path as the release\ncallback will be called automatically.\n\nSigned-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++-----------\n 1 file changed, 3 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex 2fb97967961c..7980d7265e10 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -905,7 +905,6 @@ s32 ixgbe_mii_bus_init(struct ixgbe_hw *hw)\n \tstruct pci_dev *pdev = adapter->pdev;\n \tstruct device *dev = &adapter->netdev->dev;\n \tstruct mii_bus *bus;\n-\tint err = -ENODEV;\n \n \tbus = devm_mdiobus_alloc(dev);\n \tif (!bus)\n@@ -923,7 +922,7 @@ s32 ixgbe_mii_bus_init(struct ixgbe_hw *hw)\n \tcase IXGBE_DEV_ID_X550EM_A_1G_T:\n \tcase IXGBE_DEV_ID_X550EM_A_1G_T_L:\n \t\tif (!ixgbe_x550em_a_has_mii(hw))\n-\t\t\tgoto ixgbe_no_mii_bus;\n+\t\t\treturn -ENODEV;\n \t\tbus->read = &ixgbe_x550em_a_mii_bus_read;\n \t\tbus->write = &ixgbe_x550em_a_mii_bus_write;\n \t\tbreak;\n@@ -948,15 +947,8 @@ s32 ixgbe_mii_bus_init(struct ixgbe_hw *hw)\n \t */\n \thw->phy.mdio.mode_support = MDIO_SUPPORTS_C45 | MDIO_SUPPORTS_C22;\n \n-\terr = mdiobus_register(bus);\n-\tif (!err) {\n-\t\tadapter->mii_bus = bus;\n-\t\treturn 0;\n-\t}\n-\n-ixgbe_no_mii_bus:\n-\tdevm_mdiobus_free(dev, bus);\n-\treturn err;\n+\tadapter->mii_bus = bus;\n+\treturn mdiobus_register(bus);\n }\n \n /**\n", "prefixes": [ "02/11" ] }