Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1311909/?format=api
{ "id": 1311909, "url": "http://patchwork.ozlabs.org/api/patches/1311909/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200618065453.12140-1-aaron.ma@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200618065453.12140-1-aaron.ma@canonical.com>", "list_archive_url": null, "date": "2020-06-18T06:54:53", "name": "[v4] e1000e: continue to init phy even when failed to disable ULP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f78ef81d3abb43a9c3a6e159ac018ce09c9c41e3", "submitter": { "id": 72035, "url": "http://patchwork.ozlabs.org/api/people/72035/?format=api", "name": "Aaron Ma", "email": "aaron.ma@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200618065453.12140-1-aaron.ma@canonical.com/mbox/", "series": [ { "id": 184161, "url": "http://patchwork.ozlabs.org/api/series/184161/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=184161", "date": "2020-06-18T06:54:53", "name": "[v4] e1000e: continue to init phy even when failed to disable ULP", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/184161/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1311909/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1311909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=canonical.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49nXkT1Rptz9sTD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Jun 2020 16:55:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 04E5688520;\n\tThu, 18 Jun 2020 06:55:11 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oaeYYfbrLQKE; Thu, 18 Jun 2020 06:55:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 73B9388494;\n\tThu, 18 Jun 2020 06:55:10 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 0611D1BF28D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Jun 2020 06:55:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 002EE87DC6\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Jun 2020 06:55:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id w2Fq1pqy31jB for <intel-wired-lan@lists.osuosl.org>;\n Thu, 18 Jun 2020 06:55:06 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n [91.189.89.112])\n by whitealder.osuosl.org (Postfix) with ESMTPS id CAFBD87DB0\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Jun 2020 06:55:06 +0000 (UTC)", "from [114.249.250.117] (helo=localhost.localdomain)\n by youngberry.canonical.com with esmtpsa\n (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n (envelope-from <aaron.ma@canonical.com>)\n id 1jloRy-00069K-97; Thu, 18 Jun 2020 06:55:03 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Aaron Ma <aaron.ma@canonical.com>", "To": "kuba@kernel.org, jeffrey.t.kirsher@intel.com, davem@davemloft.net,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, vitaly.lifshits@intel.com,\n kai.heng.feng@canonical.com, sasha.neftin@intel.com", "Date": "Thu, 18 Jun 2020 14:54:53 +0800", "Message-Id": "<20200618065453.12140-1-aaron.ma@canonical.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200616100512.22512-1-aaron.ma@canonical.com>", "References": "<20200616100512.22512-1-aaron.ma@canonical.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even\n when failed to disable ULP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "After 'commit e086ba2fccda4 (\"e1000e: disable s0ix entry and exit flows\n for ME systems\")',\nThinkPad P14s always failed to disable ULP by ME.\n'commit 0c80cdbf3320 (\"e1000e: Warn if disabling ULP failed\")'\nbreak out of init phy:\n\nerror log:\n[ 42.364753] e1000e 0000:00:1f.6 enp0s31f6: Failed to disable ULP\n[ 42.524626] e1000e 0000:00:1f.6 enp0s31f6: PHY Wakeup cause - Unicast Packet\n[ 42.822476] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error\n\nWhen disable s0ix, E1000_FWSM_ULP_CFG_DONE will never be 1.\nIf continue to init phy like before, it can work as before.\niperf test result good too.\n\nFixes: 0c80cdbf3320 (\"e1000e: Warn if disabling ULP failed\")\nSigned-off-by: Aaron Ma <aaron.ma@canonical.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex f999cca37a8a..be7475c5529d 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -303,7 +303,6 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw)\n \tret_val = e1000_disable_ulp_lpt_lp(hw, true);\n \tif (ret_val) {\n \t\te_warn(\"Failed to disable ULP\\n\");\n-\t\tgoto out;\n \t}\n \n \tret_val = hw->phy.ops.acquire(hw);\n", "prefixes": [ "v4" ] }