Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1308131/?format=api
{ "id": 1308131, "url": "http://patchwork.ozlabs.org/api/patches/1308131/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200612114731.144630-1-bjorn.topel@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200612114731.144630-1-bjorn.topel@gmail.com>", "list_archive_url": null, "date": "2020-06-12T11:47:31", "name": "[net] i40e: fix crash when Rx descriptor count is changed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c2e5f66fea0fe24676cd82ff805193d50eddc537", "submitter": { "id": 70569, "url": "http://patchwork.ozlabs.org/api/people/70569/?format=api", "name": "Björn Töpel", "email": "bjorn.topel@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200612114731.144630-1-bjorn.topel@gmail.com/mbox/", "series": [ { "id": 182978, "url": "http://patchwork.ozlabs.org/api/series/182978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=182978", "date": "2020-06-12T11:47:31", "name": "[net] i40e: fix crash when Rx descriptor count is changed", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/182978/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1308131/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1308131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=F7ak+z3r;\n\tdkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49jzVq6BF8z9sSy\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 12 Jun 2020 21:47:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 89F36897C5;\n\tFri, 12 Jun 2020 11:47:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CyFMaJcucyGC; Fri, 12 Jun 2020 11:47:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7028A897A0;\n\tFri, 12 Jun 2020 11:47:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id ED90E1BF2E3\n for <intel-wired-lan@lists.osuosl.org>; Fri, 12 Jun 2020 11:47:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id E49A888A29\n for <intel-wired-lan@lists.osuosl.org>; Fri, 12 Jun 2020 11:47:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id icUL90s4t831 for <intel-wired-lan@lists.osuosl.org>;\n Fri, 12 Jun 2020 11:47:42 +0000 (UTC)", "from mail-pj1-f68.google.com (mail-pj1-f68.google.com\n [209.85.216.68])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 40CCA889F7\n for <intel-wired-lan@lists.osuosl.org>; Fri, 12 Jun 2020 11:47:42 +0000 (UTC)", "by mail-pj1-f68.google.com with SMTP id s88so3748328pjb.5\n for <intel-wired-lan@lists.osuosl.org>; Fri, 12 Jun 2020 04:47:42 -0700 (PDT)", "from btopel-mobl.ger.intel.com (fmdmzpr03-ext.fm.intel.com.\n [192.55.54.38])\n by smtp.gmail.com with ESMTPSA id h9sm3227266pjs.50.2020.06.12.04.47.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 12 Jun 2020 04:47:40 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=HbZcKA6Rhm4nCGMfP9Rvp1r28EhMhEPMy4TrCL8RdRE=;\n b=F7ak+z3ro6mwAOVAPjbpePKPk1HpE4idBe9F7nEJ8IuSytT9FHSrtY2q0ypzgnaKOD\n SxNdViTlOLsFhiAtjY9J+rEU0UgsHhl1B0JZB2+POC4M/V4MZ2dcUAx79NKsBVT9VB1k\n qFT8SVXTrmGZjUqxB1b/g8d9GBBEQtFdVIuZJyLHM9A5YHF7T+/0uDdfnlrXLoqLbi2z\n ddhwEEi8iIOJJwWv7k5yLGnYeujMBfvJxjyZmELN1Prq4qcBLLTNM/vZc7XuK91jA8Wn\n VWyX/rqspi9i5IQFxTvvt+5VF4o0CQtK/bMMxqqCz5BJzE+Pkdxs2veEOZ74YEz1S7bd\n BVbA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=HbZcKA6Rhm4nCGMfP9Rvp1r28EhMhEPMy4TrCL8RdRE=;\n b=r9kggC5uCPROyzjzyUVQfG44iTDIDyq51ILn2KLHeoggF7BBJ3UratBtx+XJTDn4jY\n Sij+ht848xskl4FHfzTaUuBKenaBGqawruh44qTYc3p6AIDbLtz60FTMzs6y9poPOl6k\n V/fr1xHlUh6B7YNmjaHP11dQie6Npg2hW+mnJpvpO44Xa0J8p87SekIP+EC4wVFcG+wa\n 51vBIZlzyks/z8SPAfnvxDyMYPs5dnY1WDtztK0McP8oVRbiOk6KonpzSrjomcOWZyGc\n +DSVbwAHGZU7vf7T3Cf76HLo2MyD/3ggIi0UF2QtspW32BbNqWI8vsxuOcDkIVhpE0FA\n v7TA==", "X-Gm-Message-State": "AOAM531u7Jv67d/ZYwmu5Ll0LShTmWr7/2jaHDaEA+WvD87Qb5pAftRt\n TEAKAOIYU+jfVLzkvtKadW8oSugfYDQ=", "X-Google-Smtp-Source": "\n ABdhPJxpadzLW2w3UQlGH5ka4zIsvW0vagy1Xsm/dkF+Pkm3xn2KQUBOIoAUK2XGhw/Nq9EWCGynnA==", "X-Received": "by 2002:a17:90a:d3d6:: with SMTP id\n d22mr12533184pjw.184.1591962461401;\n Fri, 12 Jun 2020 04:47:41 -0700 (PDT)", "From": "=?utf-8?b?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 12 Jun 2020 13:47:31 +0200", "Message-Id": "<20200612114731.144630-1-bjorn.topel@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH net] i40e: fix crash when Rx descriptor\n count is changed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, bpf@vger.kernel.org, =?utf-8?b?QmrDtnJuIFTDtnBl?=\n\t=?utf-8?b?bA==?= <bjorn.topel@intel.com>, magnus.karlsson@intel.com", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Björn Töpel <bjorn.topel@intel.com>\n\nWhen the AF_XDP buffer allocator was introduced, the Rx SW ring\n\"rx_bi\" allocation was moved from i40e_setup_rx_descriptors()\nfunction, and was instead done in the i40e_configure_rx_ring()\nfunction.\n\nThis broke the ethtool set_ringparam() hook for changing the Rx\ndescriptor count, which was relying on i40e_setup_rx_descriptors() to\nhandle the alloction.\n\nFix this by adding an explicit i40e_alloc_rx_bi() call to\ni40e_set_ringparam().\n\nFixes: be1222b585fd (\"i40e: Separate kernel allocated rx_bi rings from AF_XDP rings\")\nSigned-off-by: Björn Töpel <bjorn.topel@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +++\n 1 file changed, 3 insertions(+)\n\n\nbase-commit: 18dbd4cd9b8c957025cf90a3c50102b31bde14f7", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex aa8026b1eb81..67806b7b2f49 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2070,6 +2070,9 @@ static int i40e_set_ringparam(struct net_device *netdev,\n \t\t\t */\n \t\t\trx_rings[i].tail = hw->hw_addr + I40E_PRTGEN_STATUS;\n \t\t\terr = i40e_setup_rx_descriptors(&rx_rings[i]);\n+\t\t\tif (err)\n+\t\t\t\tgoto rx_unwind;\n+\t\t\terr = i40e_alloc_rx_bi(&rx_rings[i]);\n \t\t\tif (err)\n \t\t\t\tgoto rx_unwind;\n \n", "prefixes": [ "net" ] }