Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1307961/?format=api
{ "id": 1307961, "url": "http://patchwork.ozlabs.org/api/patches/1307961/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20200612022452.371685-13-oohall@gmail.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200612022452.371685-13-oohall@gmail.com>", "list_archive_url": null, "date": "2020-06-12T02:24:49", "name": "[12/15] test: Do gcov builds as a seperate pass", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8226f3a70973eeb2d630c1445d0cc4aea0a8bb04", "submitter": { "id": 68108, "url": "http://patchwork.ozlabs.org/api/people/68108/?format=api", "name": "Oliver O'Halloran", "email": "oohall@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20200612022452.371685-13-oohall@gmail.com/mbox/", "series": [ { "id": 182887, "url": "http://patchwork.ozlabs.org/api/series/182887/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=182887", "date": "2020-06-12T02:24:38", "name": "[01/15] test/qemu: Update command line arguments", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/182887/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1307961/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1307961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49jl6D0r7yz9sRN\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 12 Jun 2020 12:29:08 +1000 (AEST)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 49jl6C6c4YzDqty\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 12 Jun 2020 12:29:07 +1000 (AEST)", "from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n [IPv6:2a00:1450:4864:20::443])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 49jl2C145vzDqsw\n for <skiboot@lists.ozlabs.org>; Fri, 12 Jun 2020 12:25:38 +1000 (AEST)", "by mail-wr1-x443.google.com with SMTP id x14so8161517wrp.2\n for <skiboot@lists.ozlabs.org>; Thu, 11 Jun 2020 19:25:38 -0700 (PDT)", "from localhost.ibm.com (123-243-125-185.tpgi.com.au.\n [123.243.125.185])\n by smtp.gmail.com with ESMTPSA id h7sm6756948wml.24.2020.06.11.19.25.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 11 Jun 2020 19:25:32 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=Gn34/10t;\n\tdkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::443;\n helo=mail-wr1-x443.google.com; envelope-from=oohall@gmail.com;\n receiver=<UNKNOWN>)", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=Gn34/10t; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=X/8hRSoLawQD72WGkcHXmGaX3QY1vJgnG5Ta1KRsE3g=;\n b=Gn34/10t6L1wtaRk87A8fP1bu05kBy3G4ju3Dm22ok7bX613FUEGCgs8g+d86P4Ach\n iUhbGykVyzBWkB+h75buEblddAqB2lknV2l4SQHZyo1s+AvkQ2BpuFLzWzDgV0CREdBj\n yGopDmWdrM8chbyTYE3nZRX8cMRp4HKfZ/x8lU/wM730voz8Ezu5747LWRYMBxNrjUrH\n TtozD/EMw3WZUVfQg3nTqfOvmIdy1KR5Kg9yaskNWFHR44PuftEaat1EtHOGTEr4Hwix\n E3EhI43pPGxWGk9mXMzEuURmDmVy7eyWTmKLVME5VHIiZiHVh4mAcLp24By3x2lhUOyu\n Okug==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=X/8hRSoLawQD72WGkcHXmGaX3QY1vJgnG5Ta1KRsE3g=;\n b=acFK3ogDTPYc+Wv77Hr8/s9E+ExleGyqMVA988Lxm4lj0H1/7stZIB5yQM1ocnCBdH\n pJdLazTK0bNUnM6UWGFF7hxKW/PaIp5l3Ao5XtK3wW9QYWIMy9QcRPf3CaBcyargRESq\n 26hzqOrJ33rhB1uyB7zEq5qOa38odsdtUtwgvK/kAvWiWiAOXKGM0Fvrfmst52luFujg\n gGzU+XFAXp0IRmd9UZXz0rz7pSSiqv0RNPuiMLibaIS1c8Jl0HZrxUkAw4QJ9OZEz4sk\n 6+h5csVPc1/Gt/EuSKu+FYuDMrMwiCo2InARc9e/0ZZnC9YH6c/ceCLFJ8vJQlp3h6OY\n V8dw==", "X-Gm-Message-State": "AOAM532w5CFEIPsD9OFGTIQooaxysFNpS/ypCtNWm/sm+t60Hr82JhyJ\n b5AfTVckBWdepP6guLAK8gmlj0gd", "X-Google-Smtp-Source": "\n ABdhPJxq6reJIpHqqq1ZNxe0rdbjVnwm7KawYG41ckEfykIaD81sySVYpVE/A1g21o+quyakuj34yQ==", "X-Received": "by 2002:adf:a157:: with SMTP id r23mr12982188wrr.92.1591928733025;\n Thu, 11 Jun 2020 19:25:33 -0700 (PDT)", "From": "Oliver O'Halloran <oohall@gmail.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 12 Jun 2020 12:24:49 +1000", "Message-Id": "<20200612022452.371685-13-oohall@gmail.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200612022452.371685-1-oohall@gmail.com>", "References": "<20200612022452.371685-1-oohall@gmail.com>", "MIME-Version": "1.0", "Subject": "[Skiboot] [PATCH 12/15] test: Do gcov builds as a seperate pass", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "We only really use the gcov output when doing the coverage report as a\npart of the \"docs\" CI builds. It's useful for development to just run\nthe unit tests so make sure the \"check\" and \"coverage\" targets are\nseperate.\n\nThis also speeds up our CI builds since those jobs are already doing a\nseperate GCOV pass so building and running the GCOV binaries during the\ncheck pass is redundant.\n\nSigned-off-by: Oliver O'Halloran <oohall@gmail.com>\n---\nTbh, we could probably drop the gcov builds outside the docs container.\nWe don't do anything with the gcov output for most of the builds, but I\nguess it's useful to at least verify it builds.\n---\n ccan/Makefile.check | 5 ++---\n core/test/Makefile.check | 3 +--\n hw/ipmi/test/Makefile.check | 2 +-\n libflash/test/Makefile.check | 2 +-\n libstb/secvar/test/Makefile.check | 6 ++----\n libstb/test/Makefile.check | 4 ++--\n 6 files changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/ccan/Makefile.check b/ccan/Makefile.check\nindex a5967661881e..e9c23970fff6 100644\n--- a/ccan/Makefile.check\n+++ b/ccan/Makefile.check\n@@ -4,12 +4,11 @@ LCOV_EXCLUDE += $(CCAN_TEST_SRC) ccan/list/test/helper.c\n \n CCAN_TEST := $(CCAN_TEST_SRC:%.c=%)\n \n-\n-.PHONY: $(CCAN_TEST:%=%-gcov-run) ccan-check\n+.PHONY: ccan-check\n \n ccan-check: $(CCAN_TEST:%=%-check)\n \n-check: ccan-check $(CCAN_TEST:%=%-gcov-run)\n+check: ccan-check\n \n .PHONY: ccan-coverage\n \ndiff --git a/core/test/Makefile.check b/core/test/Makefile.check\nindex 8e59ef00e7b6..7c347bea2a56 100644\n--- a/core/test/Makefile.check\n+++ b/core/test/Makefile.check\n@@ -35,8 +35,7 @@ LCOV_EXCLUDE += $(CORE_TEST:%=%.c) core/test/stubs.c\n LCOV_EXCLUDE += $(CORE_TEST_NOSTUB:%=%.c) /usr/include/*\n \n .PHONY : core-check\n-core-check: $(CORE_TEST:%=%-check) $(CORE_TEST:%=%-gcov-run)\n-core-check: $(CORE_TEST_NOSTUB:%=%-check) $(CORE_TEST_NOSTUB:%=%-gcov-run)\n+core-check: $(CORE_TEST:%=%-check) $(CORE_TEST_NOSTUB:%=%-check)\n \n .PHONY : core-coverage\n core-coverage: $(CORE_TEST:%=%-gcov-run)\ndiff --git a/hw/ipmi/test/Makefile.check b/hw/ipmi/test/Makefile.check\nindex c3d6359c411b..ceed1ed396b8 100644\n--- a/hw/ipmi/test/Makefile.check\n+++ b/hw/ipmi/test/Makefile.check\n@@ -4,7 +4,7 @@ IPMI_TEST := hw/ipmi/test/run-fru\n LCOV_EXCLUDE += $(IPMI_TEST:%=%.c)\n \n .PHONY : hw-ipmi-check hw-ipmi-coverage\n-hw-ipmi-check: $(IPMI_TEST:%=%-check) $(IPMI_TEST:%=%-gcov-run)\n+hw-ipmi-check: $(IPMI_TEST:%=%-check)\n hw-ipmi-coverage: $(IPMI_TEST:%=%-gcov-run)\n \n check: hw-ipmi-check\ndiff --git a/libflash/test/Makefile.check b/libflash/test/Makefile.check\nindex 1e55237193f0..4dbd7ee75203 100644\n--- a/libflash/test/Makefile.check\n+++ b/libflash/test/Makefile.check\n@@ -33,7 +33,7 @@ check_PROGRAMS = \\\n TEST_FLAGS = -D__TEST__ -MMD -MP\n \n .PHONY: libflash-check libflash-coverage\n-libflash-check: $(check_PROGRAMS:%=%-check) $(CORE_TEST:%=%-gcov-run)\n+libflash-check: $(check_PROGRAMS:%=%-check)\n libflash-coverage: $(check_PROGRAMS:%=%-gcov-run)\n clean: libflash-test-clean\n check: libflash-check\ndiff --git a/libstb/secvar/test/Makefile.check b/libstb/secvar/test/Makefile.check\nindex b41eaf4831ba..bba1197e63b5 100644\n--- a/libstb/secvar/test/Makefile.check\n+++ b/libstb/secvar/test/Makefile.check\n@@ -8,12 +8,10 @@ SECVAR_TEST = $(patsubst %.c, %, $(wildcard $(SECVAR_TEST_DIR)/secvar-test-*.c))\n HOSTCFLAGS+=-I . -I include\n \n .PHONY : secvar-check\n-secvar-check: $(SECVAR_TEST:%=%-check) $(SECVAR_TEST:%=%-gcov-run)\n-secvar-check: $(SECVAR_TEST_NOSTUB:%=%-check) $(SECVAR_TEST_NOSTUB:%=%-gcov-run)\n+secvar-check: $(SECVAR_TEST:%=%-check) $(SECVAR_TEST_NOSTUB:%=%-check)\n \n .PHONY : secvar-coverage\n-secvar-coverage: $(SECVAR_TEST:%=%-gcov-run)\n-secvar-coverage: $(SECVAR_TEST_NOSTUB:%=%-gcov-run)\n+secvar-coverage: $(SECVAR_TEST:%=%-gcov-run) $(SECVAR_TEST_NOSTUB:%=%-gcov-run)\n \n check: secvar-check\n coverage: secvar-coverage\ndiff --git a/libstb/test/Makefile.check b/libstb/test/Makefile.check\nindex d4d7cb46c7a2..6911e0aebc75 100644\n--- a/libstb/test/Makefile.check\n+++ b/libstb/test/Makefile.check\n@@ -9,8 +9,8 @@ libstb/test/print-stb-container-q: libstb/print-container\n \t$(call Q, TEST , $(VALGRIND) libstb/print-container -I libstb/test/t.container |diff -u libstb/test/t.container.out -, $< t.container)\n \n .PHONY : libstb-check\n-libstb-check: $(LIBSTB_TEST:%=%-check) $(LIBSTB_TEST:%=%-gcov-run) libstb/test/print-stb-container-check\n-libstb-check: $(LIBSTB_TEST_NOSTUB:%=%-check) $(LIBSTB_TEST_NOSTUB:%=%-gcov-run)\n+libstb-check: $(LIBSTB_TEST:%=%-check) libstb/test/print-stb-container-check\n+libstb-check: $(LIBSTB_TEST_NOSTUB:%=%-check)\n \n .PHONY : libstb-coverage\n libstb-coverage: $(LIBSTB_TEST:%=%-gcov-run)\n", "prefixes": [ "12/15" ] }