Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1307024/?format=api
{ "id": 1307024, "url": "http://patchwork.ozlabs.org/api/patches/1307024/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com>", "list_archive_url": null, "date": "2020-06-10T15:03:10", "name": "[v8,32/34] qcow2: Allow preallocation and backing files if extended_l2 is set", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e11b35652200a0e2ff18b473677c9062644aabd6", "submitter": { "id": 65704, "url": "http://patchwork.ozlabs.org/api/people/65704/?format=api", "name": "Alberto Garcia", "email": "berto@igalia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com/mbox/", "series": [ { "id": 182563, "url": "http://patchwork.ozlabs.org/api/series/182563/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=182563", "date": "2020-06-10T15:02:49", "name": "Add subcluster allocation to qcow2", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/182563/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1307024/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1307024/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=igalia.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256\n header.s=20170329 header.b=p+1qR0IX;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49hrLZ6BRBz9sQx\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 11 Jun 2020 01:21:42 +1000 (AEST)", "from localhost ([::1]:46578 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1jj2Xs-0002FB-F4\n\tfor incoming@patchwork.ozlabs.org; Wed, 10 Jun 2020 11:21:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:36156)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berto@igalia.com>)\n id 1jj2Gx-0002kI-Ow; Wed, 10 Jun 2020 11:04:11 -0400", "from fanzine.igalia.com ([178.60.130.6]:58281)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <berto@igalia.com>)\n id 1jj2Gs-0006wq-Mv; Wed, 10 Jun 2020 11:04:11 -0400", "from [81.0.38.199] (helo=perseus.local)\n by fanzine.igalia.com with esmtpsa\n (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim)\n id 1jj2GR-0007hK-S7; Wed, 10 Jun 2020 17:03:39 +0200", "from berto by perseus.local with local (Exim 4.92)\n (envelope-from <berto@igalia.com>)\n id 1jj2GC-0007Nu-KL; Wed, 10 Jun 2020 17:03:24 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n s=20170329;\n h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;\n bh=Qe8I4xk45KAyMdchAgwImV8pKbTbnwpzMgDYFtz3Iqc=;\n b=p+1qR0IXTMWAgO6q0mJqmsde7oZZcbstg6rcU1wnjYDgi6L/tL/3bZbfMJ0/IlIlfka91aGUI5yDTy5C1VRnZxEWK6T8q+L3/5WicPi4L6rnCoTIYJAx8HC0XOTl6RG+RRagx5wqONcNXuzTY+tbeftkvqEn+grjzwgMR+MiXGL6+EAkkc1TPlI08b3BqUpDXL6AiVcfBupc/emGWNp4BTW00uylDntJiPcghoC9c+QczhXtZwg8Zat6j3Wmydco7a55E6LNNB7jAvHhIbhwfX60INhzLY7eomrljssoubQEzICpIyOlVD0I6ZhrQH6idihKhgNVhgHuWeaxWL/cVw==;", "From": "Alberto Garcia <berto@igalia.com>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH v8 32/34] qcow2: Allow preallocation and backing files if\n extended_l2 is set", "Date": "Wed, 10 Jun 2020 17:03:10 +0200", "Message-Id": "\n <7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<cover.1591801197.git.berto@igalia.com>", "References": "<cover.1591801197.git.berto@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=178.60.130.6; envelope-from=berto@igalia.com;\n helo=fanzine.igalia.com", "X-detected-operating-system": "by eggs.gnu.org: First seen = 2020/06/10 11:03:39", "X-ACL-Warn": "Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy]", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=_AUTOLEARN", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>,\n Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,\n Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org,\n Derek Su <dereksu@qnap.com>, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Traditional qcow2 images don't allow preallocation if a backing file\nis set. This is because once a cluster is allocated there is no way to\ntell that its data should be read from the backing file.\n\nExtended L2 entries have individual allocation bits for each\nsubcluster, and therefore it is perfectly possible to have an\nallocated cluster with all its subclusters unallocated.\n\nSigned-off-by: Alberto Garcia <berto@igalia.com>\n---\n block/qcow2.c | 7 ++++---\n tests/qemu-iotests/206.out | 2 +-\n 2 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/block/qcow2.c b/block/qcow2.c\nindex 37bfae823c..1ea8d3b87e 100644\n--- a/block/qcow2.c\n+++ b/block/qcow2.c\n@@ -3451,10 +3451,11 @@ qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp)\n qcow2_opts->preallocation = PREALLOC_MODE_OFF;\n }\n if (qcow2_opts->has_backing_file &&\n- qcow2_opts->preallocation != PREALLOC_MODE_OFF)\n+ qcow2_opts->preallocation != PREALLOC_MODE_OFF &&\n+ !qcow2_opts->extended_l2)\n {\n- error_setg(errp, \"Backing file and preallocation cannot be used at \"\n- \"the same time\");\n+ error_setg(errp, \"Backing file and preallocation can only be used at \"\n+ \"the same time if extended_l2 is on\");\n ret = -EINVAL;\n goto out;\n }\ndiff --git a/tests/qemu-iotests/206.out b/tests/qemu-iotests/206.out\nindex 363c5abe35..a100849fcb 100644\n--- a/tests/qemu-iotests/206.out\n+++ b/tests/qemu-iotests/206.out\n@@ -203,7 +203,7 @@ Job failed: Different refcount widths than 16 bits require compatibility level 1\n === Invalid backing file options ===\n {\"execute\": \"blockdev-create\", \"arguments\": {\"job-id\": \"job0\", \"options\": {\"backing-file\": \"/dev/null\", \"driver\": \"qcow2\", \"file\": \"node0\", \"preallocation\": \"full\", \"size\": 67108864}}}\n {\"return\": {}}\n-Job failed: Backing file and preallocation cannot be used at the same time\n+Job failed: Backing file and preallocation can only be used at the same time if extended_l2 is on\n {\"execute\": \"job-dismiss\", \"arguments\": {\"id\": \"job0\"}}\n {\"return\": {}}\n \n", "prefixes": [ "v8", "32/34" ] }