Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1305219/?format=api
{ "id": 1305219, "url": "http://patchwork.ozlabs.org/api/patches/1305219/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200608154939.30699-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200608154939.30699-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2020-06-08T15:49:39", "name": "[v1,1/1] igc: Refactor the igc_power_down_link()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "23bcb093e3b1fe209b169cef91eb33648988cbee", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200608154939.30699-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 182001, "url": "http://patchwork.ozlabs.org/api/series/182001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=182001", "date": "2020-06-08T15:49:39", "name": "[v1,1/1] igc: Refactor the igc_power_down_link()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/182001/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1305219/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1305219/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49gd401M1Dz9sRR\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 9 Jun 2020 01:49:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2CF8B8759B;\n\tMon, 8 Jun 2020 15:49:50 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5WfjqQMymW0H; Mon, 8 Jun 2020 15:49:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 40CCA86420;\n\tMon, 8 Jun 2020 15:49:49 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id ED6241BF370\n for <intel-wired-lan@lists.osuosl.org>; Mon, 8 Jun 2020 15:49:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id E8CE786420\n for <intel-wired-lan@lists.osuosl.org>; Mon, 8 Jun 2020 15:49:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 6bJN3PXIusGo for <intel-wired-lan@lists.osuosl.org>;\n Mon, 8 Jun 2020 15:49:42 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 411DE87595\n for <intel-wired-lan@lists.osuosl.org>; Mon, 8 Jun 2020 15:49:42 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jun 2020 08:49:41 -0700", "from ccdlinuxdev09.iil.intel.com ([143.185.160.241])\n by orsmga007.jf.intel.com with ESMTP; 08 Jun 2020 08:49:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n aw9Zf4PKOVE8Rygf7RF1UzOvvs6Go1leynI0Lk+p+e7uSq0G1i1Ib19CkyTLvA7ausvDIsvZk/\n DJyrTBi/R7ug==", "\n bcsEZQGLq5UfKFWg3f1X/432FO9y3PV+P+5Yh2bOUq1sArCHSUV/On2L7ndfMSDp71yyhg8OkH\n ehvaaoaU/qYg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,487,1583222400\"; d=\"scan'208\";a=\"259486049\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 8 Jun 2020 18:49:39 +0300", "Message-Id": "<20200608154939.30699-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 1/1] igc: Refactor the\n igc_power_down_link()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Currently inplementation of the igc_power_down_link()\nmethod a bit tangled. This method just called\nigc_power_down_phy_copper-base() method.\nWe can just call the igc_power_down_phy_copper_base()\nmethod directly.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 16 +++-------------\n 1 file changed, 3 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 5d70751e8ab3..af5e1686f7f2 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -61,16 +61,6 @@ enum latency_range {\n \tlatency_invalid = 255\n };\n \n-/**\n- * igc_power_down_link - Power down the phy link\n- * @adapter: address of board private structure\n- */\n-static void igc_power_down_link(struct igc_adapter *adapter)\n-{\n-\tif (adapter->hw.phy.media_type == igc_media_type_copper)\n-\t\tigc_power_down_phy_copper_base(&adapter->hw);\n-}\n-\n void igc_reset(struct igc_adapter *adapter)\n {\n \tstruct net_device *dev = adapter->netdev;\n@@ -106,7 +96,7 @@ void igc_reset(struct igc_adapter *adapter)\n \tigc_set_eee_i225(hw, true, true, true);\n \n \tif (!netif_running(adapter->netdev))\n-\t\tigc_power_down_link(adapter);\n+\t\tigc_power_down_phy_copper_base(&adapter->hw);\n \n \t/* Re-enable PTP, where applicable. */\n \tigc_ptp_reset(adapter);\n@@ -4617,7 +4607,7 @@ static int __igc_open(struct net_device *netdev, bool resuming)\n \tigc_free_irq(adapter);\n err_req_irq:\n \tigc_release_hw_control(adapter);\n-\tigc_power_down_link(adapter);\n+\tigc_power_down_phy_copper_base(&adapter->hw);\n \tigc_free_all_rx_resources(adapter);\n err_setup_rx:\n \tigc_free_all_tx_resources(adapter);\n@@ -5316,7 +5306,7 @@ static int __igc_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \n \twake = wufc || adapter->en_mng_pt;\n \tif (!wake)\n-\t\tigc_power_down_link(adapter);\n+\t\tigc_power_down_phy_copper_base(&adapter->hw);\n \telse\n \t\tigc_power_up_link(adapter);\n \n", "prefixes": [ "v1", "1/1" ] }