Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1304289/?format=api
{ "id": 1304289, "url": "http://patchwork.ozlabs.org/api/patches/1304289/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200605170946.23494-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200605170946.23494-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-06-05T17:09:44", "name": "[2/4] iavf: use appropriate enum for comparison", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fbac52590bcfaab7b92e08cb32473f58843ffd99", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200605170946.23494-2-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 181598, "url": "http://patchwork.ozlabs.org/api/series/181598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=181598", "date": "2020-06-05T17:09:45", "name": "[1/4] iavf: fix speed reporting over virtchnl", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/181598/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1304289/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1304289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49dq2f4kqwz9sSF\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 6 Jun 2020 03:12:26 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3893D88B3D;\n\tFri, 5 Jun 2020 17:12:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lENIU2M3DJ5K; Fri, 5 Jun 2020 17:12:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8FF6288ACE;\n\tFri, 5 Jun 2020 17:12:22 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 7F6B01BF30B\n for <intel-wired-lan@lists.osuosl.org>; Fri, 5 Jun 2020 17:12:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 77E6420371\n for <intel-wired-lan@lists.osuosl.org>; Fri, 5 Jun 2020 17:12:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id C7xN1GAf7E2J for <intel-wired-lan@lists.osuosl.org>;\n Fri, 5 Jun 2020 17:12:16 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by silver.osuosl.org (Postfix) with ESMTPS id BE86923307\n for <intel-wired-lan@lists.osuosl.org>; Fri, 5 Jun 2020 17:12:16 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Jun 2020 10:12:15 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by orsmga006.jf.intel.com with ESMTP; 05 Jun 2020 10:12:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n WTlXh+OSruFbsTdUfuNRuVhFcMLcwMCnkKdA2o+F3qbMHSrA+GMt8SdaVBzQEgUa1I9cirzQZs\n ARVVQNu9DqKw==", "\n PgJcwf/2+Xlg/Gqpf6FP+xi7p3oKbA1/qLpn5aWZiMRpkt0/nqQYuBet4sadt/eTSxXnbjfaqy\n nnmvLCbOTedA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,477,1583222400\"; d=\"scan'208\";a=\"273530622\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 5 Jun 2020 10:09:44 -0700", "Message-Id": "<20200605170946.23494-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200605170946.23494-1-anthony.l.nguyen@intel.com>", "References": "<20200605170946.23494-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 2/4] iavf: use appropriate enum for\n comparison", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n\nadapter->link_speed has type enum virtchnl_link_speed but our comparisons\nare against enum iavf_aq_link_speed. Though they are, currently, the same\nvalues, change the comparison to the matching enum virtchnl_link_speed\nsince that may not always be the case.\n\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 17 ++++++-----------\n drivers/net/ethernet/intel/iavf/iavf_main.c | 12 ++++++------\n drivers/net/ethernet/intel/iavf/iavf_txrx.c | 12 ++++++------\n drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++------\n 4 files changed, 24 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\nindex 60a3519713d4..86b6288b961e 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c\n@@ -291,27 +291,22 @@ static int iavf_get_link_ksettings(struct net_device *netdev,\n \t}\n \n \tswitch (adapter->link_speed) {\n-\tcase IAVF_LINK_SPEED_40GB:\n+\tcase VIRTCHNL_LINK_SPEED_40GB:\n \t\tcmd->base.speed = SPEED_40000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_25GB:\n-#ifdef SPEED_25000\n+\tcase VIRTCHNL_LINK_SPEED_25GB:\n \t\tcmd->base.speed = SPEED_25000;\n-#else\n-\t\tnetdev_info(netdev,\n-\t\t\t \"Speed is 25G, display not supported by this version of ethtool.\\n\");\n-#endif\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_20GB:\n+\tcase VIRTCHNL_LINK_SPEED_20GB:\n \t\tcmd->base.speed = SPEED_20000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_10GB:\n+\tcase VIRTCHNL_LINK_SPEED_10GB:\n \t\tcmd->base.speed = SPEED_10000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_1GB:\n+\tcase VIRTCHNL_LINK_SPEED_1GB:\n \t\tcmd->base.speed = SPEED_1000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_100MB:\n+\tcase VIRTCHNL_LINK_SPEED_100MB:\n \t\tcmd->base.speed = SPEED_100;\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex 0e2be56081e1..8307274fabc5 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -2487,22 +2487,22 @@ static int iavf_validate_tx_bandwidth(struct iavf_adapter *adapter,\n \t}\n \n \tswitch (adapter->link_speed) {\n-\tcase IAVF_LINK_SPEED_40GB:\n+\tcase VIRTCHNL_LINK_SPEED_40GB:\n \t\tspeed = 40000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_25GB:\n+\tcase VIRTCHNL_LINK_SPEED_25GB:\n \t\tspeed = 25000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_20GB:\n+\tcase VIRTCHNL_LINK_SPEED_20GB:\n \t\tspeed = 20000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_10GB:\n+\tcase VIRTCHNL_LINK_SPEED_10GB:\n \t\tspeed = 10000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_1GB:\n+\tcase VIRTCHNL_LINK_SPEED_1GB:\n \t\tspeed = 1000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_100MB:\n+\tcase VIRTCHNL_LINK_SPEED_100MB:\n \t\tspeed = 100;\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c\nindex 17a405da9d16..ca041b39ffda 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c\n@@ -379,19 +379,19 @@ static inline unsigned int iavf_itr_divisor(struct iavf_q_vector *q_vector)\n \tunsigned int divisor;\n \n \tswitch (q_vector->adapter->link_speed) {\n-\tcase IAVF_LINK_SPEED_40GB:\n+\tcase VIRTCHNL_LINK_SPEED_40GB:\n \t\tdivisor = IAVF_ITR_ADAPTIVE_MIN_INC * 1024;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_25GB:\n-\tcase IAVF_LINK_SPEED_20GB:\n+\tcase VIRTCHNL_LINK_SPEED_25GB:\n+\tcase VIRTCHNL_LINK_SPEED_20GB:\n \t\tdivisor = IAVF_ITR_ADAPTIVE_MIN_INC * 512;\n \t\tbreak;\n \tdefault:\n-\tcase IAVF_LINK_SPEED_10GB:\n+\tcase VIRTCHNL_LINK_SPEED_10GB:\n \t\tdivisor = IAVF_ITR_ADAPTIVE_MIN_INC * 256;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_1GB:\n-\tcase IAVF_LINK_SPEED_100MB:\n+\tcase VIRTCHNL_LINK_SPEED_1GB:\n+\tcase VIRTCHNL_LINK_SPEED_100MB:\n \t\tdivisor = IAVF_ITR_ADAPTIVE_MIN_INC * 32;\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\nindex ca79bec4ebd9..c4735589a296 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n@@ -921,22 +921,22 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)\n \t}\n \n \tswitch (adapter->link_speed) {\n-\tcase IAVF_LINK_SPEED_40GB:\n+\tcase VIRTCHNL_LINK_SPEED_40GB:\n \t\tlink_speed_mbps = SPEED_40000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_25GB:\n+\tcase VIRTCHNL_LINK_SPEED_25GB:\n \t\tlink_speed_mbps = SPEED_25000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_20GB:\n+\tcase VIRTCHNL_LINK_SPEED_20GB:\n \t\tlink_speed_mbps = SPEED_20000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_10GB:\n+\tcase VIRTCHNL_LINK_SPEED_10GB:\n \t\tlink_speed_mbps = SPEED_10000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_1GB:\n+\tcase VIRTCHNL_LINK_SPEED_1GB:\n \t\tlink_speed_mbps = SPEED_1000;\n \t\tbreak;\n-\tcase IAVF_LINK_SPEED_100MB:\n+\tcase VIRTCHNL_LINK_SPEED_100MB:\n \t\tlink_speed_mbps = SPEED_100;\n \t\tbreak;\n \tdefault:\n", "prefixes": [ "2/4" ] }