Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1303294/?format=api
{ "id": 1303294, "url": "http://patchwork.ozlabs.org/api/patches/1303294/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200604024129.1399871-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200604024129.1399871-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2020-06-04T02:41:29", "name": "[next-queue] ethernet/intel: Convert fallthrough code comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fd6367daae2599f42fa8e0ccc101244b6173fc90", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200604024129.1399871-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 181202, "url": "http://patchwork.ozlabs.org/api/series/181202/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=181202", "date": "2020-06-04T02:41:29", "name": "[next-queue] ethernet/intel: Convert fallthrough code comments", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/181202/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1303294/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1303294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49cqmZ5yqyz9sSc\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 4 Jun 2020 12:41:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1EAF58814A;\n\tThu, 4 Jun 2020 02:41:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R1mtdpQoJPbw; Thu, 4 Jun 2020 02:41:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0B3148814C;\n\tThu, 4 Jun 2020 02:41:39 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id A470A1BF3F7\n for <intel-wired-lan@lists.osuosl.org>; Thu, 4 Jun 2020 02:41:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 932738814C\n for <intel-wired-lan@lists.osuosl.org>; Thu, 4 Jun 2020 02:41:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id NzeX7IXNRyOq for <intel-wired-lan@lists.osuosl.org>;\n Thu, 4 Jun 2020 02:41:33 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by whitealder.osuosl.org (Postfix) with ESMTPS id B6F948814A\n for <intel-wired-lan@lists.osuosl.org>; Thu, 4 Jun 2020 02:41:33 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Jun 2020 19:41:32 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.86])\n by FMSMGA003.fm.intel.com with ESMTP; 03 Jun 2020 19:41:31 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n kDZO/mY5V0TAcpU8nsFOmMYWNPQSLurhNIt4hP425ge43T6Kg7gTa1mCN4+FZ5XMgtlxKoeUSJ\n hxoCVpSzfDZw==", "\n m2r/nCu/WuqlKMWyRwxN+Cb65s/1Qzm9T61GJpZGrGQ6JwhAuE843t60LA4ytPl0Yv+uEzSvVG\n MGgHj8cOSkEQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,470,1583222400\"; d=\"scan'208\";a=\"312772566\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 3 Jun 2020 19:41:29 -0700", "Message-Id": "<20200604024129.1399871-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue] ethernet/intel: Convert fallthrough\n code comments", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Joe Perches <joe@perches.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Convert all the remaining 'fall through\" code comments to the newer\n'fallthough;' keyword.\n\nSuggested-by: Joe Perches <joe@perches.com>\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 +--\n drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +-\n .../net/ethernet/intel/e1000/e1000_param.c | 2 +-\n drivers/net/ethernet/intel/e1000e/82571.c | 4 +--\n drivers/net/ethernet/intel/e1000e/ethtool.c | 11 ++++---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 14 ++++-----\n drivers/net/ethernet/intel/e1000e/netdev.c | 30 +++++++++----------\n drivers/net/ethernet/intel/e1000e/param.c | 2 +-\n drivers/net/ethernet/intel/e1000e/phy.c | 2 +-\n drivers/net/ethernet/intel/e1000e/ptp.c | 3 +-\n .../net/ethernet/intel/fm10k/fm10k_ethtool.c | 4 +--\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 +--\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 6 ++--\n .../net/ethernet/intel/fm10k/fm10k_netdev.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 8 ++---\n drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +-\n .../net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++--\n drivers/net/ethernet/intel/i40e/i40e_ptp.c | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++--\n drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +--\n drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-\n drivers/net/ethernet/intel/igb/e1000_82575.c | 4 +--\n drivers/net/ethernet/intel/igb/e1000_nvm.c | 2 +-\n drivers/net/ethernet/intel/igb/e1000_phy.c | 4 +--\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 ++---\n drivers/net/ethernet/intel/igb/igb_main.c | 26 ++++++++--------\n drivers/net/ethernet/intel/igb/igb_ptp.c | 2 +-\n drivers/net/ethernet/intel/igbvf/netdev.c | 4 +--\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 16 +++-------\n drivers/net/ethernet/intel/igc/igc_main.c | 5 ++--\n drivers/net/ethernet/intel/igc/igc_ptp.c | 2 +-\n .../net/ethernet/intel/ixgbe/ixgbe_82598.c | 2 +-\n .../net/ethernet/intel/ixgbe/ixgbe_82599.c | 6 ++--\n .../net/ethernet/intel/ixgbe/ixgbe_common.c | 4 +--\n .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 10 +++----\n drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 30 +++++++++----------\n drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 4 +--\n .../net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +--\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 10 +++----\n drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 4 +--\n .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 10 +++----\n drivers/net/ethernet/intel/ixgbevf/vf.c | 6 ++--\n 44 files changed, 136 insertions(+), 152 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c\nindex 623e516a9630..4e7a0810eaeb 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c\n@@ -4526,7 +4526,7 @@ s32 e1000_setup_led(struct e1000_hw *hw)\n \t\t\t\t\t\t ~IGP01E1000_GMII_SPD));\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tdefault:\n \t\tif (hw->media_type == e1000_media_type_fiber) {\n \t\t\tledctl = er32(LEDCTL);\n@@ -4571,7 +4571,7 @@ s32 e1000_cleanup_led(struct e1000_hw *hw)\n \t\t\t\t\t hw->phy_spd_default);\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tdefault:\n \t\t/* Restore LEDCTL settings */\n \t\tew32(LEDCTL, hw->ledctl_default);\ndiff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex 266899c0c933..1e6ec081fd9d 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -1138,7 +1138,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t\tEEPROM_INIT_CONTROL3_PORT_B, 1, &eeprom_data);\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tdefault:\n \t\te1000_read_eeprom(hw,\n \t\t\tEEPROM_INIT_CONTROL3_PORT_A, 1, &eeprom_data);\n@@ -3154,7 +3154,6 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb,\n \t\t\t\tif ((unsigned long)(skb_tail_pointer(skb) - 1)\n \t\t\t\t & 4)\n \t\t\t\t\tbreak;\n-\t\t\t\t/* fall through */\n \t\t\t\tpull_size = min((unsigned int)4, skb->data_len);\n \t\t\t\tif (!__pskb_pull_tail(skb, pull_size)) {\n \t\t\t\t\te_err(drv, \"__pskb_pull_tail \"\ndiff --git a/drivers/net/ethernet/intel/e1000/e1000_param.c b/drivers/net/ethernet/intel/e1000/e1000_param.c\nindex d3f29ffe1e47..4d4f5bf1e516 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_param.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_param.c\n@@ -708,7 +708,7 @@ static void e1000_check_copper_options(struct e1000_adapter *adapter)\n \t\tgoto full_duplex_only;\n \tcase SPEED_1000 + HALF_DUPLEX:\n \t\te_dev_info(\"Half Duplex is not supported at 1000 Mbps\\n\");\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase SPEED_1000 + FULL_DUPLEX:\n full_duplex_only:\n \t\te_dev_info(\"Using Autonegotiation at 1000 Mbps Full Duplex \"\ndiff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c\nindex 2c1bab377b2a..88faf05e23ba 100644\n--- a/drivers/net/ethernet/intel/e1000e/82571.c\n+++ b/drivers/net/ethernet/intel/e1000e/82571.c\n@@ -154,7 +154,7 @@ static s32 e1000_init_nvm_params_82571(struct e1000_hw *hw)\n \t\t\tew32(EECD, eecd);\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tdefault:\n \t\tnvm->type = e1000_nvm_eeprom_spi;\n \t\tsize = (u16)((eecd & E1000_EECD_SIZE_EX_MASK) >>\n@@ -1107,7 +1107,7 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw)\n \tswitch (mac->type) {\n \tcase e1000_82573:\n \t\te1000e_enable_tx_pkt_filtering(hw);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_82574:\n \tcase e1000_82583:\n \t\treg_data = er32(GCR);\ndiff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c\nindex 11de79e49661..64f684dc6c7a 100644\n--- a/drivers/net/ethernet/intel/e1000e/ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c\n@@ -893,7 +893,6 @@ static int e1000_reg_test(struct e1000_adapter *adapter, u64 *data)\n \tcase e1000_pch_lpt:\n \tcase e1000_pch_spt:\n \tcase e1000_pch_cnp:\n-\t\t/* fall through */\n \tcase e1000_pch_tgp:\n \tcase e1000_pch_adp:\n \t\tmask |= BIT(18);\n@@ -1569,7 +1568,7 @@ static void e1000_loopback_cleanup(struct e1000_adapter *adapter)\n \t\t/* set bit 29 (value of MULR requests is now 0) */\n \t\ttarc0 &= 0xcfffffff;\n \t\tew32(TARC(0), tarc0);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_80003es2lan:\n \t\tif (hw->phy.media_type == e1000_media_type_fiber ||\n \t\t hw->phy.media_type == e1000_media_type_internal_serdes) {\n@@ -1577,7 +1576,7 @@ static void e1000_loopback_cleanup(struct e1000_adapter *adapter)\n \t\t\tew32(CTRL_EXT, adapter->tx_fifo_head);\n \t\t\tadapter->tx_fifo_head = 0;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_82571:\n \tcase e1000_82572:\n \t\tif (hw->phy.media_type == e1000_media_type_fiber ||\n@@ -1587,7 +1586,7 @@ static void e1000_loopback_cleanup(struct e1000_adapter *adapter)\n \t\t\tusleep_range(10000, 11000);\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tdefault:\n \t\thw->mac.autoneg = 1;\n \t\tif (hw->phy.type == e1000_phy_gg82563)\n@@ -2122,7 +2121,7 @@ static int e1000_get_rxnfc(struct net_device *netdev,\n \t\tcase TCP_V4_FLOW:\n \t\t\tif (mrqc & E1000_MRQC_RSS_FIELD_IPV4_TCP)\n \t\t\t\tinfo->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tcase UDP_V4_FLOW:\n \t\tcase SCTP_V4_FLOW:\n \t\tcase AH_ESP_V4_FLOW:\n@@ -2133,7 +2132,7 @@ static int e1000_get_rxnfc(struct net_device *netdev,\n \t\tcase TCP_V6_FLOW:\n \t\t\tif (mrqc & E1000_MRQC_RSS_FIELD_IPV6_TCP)\n \t\t\t\tinfo->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tcase UDP_V6_FLOW:\n \t\tcase SCTP_V6_FLOW:\n \t\tcase AH_ESP_V6_FLOW:\ndiff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 9cbd2d6c7da4..8f0abffa6415 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -338,12 +338,12 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw)\n \t\t */\n \t\tmsleep(50);\n \n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tcase e1000_pch2lan:\n \t\tif (e1000_phy_is_accessible_pchlan(hw))\n \t\t\tbreak;\n \n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tcase e1000_pchlan:\n \t\tif ((hw->mac.type == e1000_pchlan) &&\n \t\t (fwsm & E1000_ICH_FWSM_FW_VALID))\n@@ -459,7 +459,7 @@ static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw)\n \t\t\t\treturn ret_val;\n \t\t\tif ((phy->id != 0) && (phy->id != PHY_REVISION_MASK))\n \t\t\t\tbreak;\n-\t\t\t/* fall-through */\n+\t\t\tfallthrough;\n \t\tcase e1000_pch2lan:\n \t\tcase e1000_pch_lpt:\n \t\tcase e1000_pch_spt:\n@@ -704,7 +704,7 @@ static s32 e1000_init_mac_params_ich8lan(struct e1000_hw *hw)\n \tcase e1000_pch2lan:\n \t\tmac->rar_entry_count = E1000_PCH2_RAR_ENTRIES;\n \t\tmac->ops.rar_set = e1000_rar_set_pch2lan;\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tcase e1000_pch_lpt:\n \tcase e1000_pch_spt:\n \tcase e1000_pch_cnp:\n@@ -1559,7 +1559,7 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \t\tret_val = e1000_k1_workaround_lv(hw);\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n-\t\t/* fall-thru */\n+\t\tfallthrough;\n \tcase e1000_pchlan:\n \t\tif (hw->phy.type == e1000_phy_82578) {\n \t\t\tret_val = e1000_link_stall_workaround_hv(hw);\n@@ -2096,7 +2096,7 @@ static s32 e1000_sw_lcd_config_ich8lan(struct e1000_hw *hw)\n \t\t\tsw_cfg_mask = E1000_FEXTNVM_SW_CONFIG;\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall-thru */\n+\t\tfallthrough;\n \tcase e1000_pchlan:\n \tcase e1000_pch2lan:\n \tcase e1000_pch_lpt:\n@@ -3189,7 +3189,7 @@ static s32 e1000_valid_nvm_bank_detect_ich8lan(struct e1000_hw *hw, u32 *bank)\n \t\t\treturn 0;\n \t\t}\n \t\te_dbg(\"Unable to determine valid NVM bank via EEC - reading flash signature\\n\");\n-\t\t/* fall-thru */\n+\t\tfallthrough;\n \tdefault:\n \t\t/* set bank to 0 in case flash read fails */\n \t\t*bank = 0;\ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex e0867771847f..377f9c0e2e5f 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -2107,7 +2107,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter)\n \t\t\te1000e_reset_interrupt_capability(adapter);\n \t\t}\n \t\tadapter->int_mode = E1000E_INT_MODE_MSI;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase E1000E_INT_MODE_MSI:\n \t\tif (!pci_enable_msi(adapter->pdev)) {\n \t\t\tadapter->flags |= FLAG_MSI_ENABLED;\n@@ -2115,7 +2115,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter)\n \t\t\tadapter->int_mode = E1000E_INT_MODE_LEGACY;\n \t\t\te_err(\"Failed to initialize MSI interrupts. Falling back to legacy interrupts.\\n\");\n \t\t}\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase E1000E_INT_MODE_LEGACY:\n \t\t/* Don't do anything; this is the system default */\n \t\tbreak;\n@@ -3173,10 +3173,10 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)\n \t\tswitch (adapter->rx_ps_pages) {\n \t\tcase 3:\n \t\t\tpsrctl |= PAGE_SIZE << E1000_PSRCTL_BSIZE3_SHIFT;\n-\t\t\t/* fall-through */\n+\t\t\tfallthrough;\n \t\tcase 2:\n \t\t\tpsrctl |= PAGE_SIZE << E1000_PSRCTL_BSIZE2_SHIFT;\n-\t\t\t/* fall-through */\n+\t\t\tfallthrough;\n \t\tcase 1:\n \t\t\tpsrctl |= PAGE_SIZE >> E1000_PSRCTL_BSIZE1_SHIFT;\n \t\t\tbreak;\n@@ -3673,9 +3673,8 @@ static int e1000e_config_hwtstamp(struct e1000_adapter *adapter,\n \t\tis_l2 = true;\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V2_L4_SYNC:\n-\t\t/* Hardware cannot filter just V2 L4 Sync messages;\n-\t\t * fall-through to V2 (both L2 and L4) Sync.\n-\t\t */\n+\t\t/* Hardware cannot filter just V2 L4 Sync messages */\n+\t\tfallthrough;\n \tcase HWTSTAMP_FILTER_PTP_V2_SYNC:\n \t\t/* Also time stamps V2 Path Delay Request/Response. */\n \t\ttsync_rx_ctl |= E1000_TSYNCRXCTL_TYPE_L2_L4_V2;\n@@ -3684,9 +3683,8 @@ static int e1000e_config_hwtstamp(struct e1000_adapter *adapter,\n \t\tis_l4 = true;\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:\n-\t\t/* Hardware cannot filter just V2 L4 Delay Request messages;\n-\t\t * fall-through to V2 (both L2 and L4) Delay Request.\n-\t\t */\n+\t\t/* Hardware cannot filter just V2 L4 Delay Request messages */\n+\t\tfallthrough;\n \tcase HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:\n \t\t/* Also time stamps V2 Path Delay Request/Response. */\n \t\ttsync_rx_ctl |= E1000_TSYNCRXCTL_TYPE_L2_L4_V2;\n@@ -3696,9 +3694,8 @@ static int e1000e_config_hwtstamp(struct e1000_adapter *adapter,\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V2_L4_EVENT:\n \tcase HWTSTAMP_FILTER_PTP_V2_L2_EVENT:\n-\t\t/* Hardware cannot filter just V2 L4 or L2 Event messages;\n-\t\t * fall-through to all V2 (both L2 and L4) Events.\n-\t\t */\n+\t\t/* Hardware cannot filter just V2 L4 or L2 Event messages */\n+\t\tfallthrough;\n \tcase HWTSTAMP_FILTER_PTP_V2_EVENT:\n \t\ttsync_rx_ctl |= E1000_TSYNCRXCTL_TYPE_EVENT_V2;\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;\n@@ -3710,6 +3707,7 @@ static int e1000e_config_hwtstamp(struct e1000_adapter *adapter,\n \t\t * Delay Request messages but not both so fall-through to\n \t\t * time stamp all packets.\n \t\t */\n+\t\tfallthrough;\n \tcase HWTSTAMP_FILTER_NTP_ALL:\n \tcase HWTSTAMP_FILTER_ALL:\n \t\tis_l2 = true;\n@@ -4056,7 +4054,7 @@ void e1000e_reset(struct e1000_adapter *adapter)\n \t\t\tfc->low_water = fc->high_water - 8;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tdefault:\n \t\thwm = min(((pba << 10) * 9 / 10),\n \t\t\t ((pba << 10) - adapter->max_frame_size));\n@@ -4081,7 +4079,7 @@ void e1000e_reset(struct e1000_adapter *adapter)\n \tcase e1000_pch_lpt:\n \tcase e1000_pch_spt:\n \tcase e1000_pch_cnp:\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tcase e1000_pch_tgp:\n \tcase e1000_pch_adp:\n \t\tfc->refresh_time = 0xFFFF;\n@@ -6764,7 +6762,7 @@ static void __e1000e_disable_aspm(struct pci_dev *pdev, u16 state, int locked)\n \tcase PCIE_LINK_STATE_L0S:\n \tcase PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1:\n \t\taspm_dis_mask |= PCI_EXP_LNKCTL_ASPM_L0S;\n-\t\t/* fall-through - can't have L1 without L0s */\n+\t\tfallthrough; /* can't have L1 without L0s */\n \tcase PCIE_LINK_STATE_L1:\n \t\taspm_dis_mask |= PCI_EXP_LNKCTL_ASPM_L1;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c\nindex 098369fd3e65..ebe121db4307 100644\n--- a/drivers/net/ethernet/intel/e1000e/param.c\n+++ b/drivers/net/ethernet/intel/e1000e/param.c\n@@ -375,7 +375,7 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n \t\t\t\t \"%s Invalid mode - setting default\\n\",\n \t\t\t\t opt.name);\n \t\t\tadapter->itr_setting = opt.def;\n-\t\t\t/* fall-through */\n+\t\t\tfallthrough;\n \t\tcase 3:\n \t\t\tdev_info(&adapter->pdev->dev,\n \t\t\t\t \"%s set to dynamic conservative mode\\n\",\ndiff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c\nindex 42233019255a..e11c877595fb 100644\n--- a/drivers/net/ethernet/intel/e1000e/phy.c\n+++ b/drivers/net/ethernet/intel/e1000e/phy.c\n@@ -607,7 +607,7 @@ static s32 e1000_set_master_slave_mode(struct e1000_hw *hw)\n \t\tbreak;\n \tcase e1000_ms_auto:\n \t\tphy_data &= ~CTL1000_ENABLE_MASTER;\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c\nindex 439fda2f5368..34b988d70488 100644\n--- a/drivers/net/ethernet/intel/e1000e/ptp.c\n+++ b/drivers/net/ethernet/intel/e1000e/ptp.c\n@@ -295,7 +295,6 @@ void e1000e_ptp_init(struct e1000_adapter *adapter)\n \tcase e1000_pch_lpt:\n \tcase e1000_pch_spt:\n \tcase e1000_pch_cnp:\n-\t\t/* fall-through */\n \tcase e1000_pch_tgp:\n \tcase e1000_pch_adp:\n \t\tif ((hw->mac.type < e1000_pch_lpt) ||\n@@ -303,7 +302,7 @@ void e1000e_ptp_init(struct e1000_adapter *adapter)\n \t\t\tadapter->ptp_clock_info.max_adj = 24000000 - 1;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tcase e1000_82574:\n \tcase e1000_82583:\n \t\tadapter->ptp_clock_info.max_adj = 600000000 - 1;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex 30ea2b422678..908fefaa6b85 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -692,12 +692,12 @@ static int fm10k_get_rss_hash_opts(struct fm10k_intfc *interface,\n \tcase TCP_V4_FLOW:\n \tcase TCP_V6_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase UDP_V4_FLOW:\n \t\tif (test_bit(FM10K_FLAG_RSS_FIELD_IPV4_UDP,\n \t\t\t interface->flags))\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase SCTP_V4_FLOW:\n \tcase SCTP_V6_FLOW:\n \tcase AH_ESP_V4_FLOW:\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 05e9bdb5f4aa..34f1f5350f68 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -856,7 +856,7 @@ static void fm10k_tx_csum(struct fm10k_ring *tx_ring,\n \tcase IPPROTO_GRE:\n \t\tif (skb->encapsulation)\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tif (unlikely(net_ratelimit())) {\n \t\t\tdev_warn(tx_ring->dev,\n@@ -1554,7 +1554,7 @@ static bool fm10k_set_rss_queues(struct fm10k_intfc *interface)\n * important, starting with the \"most\" number of features turned on at once,\n * and ending with the smallest set of features. This way large combinations\n * can be allocated if they're turned on, and smaller combinations are the\n- * fallthrough conditions.\n+ * fall through conditions.\n *\n **/\n static void fm10k_set_num_queues(struct fm10k_intfc *interface)\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\nindex 75e51f91036c..8e2e92bf3cd4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n@@ -967,7 +967,7 @@ static s32 fm10k_mbx_validate_msg_hdr(struct fm10k_mbx_info *mbx)\n \t\tif (tail != mbx->head)\n \t\t\treturn FM10K_MBX_ERR_TAIL;\n \n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase FM10K_MSG_DATA:\n \t\t/* validate that head is moving correctly */\n \t\tif (!head || (head == FM10K_MSG_HDR_MASK(HEAD)))\n@@ -987,7 +987,7 @@ static s32 fm10k_mbx_validate_msg_hdr(struct fm10k_mbx_info *mbx)\n \t\tif ((size < FM10K_VFMBX_MSG_MTU) || (size & (size + 1)))\n \t\t\treturn FM10K_MBX_ERR_SIZE;\n \n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase FM10K_MSG_ERROR:\n \t\tif (!head || (head == FM10K_MSG_HDR_MASK(HEAD)))\n \t\t\treturn FM10K_MBX_ERR_HEAD;\n@@ -1570,7 +1570,7 @@ s32 fm10k_pfvf_mbx_init(struct fm10k_hw *hw, struct fm10k_mbx_info *mbx,\n \t\t\tmbx->mbmem_reg = FM10K_MBMEM_VF(id, 0);\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn FM10K_MBX_ERR_NO_MBX;\n \t}\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 0637ccadee79..1450a9f98c5a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -853,7 +853,7 @@ void fm10k_clear_macvlan_queue(struct fm10k_intfc *interface,\n \t\t\t/* Don't free requests for other interfaces */\n \t\t\tif (r->mac.glort != glort)\n \t\t\t\tbreak;\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tcase FM10K_VLAN_REQUEST:\n \t\t\tif (vlans) {\n \t\t\t\tlist_del(&r->list);\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex be07bfdb0bb4..c0780c3624c8 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1317,19 +1317,19 @@ static u8 fm10k_iov_supported_xcast_mode_pf(struct fm10k_vf_info *vf_info,\n \tcase FM10K_XCAST_MODE_PROMISC:\n \t\tif (vf_flags & FM10K_VF_FLAG_PROMISC_CAPABLE)\n \t\t\treturn FM10K_XCAST_MODE_PROMISC;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase FM10K_XCAST_MODE_ALLMULTI:\n \t\tif (vf_flags & FM10K_VF_FLAG_ALLMULTI_CAPABLE)\n \t\t\treturn FM10K_XCAST_MODE_ALLMULTI;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase FM10K_XCAST_MODE_MULTI:\n \t\tif (vf_flags & FM10K_VF_FLAG_MULTI_CAPABLE)\n \t\t\treturn FM10K_XCAST_MODE_MULTI;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase FM10K_XCAST_MODE_NONE:\n \t\tif (vf_flags & FM10K_VF_FLAG_NONE_CAPABLE)\n \t\t\treturn FM10K_XCAST_MODE_NONE;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\nindex 6a089848c857..c897a2863e4f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c\n@@ -541,7 +541,7 @@ static void i40e_set_hw_flags(struct i40e_hw *hw)\n \t\t (aq->api_maj_ver == 1 &&\n \t\t aq->api_min_ver >= I40E_MINOR_VER_GET_LINK_INFO_X722))\n \t\t\thw->flags |= I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 2dfd87f0bdfd..e28a3d1b38cc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -4099,7 +4099,7 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi,\n \tswitch (fsp->flow_type & ~FLOW_EXT) {\n \tcase SCTP_V4_FLOW:\n \t\tnew_mask &= ~I40E_VERIFY_TAG_MASK;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase TCP_V4_FLOW:\n \tcase UDP_V4_FLOW:\n \t\ttcp_ip4_spec = &fsp->m_u.tcp_ip4_spec;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ac131522ecd3..620ae1e21136 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1808,7 +1808,7 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,\n \t\t\t\t\t\t num_tc_qps);\n \t\t\t\t\tbreak;\n \t\t\t\t}\n-\t\t\t\t/* fall through */\n+\t\t\t\tfallthrough;\n \t\t\tcase I40E_VSI_FDIR:\n \t\t\tcase I40E_VSI_SRIOV:\n \t\t\tcase I40E_VSI_VMDQ2:\n@@ -13682,8 +13682,7 @@ struct i40e_vsi *i40e_vsi_setup(struct i40e_pf *pf, u8 type,\n \t\t/* Setup DCB netlink interface */\n \t\ti40e_dcbnl_setup(vsi);\n #endif /* CONFIG_I40E_DCB */\n-\t\t/* fall through */\n-\n+\t\tfallthrough;\n \tcase I40E_VSI_FDIR:\n \t\t/* set up vectors and rings if needed */\n \t\tret = i40e_vsi_setup_vectors(vsi);\n@@ -13699,7 +13698,6 @@ struct i40e_vsi *i40e_vsi_setup(struct i40e_pf *pf, u8 type,\n \n \t\ti40e_vsi_reset_stats(vsi);\n \t\tbreak;\n-\n \tdefault:\n \t\t/* no netdev or rings for the other VSI types */\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\nindex 9bf1ad4319f5..ff7b19c6bc73 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n@@ -586,7 +586,7 @@ static int i40e_ptp_set_timestamp_mode(struct i40e_pf *pf,\n \tcase HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:\n \t\tif (!(pf->hw_features & I40E_HW_PTP_L4_CAPABLE))\n \t\t\treturn -ERANGE;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase HWTSTAMP_FILTER_PTP_V2_L2_EVENT:\n \tcase HWTSTAMP_FILTER_PTP_V2_L2_SYNC:\n \tcase HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ:\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex f9555c847f73..7e22a4ef582b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -1690,7 +1690,7 @@ static inline void i40e_rx_checksum(struct i40e_vsi *vsi,\n \tcase I40E_RX_PTYPE_INNER_PROT_UDP:\n \tcase I40E_RX_PTYPE_INNER_PROT_SCTP:\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n-\t\t/* fall though */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -2210,10 +2210,10 @@ static struct sk_buff *i40e_run_xdp(struct i40e_ring *rx_ring,\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n-\t\t/* fall through -- handle aborts by dropping packet */\n+\t\tfallthrough; /* handle aborts by dropping packet */\n \tcase XDP_DROP:\n \t\tresult = I40E_XDP_CONSUMED;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\nindex 7276580cbe64..8e489ed54138 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n@@ -168,10 +168,10 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n-\t\t/* fallthrough -- handle aborts by dropping packet */\n+\t\tfallthrough; /* handle aborts by dropping packet */\n \tcase XDP_DROP:\n \t\tresult = I40E_XDP_CONSUMED;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c\nindex 7a30d5d5ef53..17a405da9d16 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c\n@@ -1007,7 +1007,7 @@ static inline void iavf_rx_checksum(struct iavf_vsi *vsi,\n \tcase IAVF_RX_PTYPE_INNER_PROT_UDP:\n \tcase IAVF_RX_PTYPE_INNER_PROT_SCTP:\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n-\t\t/* fall though */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c\nindex 438b42ce2cd9..a32391e82762 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c\n@@ -638,7 +638,7 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw)\n \t\t\tdev_spec->sgmii_active = true;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through - for I2C based SGMII */\n+\t\tfallthrough; /* for I2C based SGMII */\n \tcase E1000_CTRL_EXT_LINK_MODE_PCIE_SERDES:\n \t\t/* read media type from SFP EEPROM */\n \t\tret_val = igb_set_sfp_media_type_82575(hw);\n@@ -1704,7 +1704,7 @@ static s32 igb_setup_serdes_link_82575(struct e1000_hw *hw)\n \tcase E1000_CTRL_EXT_LINK_MODE_1000BASE_KX:\n \t\t/* disable PCS autoneg and support parallel detect only */\n \t\tpcs_autoneg = false;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tif (hw->mac.type == e1000_82575 ||\n \t\t hw->mac.type == e1000_82576) {\ndiff --git a/drivers/net/ethernet/intel/igb/e1000_nvm.c b/drivers/net/ethernet/intel/igb/e1000_nvm.c\nindex 09f4dcb09632..fa136e6e9328 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_nvm.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_nvm.c\n@@ -721,7 +721,7 @@ void igb_get_fw_version(struct e1000_hw *hw, struct e1000_fw_version *fw_vers)\n \t\t\tigb_read_invm_version(hw, fw_vers);\n \t\t\treturn;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_i350:\n \t\t/* find combo image version */\n \t\thw->nvm.ops.read(hw, NVM_COMB_VER_PTR, 1, &comb_offset);\ndiff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c\nindex ad2125e5a7f7..8c8eb82e6272 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_phy.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c\n@@ -659,7 +659,7 @@ s32 igb_copper_link_setup_m88_gen2(struct e1000_hw *hw)\n \t\t\tphy_data |= M88E1000_PSCR_AUTO_X_1000T;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase 0:\n \tdefault:\n \t\tphy_data |= M88E1000_PSCR_AUTO_X_MODE;\n@@ -2621,7 +2621,7 @@ static s32 igb_set_master_slave_mode(struct e1000_hw *hw)\n \t\tbreak;\n \tcase e1000_ms_auto:\n \t\tphy_data &= ~CR_1000T_MS_ENABLE;\n-\t\t/* fall-through */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\ndiff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex da60e8d2128f..c2cf414d126b 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -2517,11 +2517,11 @@ static int igb_get_rss_hash_opts(struct igb_adapter *adapter,\n \tswitch (cmd->flow_type) {\n \tcase TCP_V4_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase UDP_V4_FLOW:\n \t\tif (adapter->flags & IGB_FLAG_RSS_FIELD_IPV4_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase SCTP_V4_FLOW:\n \tcase AH_ESP_V4_FLOW:\n \tcase AH_V4_FLOW:\n@@ -2531,11 +2531,11 @@ static int igb_get_rss_hash_opts(struct igb_adapter *adapter,\n \t\tbreak;\n \tcase TCP_V6_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase UDP_V6_FLOW:\n \t\tif (adapter->flags & IGB_FLAG_RSS_FIELD_IPV6_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase SCTP_V6_FLOW:\n \tcase AH_ESP_V6_FLOW:\n \tcase AH_V6_FLOW:\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 32fe393eaa22..889abbc3b3e5 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -711,14 +711,14 @@ static void igb_cache_ring_register(struct igb_adapter *adapter)\n \t\t\t\tadapter->rx_ring[i]->reg_idx = rbase_offset +\n \t\t\t\t\t\t\t Q_IDX_82576(i);\n \t\t}\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase e1000_82575:\n \tcase e1000_82580:\n \tcase e1000_i350:\n \tcase e1000_i354:\n \tcase e1000_i210:\n \tcase e1000_i211:\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tfor (; i < adapter->num_rx_queues; i++)\n \t\t\tadapter->rx_ring[i]->reg_idx = rbase_offset + i;\n@@ -2873,7 +2873,7 @@ void igb_set_fw_version(struct igb_adapter *adapter)\n \t\t\t\t fw.invm_img_type);\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\t/* if option is rom valid, display its version too */\n \t\tif (fw.or_valid) {\n@@ -3724,13 +3724,13 @@ unsigned int igb_get_max_rss_queues(struct igb_adapter *adapter)\n \t\t\tmax_rss_queues = 1;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_82576:\n \t\tif (!!adapter->vfs_allocated_count) {\n \t\t\tmax_rss_queues = 2;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_82580:\n \tcase e1000_i354:\n \tdefault:\n@@ -4869,14 +4869,14 @@ static int igb_vlan_promisc_enable(struct igb_adapter *adapter)\n \t\t/* VLAN filtering needed for VLAN prio filter */\n \t\tif (adapter->netdev->features & NETIF_F_NTUPLE)\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_82576:\n \tcase e1000_82580:\n \tcase e1000_i354:\n \t\t/* VLAN filtering needed for pool filtering */\n \t\tif (adapter->vfs_allocated_count)\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn 1;\n \t}\n@@ -5156,7 +5156,7 @@ bool igb_has_link(struct igb_adapter *adapter)\n \tcase e1000_media_type_copper:\n \t\tif (!hw->mac.get_link_status)\n \t\t\treturn true;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase e1000_media_type_internal_serdes:\n \t\thw->mac.ops.check_for_link(hw);\n \t\tlink_active = !hw->mac.get_link_status;\n@@ -5816,7 +5816,7 @@ static void igb_tx_csum(struct igb_ring *tx_ring, struct igb_tx_buffer *first)\n \tswitch (skb->csum_offset) {\n \tcase offsetof(struct tcphdr, check):\n \t\ttype_tucmd = E1000_ADVTXD_TUCMD_L4T_TCP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase offsetof(struct udphdr, check):\n \t\tbreak;\n \tcase offsetof(struct sctphdr, checksum):\n@@ -5828,7 +5828,7 @@ static void igb_tx_csum(struct igb_ring *tx_ring, struct igb_tx_buffer *first)\n \t\t\ttype_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tskb_checksum_help(skb);\n \t\tgoto csum_failed;\n@@ -6706,7 +6706,7 @@ static int __igb_notify_dca(struct device *dev, void *data)\n \t\t\tigb_setup_dca(adapter);\n \t\t\tbreak;\n \t\t}\n-\t\t/* Fall Through - since DCA is disabled. */\n+\t\tfallthrough; /* since DCA is disabled. */\n \tcase DCA_PROVIDER_REMOVE:\n \t\tif (adapter->flags & IGB_FLAG_DCA_ENABLED) {\n \t\t\t/* without this a class_device is left\n@@ -9375,13 +9375,13 @@ static void igb_vmm_control(struct igb_adapter *adapter)\n \t\treg = rd32(E1000_DTXCTL);\n \t\treg |= E1000_DTXCTL_VLAN_ADDED;\n \t\twr32(E1000_DTXCTL, reg);\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase e1000_82580:\n \t\t/* enable replication vlan tag stripping */\n \t\treg = rd32(E1000_RPLOLR);\n \t\treg |= E1000_RPLOLR_STRVLAN;\n \t\twr32(E1000_RPLOLR, reg);\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase e1000_i350:\n \t\t/* none of the above registers are supported by i350 */\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c\nindex c39e921757ba..490368d3d03c 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ptp.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ptp.c\n@@ -1053,7 +1053,7 @@ static int igb_ptp_set_timestamp_mode(struct igb_adapter *adapter,\n \t\t\tconfig->rx_filter = HWTSTAMP_FILTER_ALL;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_NONE;\n \t\treturn -ERANGE;\ndiff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c\nindex 07740654df5c..97a065928976 100644\n--- a/drivers/net/ethernet/intel/igbvf/netdev.c\n+++ b/drivers/net/ethernet/intel/igbvf/netdev.c\n@@ -2091,7 +2091,7 @@ static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb,\n \tswitch (skb->csum_offset) {\n \tcase offsetof(struct tcphdr, check):\n \t\ttype_tucmd = E1000_ADVTXD_TUCMD_L4T_TCP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase offsetof(struct udphdr, check):\n \t\tbreak;\n \tcase offsetof(struct sctphdr, checksum):\n@@ -2103,7 +2103,7 @@ static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb,\n \t\t\ttype_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tskb_checksum_help(skb);\n \t\tgoto csum_failed;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 149f130b825e..6b264aebbdfe 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -1015,37 +1015,29 @@ static int igc_ethtool_get_rss_hash_opts(struct igc_adapter *adapter,\n \tswitch (cmd->flow_type) {\n \tcase TCP_V4_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase UDP_V4_FLOW:\n \t\tif (adapter->flags & IGC_FLAG_RSS_FIELD_IPV4_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase SCTP_V4_FLOW:\n-\t\t/* Fall through */\n \tcase AH_ESP_V4_FLOW:\n-\t\t/* Fall through */\n \tcase AH_V4_FLOW:\n-\t\t/* Fall through */\n \tcase ESP_V4_FLOW:\n-\t\t/* Fall through */\n \tcase IPV4_FLOW:\n \t\tcmd->data |= RXH_IP_SRC | RXH_IP_DST;\n \t\tbreak;\n \tcase TCP_V6_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase UDP_V6_FLOW:\n \t\tif (adapter->flags & IGC_FLAG_RSS_FIELD_IPV6_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase SCTP_V6_FLOW:\n-\t\t/* Fall through */\n \tcase AH_ESP_V6_FLOW:\n-\t\t/* Fall through */\n \tcase AH_V6_FLOW:\n-\t\t/* Fall through */\n \tcase ESP_V6_FLOW:\n-\t\t/* Fall through */\n \tcase IPV6_FLOW:\n \t\tcmd->data |= RXH_IP_SRC | RXH_IP_DST;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex c767f5326ac9..7a44f62e6900 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -980,7 +980,7 @@ static void igc_tx_csum(struct igc_ring *tx_ring, struct igc_tx_buffer *first)\n \tswitch (skb->csum_offset) {\n \tcase offsetof(struct tcphdr, check):\n \t\ttype_tucmd = IGC_ADVTXD_TUCMD_L4T_TCP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase offsetof(struct udphdr, check):\n \t\tbreak;\n \tcase offsetof(struct sctphdr, checksum):\n@@ -992,7 +992,7 @@ static void igc_tx_csum(struct igc_ring *tx_ring, struct igc_tx_buffer *first)\n \t\t\ttype_tucmd = IGC_ADVTXD_TUCMD_L4T_SCTP;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tskb_checksum_help(skb);\n \t\tgoto csum_failed;\n@@ -3285,7 +3285,6 @@ static void igc_cache_ring_register(struct igc_adapter *adapter)\n \n \tswitch (adapter->hw.mac.type) {\n \tcase igc_i225:\n-\t/* Fall through */\n \tdefault:\n \t\tfor (; i < adapter->num_rx_queues; i++)\n \t\t\tadapter->rx_ring[i]->reg_idx = i;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c\nindex 0d746f8588c8..c2c9361dd62e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ptp.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c\n@@ -353,7 +353,7 @@ static int igc_ptp_set_timestamp_mode(struct igc_adapter *adapter,\n \t\ttsync_rx_ctl |= IGC_TSYNCRXCTL_TYPE_ALL;\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_ALL;\n \t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_NONE;\n \t\treturn -ERANGE;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\nindex eee277c1bedf..95c92fe890a1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c\n@@ -1098,7 +1098,7 @@ static void ixgbe_set_rxpba_82598(struct ixgbe_hw *hw, int num_pb,\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);\n \t\t/* Setup the last four at 48KB...don't re-init i */\n \t\trxpktsize = IXGBE_RXPBSIZE_48KB;\n-\t\t/* Fall Through */\n+\t\tfallthrough;\n \tcase PBA_STRATEGY_EQUAL:\n \tdefault:\n \t\t/* Divide the remaining Rx packet buffer evenly among the TCs */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\nindex 109f8de5a1c2..8d3798a32f0e 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n@@ -1568,7 +1568,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \tcase 0x0000:\n \t\t/* mask VLAN ID */\n \t\tfdirm |= IXGBE_FDIRM_VLANID;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase 0x0FFF:\n \t\t/* mask VLAN priority */\n \t\tfdirm |= IXGBE_FDIRM_VLANP;\n@@ -1576,7 +1576,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \tcase 0xE000:\n \t\t/* mask VLAN ID only */\n \t\tfdirm |= IXGBE_FDIRM_VLANID;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase 0xEFFF:\n \t\t/* no VLAN fields masked */\n \t\tbreak;\n@@ -1589,7 +1589,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,\n \tcase 0x0000:\n \t\t/* Mask Flex Bytes */\n \t\tfdirm |= IXGBE_FDIRM_FLEX;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase 0xFFFF:\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 17357a12cbdc..62ddb452f862 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -145,7 +145,7 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw)\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n \n-\t\t/* fall through - only backplane uses autoc */\n+\t\tfallthrough; /* only backplane uses autoc */\n \tcase ixgbe_media_type_fiber:\n \t\treg = IXGBE_READ_REG(hw, IXGBE_PCS1GANA);\n \n@@ -3533,7 +3533,7 @@ void ixgbe_set_rxpba_generic(struct ixgbe_hw *hw,\n \t\trxpktsize <<= IXGBE_RXPBSIZE_SHIFT;\n \t\tfor (; i < (num_pb / 2); i++)\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);\n-\t\t/* fall through - configure remaining packet buffers */\n+\t\tfallthrough; /* configure remaining packet buffers */\n \tcase (PBA_STRATEGY_EQUAL):\n \t\t/* Divide the remaining Rx packet buffer evenly among the TCs */\n \t\trxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 5da367cb5c93..8ae2c8c2f6a1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -2507,11 +2507,11 @@ static int ixgbe_get_rss_hash_opts(struct ixgbe_adapter *adapter,\n \tswitch (cmd->flow_type) {\n \tcase TCP_V4_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase UDP_V4_FLOW:\n \t\tif (adapter->flags2 & IXGBE_FLAG2_RSS_FIELD_IPV4_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase SCTP_V4_FLOW:\n \tcase AH_ESP_V4_FLOW:\n \tcase AH_V4_FLOW:\n@@ -2521,11 +2521,11 @@ static int ixgbe_get_rss_hash_opts(struct ixgbe_adapter *adapter,\n \t\tbreak;\n \tcase TCP_V6_FLOW:\n \t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase UDP_V6_FLOW:\n \t\tif (adapter->flags2 & IXGBE_FLAG2_RSS_FIELD_IPV6_UDP)\n \t\t\tcmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase SCTP_V6_FLOW:\n \tcase AH_ESP_V6_FLOW:\n \tcase AH_V6_FLOW:\n@@ -2657,7 +2657,7 @@ static int ixgbe_flowspec_to_flow_type(struct ethtool_rx_flow_spec *fsp,\n \t\t\t\t*flow_type = IXGBE_ATR_FLOW_TYPE_IPV4;\n \t\t\t\tbreak;\n \t\t\t}\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tdefault:\n \t\t\treturn 0;\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\nindex 6c5703cdf062..e67b1a59ecb7 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c\n@@ -444,7 +444,7 @@ int ixgbe_fcoe_ddp(struct ixgbe_adapter *adapter,\n \t\tddp->err = (__force u32)ddp_err;\n \t\tddp->sgl = NULL;\n \t\tddp->sgc = 0;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \t/* if DDP length is present pass it through to ULD */\n \tcase cpu_to_le32(IXGBE_RXDADV_STAT_FCSTAT_NODDP):\n \t\t/* update length of DDPed data */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 03e85def7763..b0283f4d9d3d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -1395,7 +1395,7 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)\n \t\t\t\t\tIXGBE_DCA_CTRL_DCA_MODE_CB2);\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through - DCA is disabled. */\n+\t\tfallthrough; /* DCA is disabled. */\n \tcase DCA_PROVIDER_REMOVE:\n \t\tif (adapter->flags & IXGBE_FLAG_DCA_ENABLED) {\n \t\t\tdca_remove_requester(dev);\n@@ -2229,10 +2229,10 @@ static struct sk_buff *ixgbe_run_xdp(struct ixgbe_adapter *adapter,\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n-\t\t/* fallthrough -- handle aborts by dropping packet */\n+\t\tfallthrough; /* handle aborts by dropping packet */\n \tcase XDP_DROP:\n \t\tresult = IXGBE_XDP_CONSUMED;\n \t\tbreak;\n@@ -3012,7 +3012,7 @@ static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter, bool queues,\n \tcase ixgbe_mac_82599EB:\n \t\tmask |= IXGBE_EIMS_GPI_SDP1(hw);\n \t\tmask |= IXGBE_EIMS_GPI_SDP2(hw);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_X540:\n \tcase ixgbe_mac_X550:\n \tcase ixgbe_mac_X550EM_x:\n@@ -3318,7 +3318,7 @@ static irqreturn_t ixgbe_intr(int irq, void *data)\n \tswitch (hw->mac.type) {\n \tcase ixgbe_mac_82599EB:\n \t\tixgbe_check_sfp_event(adapter, eicr);\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_X540:\n \tcase ixgbe_mac_X550:\n \tcase ixgbe_mac_X550EM_x:\n@@ -4340,7 +4340,7 @@ static void ixgbe_setup_rdrxctl(struct ixgbe_adapter *adapter)\n \tcase ixgbe_mac_x550em_a:\n \t\tif (adapter->num_vfs)\n \t\t\trdrxctl |= IXGBE_RDRXCTL_PSP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_82599EB:\n \tcase ixgbe_mac_X540:\n \t\t/* Disable RSC for ACK packets */\n@@ -5890,7 +5890,7 @@ void ixgbe_disable_tx(struct ixgbe_adapter *adapter)\n \t\tIXGBE_WRITE_REG(hw, IXGBE_DMATXCTL,\n \t\t\t\t(IXGBE_READ_REG(hw, IXGBE_DMATXCTL) &\n \t\t\t\t ~IXGBE_DMATXCTL_TE));\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -6342,7 +6342,7 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter,\n \t\tdefault:\n \t\t\tbreak;\n \t\t}\n-\t/* fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_X550EM_x:\n #ifdef CONFIG_IXGBE_DCB\n \t\tadapter->flags &= ~IXGBE_FLAG_DCB_CAPABLE;\n@@ -6353,7 +6353,7 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter,\n \t\tadapter->fcoe.up = 0;\n #endif /* IXGBE_DCB */\n #endif /* IXGBE_FCOE */\n-\t/* Fall Through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_X550:\n \t\tif (hw->mac.type == ixgbe_mac_X550)\n \t\t\tadapter->flags2 |= IXGBE_FLAG2_TEMP_SENSOR_CAPABLE;\n@@ -7165,7 +7165,7 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)\n \t\thwstats->o2bspc += IXGBE_READ_REG(hw, IXGBE_O2BSPC);\n \t\thwstats->b2ospc += IXGBE_READ_REG(hw, IXGBE_B2OSPC);\n \t\thwstats->b2ogprc += IXGBE_READ_REG(hw, IXGBE_B2OGPRC);\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mac_82599EB:\n \t\tfor (i = 0; i < 16; i++)\n \t\t\tadapter->hw_rx_no_dma_resources +=\n@@ -8074,7 +8074,7 @@ static void ixgbe_tx_csum(struct ixgbe_ring *tx_ring,\n \tswitch (skb->csum_offset) {\n \tcase offsetof(struct tcphdr, check):\n \t\ttype_tucmd = IXGBE_ADVTXD_TUCMD_L4T_TCP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase offsetof(struct udphdr, check):\n \t\tbreak;\n \tcase offsetof(struct sctphdr, checksum):\n@@ -8086,7 +8086,7 @@ static void ixgbe_tx_csum(struct ixgbe_ring *tx_ring,\n \t\t\ttype_tucmd = IXGBE_ADVTXD_TUCMD_L4T_SCTP;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tskb_checksum_help(skb);\n \t\tgoto csum_failed;\n@@ -8529,7 +8529,7 @@ static u16 ixgbe_select_queue(struct net_device *dev, struct sk_buff *skb,\n \n \t\tif (!sb_dev && (adapter->flags & IXGBE_FLAG_FCOE_ENABLED))\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn netdev_pick_tx(dev, skb, sb_dev);\n \t}\n@@ -8863,7 +8863,7 @@ static int ixgbe_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)\n \tcase SIOCGMIIPHY:\n \t\tif (!adapter->hw.phy.ops.read_reg)\n \t\t\treturn -EOPNOTSUPP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn mdio_mii_ioctl(&adapter->hw.phy.mdio, if_mii(req), cmd);\n \t}\n@@ -10653,7 +10653,7 @@ bool ixgbe_wol_supported(struct ixgbe_adapter *adapter, u16 device_id,\n \t\t\t/* only support first port */\n \t\t\tif (hw->bus.func != 0)\n \t\t\t\tbreak;\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tcase IXGBE_SUBDEV_ID_82599_SP_560FLR:\n \t\tcase IXGBE_SUBDEV_ID_82599_SFP:\n \t\tcase IXGBE_SUBDEV_ID_82599_RNDC:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\nindex 0be13a90ff79..22a874eee2e8 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c\n@@ -1051,7 +1051,7 @@ static int ixgbe_ptp_set_timestamp_mode(struct ixgbe_adapter *adapter,\n \t\t\tadapter->flags |= IXGBE_FLAG_RX_HWTSTAMP_ENABLED;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\t/*\n \t\t * register RXMTRL must be set in order to do V1 packets,\n@@ -1242,7 +1242,7 @@ void ixgbe_ptp_start_cyclecounter(struct ixgbe_adapter *adapter)\n \t\t\tcc.mult = 3;\n \t\t\tcc.shift = 2;\n \t\t}\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase ixgbe_mac_x550em_a:\n \tcase ixgbe_mac_X550:\n \t\tcc.read = ixgbe_ptp_read_X550;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex d05a5690e66b..23a92656821d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -503,7 +503,7 @@ static s32 ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)\n \t\t\t */\n \t\t\tif (pf_max_frame > ETH_FRAME_LEN)\n \t\t\t\tbreak;\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tdefault:\n \t\t\t/* If the PF or VF are running w/ jumbo frames enabled\n \t\t\t * we need to shut down the VF Rx path as we cannot\n@@ -1141,7 +1141,7 @@ static int ixgbe_update_vf_xcast_mode(struct ixgbe_adapter *adapter,\n \t\t/* promisc introduced in 1.3 version */\n \t\tif (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)\n \t\t\treturn -EOPNOTSUPP;\n-\t\t/* Fall through */\n+\t\tfallthrough;\n \tcase ixgbe_mbox_api_13:\n \tcase ixgbe_mbox_api_14:\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 9c42f741ed5e..5e339afa682a 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -306,7 +306,7 @@ static s32 ixgbe_identify_phy_x550em(struct ixgbe_hw *hw)\n \t\thw->phy.phy_semaphore_mask = IXGBE_GSSR_SHARED_I2C_SM;\n \t\tixgbe_setup_mux_ctl(hw);\n \t\tixgbe_check_cs4227(hw);\n-\t\t/* Fallthrough */\n+\t\tfallthrough;\n \tcase IXGBE_DEV_ID_X550EM_A_SFP_N:\n \t\treturn ixgbe_identify_module_generic(hw);\n \tcase IXGBE_DEV_ID_X550EM_X_KX4:\n@@ -325,7 +325,7 @@ static s32 ixgbe_identify_phy_x550em(struct ixgbe_hw *hw)\n \t\t\thw->phy.phy_semaphore_mask = IXGBE_GSSR_PHY1_SM;\n \t\telse\n \t\t\thw->phy.phy_semaphore_mask = IXGBE_GSSR_PHY0_SM;\n-\t\t/* Fallthrough */\n+\t\tfallthrough;\n \tcase IXGBE_DEV_ID_X550EM_X_10G_T:\n \t\treturn ixgbe_identify_phy_generic(hw);\n \tcase IXGBE_DEV_ID_X550EM_X_1G_T:\n@@ -2303,7 +2303,7 @@ static s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n-\t\t\t/* fall through */\n+\t\t\tfallthrough;\n \t\tdefault:\n \t\t\t*speed = IXGBE_LINK_SPEED_10GB_FULL |\n \t\t\t\t IXGBE_LINK_SPEED_1GB_FULL;\n@@ -2885,7 +2885,7 @@ static s32 ixgbe_setup_fc_x550em(struct ixgbe_hw *hw)\n \t\t * through to the fc_full statement. Later, we will\n \t\t * disable the adapter's ability to send PAUSE frames.\n \t\t */\n-\t\t/* Fallthrough */\n+\t\tfallthrough;\n \tcase ixgbe_fc_full:\n \t\tpause = true;\n \t\tasm_dir = true;\n@@ -3284,7 +3284,7 @@ static enum ixgbe_media_type ixgbe_get_media_type_X550em(struct ixgbe_hw *hw)\n \tcase IXGBE_DEV_ID_X550EM_A_SGMII:\n \tcase IXGBE_DEV_ID_X550EM_A_SGMII_L:\n \t\thw->phy.type = ixgbe_phy_sgmii;\n-\t\t/* Fallthrough */\n+\t\tfallthrough;\n \tcase IXGBE_DEV_ID_X550EM_X_KR:\n \tcase IXGBE_DEV_ID_X550EM_X_KX4:\n \tcase IXGBE_DEV_ID_X550EM_X_XFI:\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\nindex be9d2a8da515..ec7121f352e2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c\n@@ -120,10 +120,10 @@ static int ixgbe_run_xdp_zc(struct ixgbe_adapter *adapter,\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n-\t\t/* fallthrough -- handle aborts by dropping packet */\n+\t\tfallthrough; /* handle aborts by dropping packet */\n \tcase XDP_DROP:\n \t\tresult = IXGBE_XDP_CONSUMED;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 635cbc25e2f2..6e9a397db583 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -1079,10 +1079,10 @@ static struct sk_buff *ixgbevf_run_xdp(struct ixgbevf_adapter *adapter,\n \t\tbreak;\n \tdefault:\n \t\tbpf_warn_invalid_xdp_action(act);\n-\t\t/* fallthrough */\n+\t\tfallthrough;\n \tcase XDP_ABORTED:\n \t\ttrace_xdp_exception(rx_ring->netdev, xdp_prog, act);\n-\t\t/* fallthrough -- handle aborts by dropping packet */\n+\t\tfallthrough; /* handle aborts by dropping packet */\n \tcase XDP_DROP:\n \t\tresult = IXGBEVF_XDP_CONSUMED;\n \t\tbreak;\n@@ -2602,7 +2602,7 @@ static int ixgbevf_acquire_msix_vectors(struct ixgbevf_adapter *adapter,\n * important, starting with the \"most\" number of features turned on at once,\n * and ending with the smallest set of features. This way large combinations\n * can be allocated if they're turned on, and smaller combinations are the\n- * fallthrough conditions.\n+ * fall through conditions.\n *\n **/\n static void ixgbevf_set_num_queues(struct ixgbevf_adapter *adapter)\n@@ -3874,7 +3874,7 @@ static void ixgbevf_tx_csum(struct ixgbevf_ring *tx_ring,\n \tswitch (skb->csum_offset) {\n \tcase offsetof(struct tcphdr, check):\n \t\ttype_tucmd = IXGBE_ADVTXD_TUCMD_L4T_TCP;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tcase offsetof(struct udphdr, check):\n \t\tbreak;\n \tcase offsetof(struct sctphdr, checksum):\n@@ -3886,7 +3886,7 @@ static void ixgbevf_tx_csum(struct ixgbevf_ring *tx_ring,\n \t\t\ttype_tucmd = IXGBE_ADVTXD_TUCMD_L4T_SCTP;\n \t\t\tbreak;\n \t\t}\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\tskb_checksum_help(skb);\n \t\tgoto no_csum;\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex d5ce49636548..bfe6dfcec4ab 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -314,7 +314,7 @@ int ixgbevf_get_reta_locked(struct ixgbe_hw *hw, u32 *reta, int num_rx_queues)\n \tcase ixgbe_mbox_api_12:\n \t\tif (hw->mac.type < ixgbe_mac_X550_vf)\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n \t}\n@@ -382,7 +382,7 @@ int ixgbevf_get_rss_key_locked(struct ixgbe_hw *hw, u8 *rss_key)\n \tcase ixgbe_mbox_api_12:\n \t\tif (hw->mac.type < ixgbe_mac_X550_vf)\n \t\t\tbreak;\n-\t\t/* fall through */\n+\t\tfallthrough;\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n \t}\n@@ -540,7 +540,7 @@ static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n \t\t/* promisc introduced in 1.3 version */\n \t\tif (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)\n \t\t\treturn -EOPNOTSUPP;\n-\t\t/* Fall threw */\n+\t\tfallthrough;\n \tcase ixgbe_mbox_api_14:\n \tcase ixgbe_mbox_api_13:\n \t\tbreak;\n", "prefixes": [ "next-queue" ] }