Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1298931/?format=api
{ "id": 1298931, "url": "http://patchwork.ozlabs.org/api/patches/1298931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200527134716.948148-1-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200527134716.948148-1-arnd@arndb.de>", "list_archive_url": null, "date": "2020-05-27T13:47:00", "name": "[net-next] e1000e: fix unused-function warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a66e942357fae5ec2774607485e461713d49e6e8", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200527134716.948148-1-arnd@arndb.de/mbox/", "series": [ { "id": 179627, "url": "http://patchwork.ozlabs.org/api/series/179627/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=179627", "date": "2020-05-27T13:47:00", "name": "[net-next] e1000e: fix unused-function warning", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/179627/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1298931/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1298931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=arndb.de" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49XBwc0Qfwz9sPF\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 27 May 2020 23:47:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7C24E88523;\n\tWed, 27 May 2020 13:47:41 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SCPI8rFdzXou; Wed, 27 May 2020 13:47:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D912888525;\n\tWed, 27 May 2020 13:47:40 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id 059041BF34E\n for <intel-wired-lan@lists.osuosl.org>; Wed, 27 May 2020 13:47:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id EFAFE88525\n for <intel-wired-lan@lists.osuosl.org>; Wed, 27 May 2020 13:47:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Hzr1ijgw4z7z for <intel-wired-lan@lists.osuosl.org>;\n Wed, 27 May 2020 13:47:38 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135])\n by hemlock.osuosl.org (Postfix) with ESMTPS id 4DC8A88523\n for <intel-wired-lan@lists.osuosl.org>; Wed, 27 May 2020 13:47:38 +0000 (UTC)", "from threadripper.lan ([149.172.98.151]) by mrelayeu.kundenserver.de\n (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id\n 1N0nzR-1iqnfB1yGD-00wljD; Wed, 27 May 2020 15:47:20 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n Vitaly Lifshits <vitaly.lifshits@intel.com>", "Date": "Wed, 27 May 2020 15:47:00 +0200", "Message-Id": "<20200527134716.948148-1-arnd@arndb.de>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "X-Provags-ID": "V03:K1:U0mKtKTjWJcCkHiwKPi9Mh65377Hpmc77oEjPdqAFTu1tfJI3j5\n tQ6qhoFQt3VrltJF1OQAZvSCEi5jiXDLXneeEtt2tYoGulYW/CDGQtb89g2bHJUJ/w1LAik\n vIs2GxtV6aTDuWMBLBgIGK5xEW1J7i/jAm9wYXcKSEyCbp7nrbd8Rty5jSQY+5hArziNzw3\n jy7nL7AY5luwKFm7YGBUA==", "X-UI-Out-Filterresults": "notjunk:1;V03:K0:fVIXS7/sr1M=:7+CEaDh/RQcJZ9+oHHDRCA\n jGgnId2Eh18Nx4Vc2d9p2ntA3gVJoJC13L9xRw+3ALBvTKDImWYcrAvVM2skxYOUcmBIsk/15\n ykarw3foUHHsbo5uxQhoF2/FDKLf04cgrW7yVLTuKX6a1F7Qy6xEH9GL9W7wu3MPCxjo7wfqu\n 4i+RxGc+in1TayP2yisk1FswPj83O49YHoWV/XjbaqaxI76R47bKs6RYUQC0spixKJV3eDRkF\n UjKJRlHKhjY48Z6xvWggE2ckNMeE33kQBjsX/DbCW0tvFzeKfq6DrwxhEQzdLFdOnxry8MFlk\n D3hmE5yukdvkligEfgciGCgyYHINbBIL1WkAjok7DZFj5SiQFRcPIkJFKDeL0tsihQxvNiHJ8\n s1hEhMHSdhA5MQanrvjhcKGL5fb5nyqCUs6HICiQtlDTLBUImIApNtoPl7Ai6uP7ESBkoFvHb\n YScFHKzepRUhzSa7E7wIijOk2OCqFHKEQBWchcP5tpdsAaLb0X/Jx4bwglGBRKsi2jYHGDd00\n 0ypJAuKP+cjgSdbVBa78G7FFgYgj68X2GQojBh5yZZVjtA5d8dR6Ko8g0wbeSa7IWKT109FJ1\n mhG9xQsenBnIVzqqVV8MQutz50mCLvuH4HLCKQppguZg7un/uMCSdZB/m9gCUEwOXjqxxsPwa\n 9CiQAzzIZ/397cEH5q4bNOg+KIQ1ZR+kQACyN/ggykcUqN0bnGuIHxki8G6g15FAWLOlGRPbb\n j31v+NBus5GeRoBJ39ulocxn9VMzJBqaJND9StWQVB1fRSje3AcQ/+IejDuvREnOVJBbZAwEm\n ZUJIw+8x5FMAZQV+3MLJqTbcK0D1h04UY+JPHp3K4ZP9p0htwU=", "Subject": "[Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function\n warning", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Arnd Bergmann <arnd@arndb.de>,\n Konstantin Khlebnikov <khlebnikov@yandex-team.ru>, netdev@vger.kernel.org,\n \"Rafael J. Wysocki\" <rafael.j.wysocki@intel.com>,\n linux-kernel@vger.kernel.org,\n intel-wired-lan@lists.osuosl.org,\n Alexander Duyck <alexander.h.duyck@linux.intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The CONFIG_PM_SLEEP #ifdef checks in this file are inconsistent,\nleading to a warning about sometimes unused function:\n\ndrivers/net/ethernet/intel/e1000e/netdev.c:137:13: error: unused function 'e1000e_check_me' [-Werror,-Wunused-function]\n\nRather than adding more #ifdefs, just remove them completely\nand mark the PM functions as __maybe_unused to let the compiler\nwork it out on it own.\n\nFixes: e086ba2fccda (\"e1000e: disable s0ix entry and exit flows for ME systems\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 9cc8ec5421d5..66ca083b95f9 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -6351,7 +6351,6 @@ static void e1000e_flush_lpic(struct pci_dev *pdev)\n \tpm_runtime_put_sync(netdev->dev.parent);\n }\n \n-#ifdef CONFIG_PM_SLEEP\n /* S0ix implementation */\n static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)\n {\n@@ -6573,7 +6572,6 @@ static void e1000e_s0ix_exit_flow(struct e1000_adapter *adapter)\n \tmac_data &= ~E1000_CTRL_EXT_FORCE_SMBUS;\n \tew32(CTRL_EXT, mac_data);\n }\n-#endif /* CONFIG_PM_SLEEP */\n \n static int e1000e_pm_freeze(struct device *dev)\n {\n@@ -6871,7 +6869,6 @@ static int e1000e_pm_thaw(struct device *dev)\n \treturn rc;\n }\n \n-#ifdef CONFIG_PM\n static int __e1000_resume(struct pci_dev *pdev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -6937,8 +6934,7 @@ static int __e1000_resume(struct pci_dev *pdev)\n \treturn 0;\n }\n \n-#ifdef CONFIG_PM_SLEEP\n-static int e1000e_pm_suspend(struct device *dev)\n+static __maybe_unused int e1000e_pm_suspend(struct device *dev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(to_pci_dev(dev));\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n@@ -6962,7 +6958,7 @@ static int e1000e_pm_suspend(struct device *dev)\n \treturn rc;\n }\n \n-static int e1000e_pm_resume(struct device *dev)\n+static __maybe_unused int e1000e_pm_resume(struct device *dev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(to_pci_dev(dev));\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n@@ -6981,9 +6977,8 @@ static int e1000e_pm_resume(struct device *dev)\n \n \treturn e1000e_pm_thaw(dev);\n }\n-#endif /* CONFIG_PM_SLEEP */\n \n-static int e1000e_pm_runtime_idle(struct device *dev)\n+static __maybe_unused int e1000e_pm_runtime_idle(struct device *dev)\n {\n \tstruct net_device *netdev = dev_get_drvdata(dev);\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n@@ -6999,7 +6994,7 @@ static int e1000e_pm_runtime_idle(struct device *dev)\n \treturn -EBUSY;\n }\n \n-static int e1000e_pm_runtime_resume(struct device *dev)\n+static __maybe_unused int e1000e_pm_runtime_resume(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -7016,7 +7011,7 @@ static int e1000e_pm_runtime_resume(struct device *dev)\n \treturn rc;\n }\n \n-static int e1000e_pm_runtime_suspend(struct device *dev)\n+static __maybe_unused int e1000e_pm_runtime_suspend(struct device *dev)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n@@ -7041,7 +7036,6 @@ static int e1000e_pm_runtime_suspend(struct device *dev)\n \n \treturn 0;\n }\n-#endif /* CONFIG_PM */\n \n static void e1000_shutdown(struct pci_dev *pdev)\n {\n", "prefixes": [ "net-next" ] }