Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1297,
    "url": "http://patchwork.ozlabs.org/api/patches/1297/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1222272700-28232-2-git-send-email-remi.denis-courmont@nokia.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1222272700-28232-2-git-send-email-remi.denis-courmont@nokia.com>",
    "list_archive_url": null,
    "date": "2008-09-24T16:11:39",
    "name": "[2/3] Phonet: improve documentation",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b3c78a2ce16dc2c26815f5a0730b24f5170128fe",
    "submitter": {
        "id": 204,
        "url": "http://patchwork.ozlabs.org/api/people/204/?format=api",
        "name": "Rémi Denis-Courmont",
        "email": "remi.denis-courmont@nokia.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1222272700-28232-2-git-send-email-remi.denis-courmont@nokia.com/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1297/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1297/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id A7989DDFCD\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 25 Sep 2008 02:12:10 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752040AbYIXQME (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 24 Sep 2008 12:12:04 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1750988AbYIXQME\n\t(ORCPT <rfc822; netdev-outgoing>); Wed, 24 Sep 2008 12:12:04 -0400",
            "from smtp.nokia.com ([192.100.122.233]:17739 \"EHLO\n\tmgw-mx06.nokia.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751996AbYIXQL7 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 24 Sep 2008 12:11:59 -0400",
            "from esebh107.NOE.Nokia.com (esebh107.ntc.nokia.com\n\t[172.21.143.143])\n\tby mgw-mx06.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id\n\tm8OGBtEc025585\n\tfor <netdev@vger.kernel.org>; Wed, 24 Sep 2008 19:11:57 +0300",
            "from vaebh102.NOE.Nokia.com ([10.160.244.23]) by\n\tesebh107.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); \n\tWed, 24 Sep 2008 19:11:54 +0300",
            "from vaebh101.NOE.Nokia.com ([10.160.244.22]) by\n\tvaebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); \n\tWed, 24 Sep 2008 19:11:54 +0300",
            "from localhost.localdomain ([172.21.41.62]) by\n\tvaebh101.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); \n\tWed, 24 Sep 2008 19:11:52 +0300"
        ],
        "From": "Remi Denis-Courmont <remi.denis-courmont@nokia.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "=?utf-8?q?R=C3=A9mi=20Denis-Courmont?= <remi.denis-courmont@nokia.com>",
        "Subject": "[PATCH 2/3] Phonet: improve documentation",
        "Date": "Wed, 24 Sep 2008 19:11:39 +0300",
        "Message-Id": "<1222272700-28232-2-git-send-email-remi.denis-courmont@nokia.com>",
        "X-Mailer": "git-send-email 1.5.4.3",
        "In-Reply-To": "<>",
        "References": "<>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=utf-8",
        "Content-Transfer-Encoding": "8bit",
        "X-OriginalArrivalTime": "24 Sep 2008 16:11:54.0208 (UTC)\n\tFILETIME=[42BBFE00:01C91E60]",
        "X-Nokia-AV": "Clean",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>\n\nFix grammar errors spotted by Randy Dunlap,\nand adds some more details.\n\nSigned-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com>\n---\n Documentation/networking/phonet.txt |   32 +++++++++++++++++++++-----------\n 1 files changed, 21 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/Documentation/networking/phonet.txt b/Documentation/networking/phonet.txt\nindex f3c72e0..57d3e59 100644\n--- a/Documentation/networking/phonet.txt\n+++ b/Documentation/networking/phonet.txt\n@@ -21,7 +21,7 @@ depending on the device, such as:\n Packets format\n --------------\n \n-Phonet packet have a common header as follow:\n+Phonet packets have a common header as follows:\n \n   struct phonethdr {\n     uint8_t  pn_media;  /* Media type (link-layer identifier) */\n@@ -33,14 +33,17 @@ Phonet packet have a common header as follow:\n     uint8_t  pn_sobj;   /* Sender object ID */\n   };\n \n-The device ID is split: the 6 higher order bits consitutes the device\n-address, while the 2 lower order bits are used for multiplexing, as are\n-the 8-bits object identifiers. As such, Phonet can be considered as a\n+On Linux, the link-layer header includes the pn_media byte (see below).\n+The next 7 bytes are part of the network-layer header.\n+\n+The device ID is split: the 6 higher-order bits consitute the device\n+address, while the 2 lower-order bits are used for multiplexing, as are\n+the 8-bit object identifiers. As such, Phonet can be considered as a\n network layer with 6 bits of address space and 10 bits for transport\n protocol (much like port numbers in IP world).\n \n-The modem always has address number zero. Each other device has a its\n-own 6-bits address.\n+The modem always has address number zero. All other device have a their\n+own 6-bit address.\n \n \n Link layer\n@@ -49,11 +52,18 @@ Link layer\n Phonet links are always point-to-point links. The link layer header\n consists of a single Phonet media type byte. It uniquely identifies the\n link through which the packet is transmitted, from the modem's\n-perspective.\n-\n-Linux Phonet network interfaces use a dedicated link layer type\n-(ETH_P_PHONET) which is out of the Ethernet type range. They can only\n-send and receive Phonet packets.\n+perspective. Each Phonet network device shall prepend and set the media\n+type byte as appropriate. For convenience, a common phonet_header_ops\n+link-layer header operations structure is provided. It sets the\n+media type according to the network device hardware address.\n+\n+Linux Phonet network interfaces support a dedicated link layer packets\n+type (ETH_P_PHONET) which is out of the Ethernet type range. They can\n+only send and receive Phonet packets.\n+\n+The virtual TUN tunnel device driver can also be used for Phonet. This\n+requires IFF_TUN mode, _without_ the IFF_NO_PI flag. In this case,\n+there is no link-layer header, so there is no Phonet media type byte.\n \n Note that Phonet interfaces are not allowed to re-order packets, so\n only the (default) Linux FIFO qdisc should be used with them.\n",
    "prefixes": [
        "2/3"
    ]
}