Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1295738/?format=api
{ "id": 1295738, "url": "http://patchwork.ozlabs.org/api/patches/1295738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/725bad2f3ce7f7b7f1667d53b6527dc059f9e419.1590081982.git.yu.c.chen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<725bad2f3ce7f7b7f1667d53b6527dc059f9e419.1590081982.git.yu.c.chen@intel.com>", "list_archive_url": null, "date": "2020-05-21T17:59:13", "name": "[2/2] e1000e: Make WOL info in ethtool consistent with device wake up ability", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "8d0dd04fb82b4e7f747e522f0e07dc0cbf0b7490", "submitter": { "id": 69112, "url": "http://patchwork.ozlabs.org/api/people/69112/?format=api", "name": "Chen, Yu C", "email": "yu.c.chen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/725bad2f3ce7f7b7f1667d53b6527dc059f9e419.1590081982.git.yu.c.chen@intel.com/mbox/", "series": [ { "id": 178549, "url": "http://patchwork.ozlabs.org/api/series/178549/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=178549", "date": "2020-05-21T17:58:02", "name": "Make WOL of e1000e consistent with sysfs device wakeup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/178549/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1295738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1295738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49SksB74HVz9sSs\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 22 May 2020 08:32:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8CD4E87684;\n\tThu, 21 May 2020 22:32:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id P8AMgIONAhRw; Thu, 21 May 2020 22:32:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 328EE87683;\n\tThu, 21 May 2020 22:32:43 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 77FE91BF20D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 21 May 2020 17:59:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 6F9412040A\n for <intel-wired-lan@lists.osuosl.org>; Thu, 21 May 2020 17:59:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id a-eYRqhxjRtI for <intel-wired-lan@lists.osuosl.org>;\n Thu, 21 May 2020 17:59:14 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by silver.osuosl.org (Postfix) with ESMTPS id C145122865\n for <intel-wired-lan@lists.osuosl.org>; Thu, 21 May 2020 17:59:12 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 May 2020 10:59:12 -0700", "from chenyu-office.sh.intel.com ([10.239.158.173])\n by orsmga005.jf.intel.com with ESMTP; 21 May 2020 10:59:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 5DYBJ+YnfkwBxebU4iZxCkxY3uG7lHuXiXRTifWxyZcj/udArTpG5Vr4BJGCEZORH8aYLXRggx\n MM+hfKGcpOJQ==", "\n sZn8coVk+aGRy6cR7nKyBcK9tldIrd57JjTZ0zG9Tkm1tCPvh5em5kKCCCrKUbC8dxHt+bwZhG\n 4+djOVlI0+qw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,418,1583222400\"; d=\"scan'208\";a=\"440543290\"", "From": "Chen Yu <yu.c.chen@intel.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,\n Auke Kok <auke-jan.h.kok@intel.com>, Jeff Garzik <jeff@garzik.org>", "Date": "Fri, 22 May 2020 01:59:13 +0800", "Message-Id": "\n <725bad2f3ce7f7b7f1667d53b6527dc059f9e419.1590081982.git.yu.c.chen@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<cover.1590081982.git.yu.c.chen@intel.com>", "References": "<cover.1590081982.git.yu.c.chen@intel.com>", "X-Mailman-Approved-At": "Thu, 21 May 2020 22:32:40 +0000", "Subject": "[Intel-wired-lan] [PATCH 2/2] e1000e: Make WOL info in ethtool\n consistent with device wake up ability", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Len Brown <len.brown@intel.com>, \"Shevchenko,\n Andriy\" <andriy.shevchenko@intel.com>, netdev@vger.kernel.org,\n \"Rafael J. Wysocki\" <rjw@rjwysocki.net>, linux-kernel@vger.kernel.org,\n Stable@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n Chen Yu <yu.c.chen@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Currently the ethtool shows that WOL(Wake On Lan) is enabled\neven if the device wakeup ability has been disabled via sysfs:\n cat /sys/devices/pci0000:00/0000:00:1f.6/power/wakeup\n disabled\n\n ethtool eno1\n ...\n Wake-on: g\n\nFix this in ethtool to check if the user has explicitly disabled the\nwake up ability for this device.\n\nFixes: 6ff68026f475 (\"e1000e: Use device_set_wakeup_enable\")\nReported-by: Len Brown <len.brown@intel.com>\nReviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>\nCc: <Stable@vger.kernel.org>\nSigned-off-by: Chen Yu <yu.c.chen@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c\nindex 1d47e2503072..0cccd823ff24 100644\n--- a/drivers/net/ethernet/intel/e1000e/ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c\n@@ -1891,7 +1891,7 @@ static void e1000_get_wol(struct net_device *netdev,\n \twol->wolopts = 0;\n \n \tif (!(adapter->flags & FLAG_HAS_WOL) ||\n-\t !device_can_wakeup(&adapter->pdev->dev))\n+\t !device_may_wakeup(&adapter->pdev->dev))\n \t\treturn;\n \n \twol->supported = WAKE_UCAST | WAKE_MCAST |\n", "prefixes": [ "2/2" ] }