Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291793/?format=api
{ "id": 1291793, "url": "http://patchwork.ozlabs.org/api/patches/1291793/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516005506.5113-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:55:04", "name": "[S46,7/9] ice: Use coalesce values from q_vector 0 when increasing q_vectors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "832baa7319e043914d6bceec3b2a239e236b9217", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177331, "url": "http://patchwork.ozlabs.org/api/series/177331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177331", "date": "2020-05-16T00:55:01", "name": "[S46,1/9] ice: Reset VF for all port VLAN changes from host", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291793/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P6MP4HR5z9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:57:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CCAB8881F1;\n\tSat, 16 May 2020 00:57:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lQveq_OlRhmw; Sat, 16 May 2020 00:57:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 89D7688017;\n\tSat, 16 May 2020 00:57:50 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 05AC21BF9C6\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 00004204BE\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id lPu1uODKtcLl for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:57:42 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by silver.osuosl.org (Postfix) with ESMTPS id 619D4227FA\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:42 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:57:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga005.fm.intel.com with ESMTP; 15 May 2020 17:57:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n z3gkgbc73Q1saGPX8aX/iTLFWbUrGQWZ80XpwxdHv2Ep0/GKOEqNE0goDndg2oGS4npxL2iByl\n S6yD3+lVyy7Q==", "\n bkxABxNxzGckIwzG9gHhNvMHgcxUsPgrYWgLb9mnZX0OQM9zENA868IUkGwO4pImON+dyb5f9H\n 2np5kSh3Fp1w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"464922707\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:55:04 -0700", "Message-Id": "<20200516005506.5113-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "References": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S46 7/9] ice: Use coalesce values from\n q_vector 0 when increasing q_vectors", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently when a VSI is built (i.e. reset, set channels, etc.)\nthe coalesce settings will be preserved in most cases. However, when the\nnumber of q_vectors are increased the settings for the new q_vectors\nwill be set to the driver defaults of AIM on, Rx/Tx ITR 50, and INTRL 0.\nThis is causing issues with how the ethtool layer gets the current\ncoalesce settings since it only uses q_vector 0. So, assume that the user\nset the coalesce settings globally (i.e. ethtool -C eth0) and use q_vector\n0's settings for all of the new q_vectors.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 7cd4afcade13..392fb6e7de5d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -2753,15 +2753,13 @@ ice_vsi_rebuild_set_coalesce(struct ice_vsi *vsi,\n \t\tice_vsi_rebuild_update_coalesce(vsi->q_vectors[i],\n \t\t\t\t\t\t&coalesce[i]);\n \n-\tfor (; i < vsi->num_q_vectors; i++) {\n-\t\tstruct ice_coalesce_stored coalesce_dflt = {\n-\t\t\t.itr_tx = ICE_DFLT_TX_ITR,\n-\t\t\t.itr_rx = ICE_DFLT_RX_ITR,\n-\t\t\t.intrl = 0\n-\t\t};\n+\t/* number of q_vectors increased, so assume coalesce settings were\n+\t * changed globally (i.e. ethtool -C eth0 instead of per-queue) and use\n+\t * the previous settings from q_vector 0 for all of the new q_vectors\n+\t */\n+\tfor (; i < vsi->num_q_vectors; i++)\n \t\tice_vsi_rebuild_update_coalesce(vsi->q_vectors[i],\n-\t\t\t\t\t\t&coalesce_dflt);\n-\t}\n+\t\t\t\t\t\t&coalesce[0]);\n }\n \n /**\n", "prefixes": [ "S46", "7/9" ] }