Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291792/?format=api
{ "id": 1291792, "url": "http://patchwork.ozlabs.org/api/patches/1291792/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-9-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516005506.5113-9-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:55:06", "name": "[S46,9/9] ice: Ignore EMODE when setting PHY config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f1f9ba88496b71570a5aa957239bff6395906ded", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-9-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177331, "url": "http://patchwork.ozlabs.org/api/series/177331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177331", "date": "2020-05-16T00:55:01", "name": "[S46,1/9] ice: Reset VF for all port VLAN changes from host", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291792/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P6MN3QnQz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:57:52 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D637D8811E;\n\tSat, 16 May 2020 00:57:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JUitDFgBQKRT; Sat, 16 May 2020 00:57:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3BEFA87BB0;\n\tSat, 16 May 2020 00:57:50 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id 07C171BF9C8\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id 04C4D88717\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id WiwwC-W1wFRR for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:57:42 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by hemlock.osuosl.org (Postfix) with ESMTPS id E5E9089489\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:41 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:57:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga005.fm.intel.com with ESMTP; 15 May 2020 17:57:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n UETidqP6Td2N34LO4TNA+UXzZJkCsBRJO6QM8pnSJIUftYsJid7+B8tc3cciOaEkMNWyZ8kgyn\n hUoogBiTiBKA==", "\n G1QJAv7Mv54nfsWmRSIz3WPgklkc8yKVbeAtXmHedIQnzNgk5r9ZKmlAsbkUrO4XfANS1V2Gnr\n Xx85N8KNk1Qg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"464922712\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:55:06 -0700", "Message-Id": "<20200516005506.5113-9-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "References": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S46 9/9] ice: Ignore EMODE when setting\n PHY config", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Chinh T Cao <chinh.t.cao@intel.com>\n\nWhen setting the PHY cfg (CQ cmd 0x0601), if the firmware responds\nwith an EMODE error, software will ignore the error as it simply\nmeans that manageability (ex: BMC) is in control of the link and that\nthe new setting may not be applied.\n\nSigned-off-by: Chinh T Cao <chinh.t.cao@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 1 +\n drivers/net/ethernet/intel/ice/ice_common.c | 7 ++++++-\n drivers/net/ethernet/intel/ice/ice_main.c | 2 ++\n 3 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\nindex bba47f11e546..3c28379dfb3e 100644\n--- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n+++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n@@ -1858,6 +1858,7 @@ enum ice_aq_err {\n \tICE_AQ_RC_EINVAL\t= 14, /* Invalid argument */\n \tICE_AQ_RC_ENOSPC\t= 16, /* No space left or allocation failure */\n \tICE_AQ_RC_ENOSYS\t= 17, /* Function not implemented */\n+\tICE_AQ_RC_EMODE\t\t= 21, /* Op not allowed in current dev mode */\n \tICE_AQ_RC_ENOSEC\t= 24, /* Missing security manifest */\n \tICE_AQ_RC_EBADSIG\t= 25, /* Bad RSA signature */\n \tICE_AQ_RC_ESVN\t\t= 26, /* SVN number prohibits this package */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex ce578fe4ab3e..da724b0e524d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -2248,6 +2248,7 @@ ice_aq_set_phy_cfg(struct ice_hw *hw, u8 lport,\n \t\t struct ice_aqc_set_phy_cfg_data *cfg, struct ice_sq_cd *cd)\n {\n \tstruct ice_aq_desc desc;\n+\tenum ice_status status;\n \n \tif (!cfg)\n \t\treturn ICE_ERR_PARAM;\n@@ -2276,7 +2277,11 @@ ice_aq_set_phy_cfg(struct ice_hw *hw, u8 lport,\n \tice_debug(hw, ICE_DBG_LINK, \"eeer_value = 0x%x\\n\", cfg->eeer_value);\n \tice_debug(hw, ICE_DBG_LINK, \"link_fec_opt = 0x%x\\n\", cfg->link_fec_opt);\n \n-\treturn ice_aq_send_cmd(hw, &desc, cfg, sizeof(*cfg), cd);\n+\tstatus = ice_aq_send_cmd(hw, &desc, cfg, sizeof(*cfg), cd);\n+\tif (hw->adminq.sq_last_status == ICE_AQ_RC_EMODE)\n+\t\tstatus = 0;\n+\n+\treturn status;\n }\n \n /**\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 7f444a24be07..a2d3cba19565 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5245,6 +5245,8 @@ const char *ice_aq_str(enum ice_aq_err aq_err)\n \t\treturn \"ICE_AQ_RC_ENOSPC\";\n \tcase ICE_AQ_RC_ENOSYS:\n \t\treturn \"ICE_AQ_RC_ENOSYS\";\n+\tcase ICE_AQ_RC_EMODE:\n+\t\treturn \"ICE_AQ_RC_EMODE\";\n \tcase ICE_AQ_RC_ENOSEC:\n \t\treturn \"ICE_AQ_RC_ENOSEC\";\n \tcase ICE_AQ_RC_EBADSIG:\n", "prefixes": [ "S46", "9/9" ] }