Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291791/?format=api
{ "id": 1291791, "url": "http://patchwork.ozlabs.org/api/patches/1291791/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-3-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516005506.5113-3-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:55:00", "name": "[S46,3/9] ice: Fix inability to set channels when down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eada820015e2b095e93ddbff4148797162103fd5", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005506.5113-3-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177331, "url": "http://patchwork.ozlabs.org/api/series/177331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177331", "date": "2020-05-16T00:55:01", "name": "[S46,1/9] ice: Reset VF for all port VLAN changes from host", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291791/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291791/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P6MM43zLz9sTL\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:57:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CAABA227FC;\n\tSat, 16 May 2020 00:57:49 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lAzGLfXtN45O; Sat, 16 May 2020 00:57:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6999522622;\n\tSat, 16 May 2020 00:57:48 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id 4A8C51BF9CC\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 46BF3204BE\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id baDzHHrjT1sB for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:57:42 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by silver.osuosl.org (Postfix) with ESMTPS id E3C2A22731\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:57:41 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:57:40 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga005.fm.intel.com with ESMTP; 15 May 2020 17:57:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n doX47zDKx1D7/pQ0R66vX5kuQLfs0PqjUwwEfsXgwQY+zUYeSVnxMWRtLrLJBg99Pml1vFnt3s\n 28Rh8HRPWPjA==", "\n jeN8P/eMWnw7H6Xp1lEPuHZLIk4wDS++gv8sll4dzD1tJPkqa+iVocmPgcHW6w6mz8jBWMCZI4\n Mk/7eh11hu1w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"464922698\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:55:00 -0700", "Message-Id": "<20200516005506.5113-3-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "References": "<20200516005506.5113-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S46 3/9] ice: Fix inability to set\n channels when down", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nCurrently the driver prevents a user from doing\nmodprobe ice\nethtool -L eth0 combined 5\nip link set eth0 up\n\nThe ethtool command fails, because the driver is checking to see if the\ninterface is down before allowing the get_channels to proceed (even for\na set_channels).\n\nRemove this check and allow the user to configure the interface\nbefore bringing it up, which is a much better usability case.\n\nFixes: 87324e747fde (\"ice: Implement ethtool ops for channels\")\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex fd1849155d85..68c38004a088 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3189,10 +3189,6 @@ ice_get_channels(struct net_device *dev, struct ethtool_channels *ch)\n \tstruct ice_vsi *vsi = np->vsi;\n \tstruct ice_pf *pf = vsi->back;\n \n-\t/* check to see if VSI is active */\n-\tif (test_bit(__ICE_DOWN, vsi->state))\n-\t\treturn;\n-\n \t/* report maximum channels */\n \tch->max_rx = ice_get_max_rxq(pf);\n \tch->max_tx = ice_get_max_txq(pf);\n", "prefixes": [ "S46", "3/9" ] }