Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291782/?format=api
{ "id": 1291782, "url": "http://patchwork.ozlabs.org/api/patches/1291782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005121.4963-3-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516005121.4963-3-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:51:09", "name": "[S45,03/15] ice: Add helper function for clearing VPGEN_VFRTRIG", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a913210993feac474edade62e68513bd9152bcc8", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516005121.4963-3-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177330, "url": "http://patchwork.ozlabs.org/api/series/177330/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177330", "date": "2020-05-16T00:51:18", "name": "[S45,01/15] ice: Refactor ice_ena_vf_mappings to split MSIX and queue mappings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177330/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291782/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291782/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P6H84FwHz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:54:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2F7C187F7D;\n\tSat, 16 May 2020 00:54:11 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DBl1djhDmnbJ; Sat, 16 May 2020 00:54:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B030C881F1;\n\tSat, 16 May 2020 00:54:08 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 5EDAE1BF9C6\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:54:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 5B7C087F7D\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:54:00 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id thzaNlsoOTme for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:53:55 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id BEB5888017\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:53:55 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:53:54 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by orsmga003.jf.intel.com with ESMTP; 15 May 2020 17:53:54 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 5tMGkivW2nMBnsl978e/Qjzjx8b4Orko9P844UmwbA4C2mWVvD190JG8BLLKbj8tQWxCRjOF5r\n ygEk8UDYPMkA==", "\n 3SbeT/wF1bKNbcT/kI7OTZOjcoomF9jxx4cVo1ly5G0RFrcoMRxgc2n1npqTugJGe2xjoqACdN\n Yc94lkjdf0/Q==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"263360539\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:51:09 -0700", "Message-Id": "<20200516005121.4963-3-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516005121.4963-1-anthony.l.nguyen@intel.com>", "References": "<20200516005121.4963-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S45 03/15] ice: Add helper function for\n clearing VPGEN_VFRTRIG", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCreate a helper function for clearing VPGEN_VFRTRIG as this needs to be\ndone on reset to notify the VF that we are done resetting it. Also, it\nneeds to be done on SR-IOV initialization/creation in case it was left\nin a bad state after SR-IOV teardown.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 31 ++++++++++++-------\n 1 file changed, 20 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 5d6f23cf0c1f..18fe4cfe4443 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -961,6 +961,21 @@ static int ice_set_per_vf_res(struct ice_pf *pf)\n \treturn 0;\n }\n \n+/**\n+ * ice_clear_vf_reset_trigger - enable VF to access hardware\n+ * @vf: VF to enabled hardware access for\n+ */\n+static void ice_clear_vf_reset_trigger(struct ice_vf *vf)\n+{\n+\tstruct ice_hw *hw = &vf->pf->hw;\n+\tu32 reg;\n+\n+\treg = rd32(hw, VPGEN_VFRTRIG(vf->vf_id));\n+\treg &= ~VPGEN_VFRTRIG_VFSWR_M;\n+\twr32(hw, VPGEN_VFRTRIG(vf->vf_id), reg);\n+\tice_flush(hw);\n+}\n+\n /**\n * ice_cleanup_and_realloc_vf - Clean up VF and reallocate resources after reset\n * @vf: pointer to the VF structure\n@@ -974,26 +989,20 @@ static void ice_cleanup_and_realloc_vf(struct ice_vf *vf)\n {\n \tstruct ice_pf *pf = vf->pf;\n \tstruct ice_hw *hw;\n-\tu32 reg;\n \n \thw = &pf->hw;\n \n-\t/* PF software completes the flow by notifying VF that reset flow is\n-\t * completed. This is done by enabling hardware by clearing the reset\n-\t * bit in the VPGEN_VFRTRIG reg and setting VFR_STATE in the VFGEN_RSTAT\n-\t * register to VFR completed (done at the end of this function)\n-\t * By doing this we allow HW to access VF memory at any point. If we\n-\t * did it any sooner, HW could access memory while it was being freed\n-\t * in ice_free_vf_res(), causing an IOMMU fault.\n+\t/* Allow HW to access VF memory after calling\n+\t * ice_clear_vf_reset_trigger(). If we did it any sooner, HW could\n+\t * access memory while it was being freed in ice_free_vf_res(), causing\n+\t * an IOMMU fault.\n \t *\n \t * On the other hand, this needs to be done ASAP, because the VF driver\n \t * is waiting for this to happen and may report a timeout. It's\n \t * harmless, but it gets logged into Guest OS kernel log, so best avoid\n \t * it.\n \t */\n-\treg = rd32(hw, VPGEN_VFRTRIG(vf->vf_id));\n-\treg &= ~VPGEN_VFRTRIG_VFSWR_M;\n-\twr32(hw, VPGEN_VFRTRIG(vf->vf_id), reg);\n+\tice_clear_vf_reset_trigger(vf);\n \n \t/* reallocate VF resources to finish resetting the VSI state */\n \tif (!ice_alloc_vf_res(vf)) {\n", "prefixes": [ "S45", "03/15" ] }