Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291764/?format=api
{ "id": 1291764, "url": "http://patchwork.ozlabs.org/api/patches/1291764/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516004226.4795-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:42:19", "name": "[S44,07/14] ice: Refactor Rx checksum checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8c41076fe2f336770904b7cc9290b0e1b8bcb54a", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177328, "url": "http://patchwork.ozlabs.org/api/series/177328/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177328", "date": "2020-05-16T00:42:13", "name": "[S44,01/14] ice: Don't allow VLAN stripping change when pvid set", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177328/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291764/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291764/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P64l20Qdz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:45:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A5107890A7;\n\tSat, 16 May 2020 00:45:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ryPS4moRdtuu; Sat, 16 May 2020 00:45:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 11C3C890B3;\n\tSat, 16 May 2020 00:45:05 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 3321D1BF2B9\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 29F75881F1\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id WgoCCx_5KJ2G for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:45:01 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 776FC87F93\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:01 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:45:00 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga004.fm.intel.com with ESMTP; 15 May 2020 17:45:00 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n G9baYJiBJoX/IJzNBF0oPhAb1LWw4bC4XycODsxgDDTMhxiQN9Sf4JwcmVm4padsun/2QTxtDr\n 1pmwzsooNufA==", "\n f3kPV/vYtDTkQUOP1GxThVqRPK7kGIHtZDCraA5zJS1LA1Z+FfJvogg1meVmp7qRHHXiJP0b2g\n kQWplJfMK8/A==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"287960350\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:42:19 -0700", "Message-Id": "<20200516004226.4795-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "References": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S44 07/14] ice: Refactor Rx checksum checks", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n\nWe don't need both rx_status and rx_error parameters, as the latter is\na subset of the former. Remove rx_error completely and check the right bit\nin rx_status.\n\nRename rx_status to rx_status0, and rx_status_err1 to\nrx_status1. This naming more closely reflects the specification.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 27 ++++++++-----------\n 1 file changed, 11 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\nindex 1ba97172d8d0..ab2031b1c635 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n@@ -84,17 +84,12 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,\n \t union ice_32b_rx_flex_desc *rx_desc, u8 ptype)\n {\n \tstruct ice_rx_ptype_decoded decoded;\n-\tu16 rx_error, rx_status;\n-\tu16 rx_stat_err1;\n+\tu16 rx_status0, rx_status1;\n \tbool ipv4, ipv6;\n \n-\trx_status = le16_to_cpu(rx_desc->wb.status_error0);\n-\trx_error = rx_status & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S) |\n-\t\t\t\tBIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_L4E_S) |\n-\t\t\t\tBIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S) |\n-\t\t\t\tBIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S));\n+\trx_status0 = le16_to_cpu(rx_desc->wb.status_error0);\n+\trx_status1 = le16_to_cpu(rx_desc->wb.status_error1);\n \n-\trx_stat_err1 = le16_to_cpu(rx_desc->wb.status_error1);\n \tdecoded = ice_decode_rx_desc_ptype(ptype);\n \n \t/* Start with CHECKSUM_NONE and by default csum_level = 0 */\n@@ -106,7 +101,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,\n \t\treturn;\n \n \t/* check if HW has decoded the packet and checksum */\n-\tif (!(rx_status & BIT(ICE_RX_FLEX_DESC_STATUS0_L3L4P_S)))\n+\tif (!(rx_status0 & BIT(ICE_RX_FLEX_DESC_STATUS0_L3L4P_S)))\n \t\treturn;\n \n \tif (!(decoded.known && decoded.outer_ip))\n@@ -117,22 +112,22 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,\n \tipv6 = (decoded.outer_ip == ICE_RX_PTYPE_OUTER_IP) &&\n \t (decoded.outer_ip_ver == ICE_RX_PTYPE_OUTER_IPV6);\n \n-\tif (ipv4 && (rx_error & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S) |\n-\t\t\t\t BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S))))\n+\tif (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S) |\n+\t\t\t\t BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S))))\n \t\tgoto checksum_fail;\n-\telse if (ipv6 && (rx_status &\n-\t\t (BIT(ICE_RX_FLEX_DESC_STATUS0_IPV6EXADD_S))))\n+\n+\tif (ipv6 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_IPV6EXADD_S))))\n \t\tgoto checksum_fail;\n \n \t/* check for L4 errors and handle packets that were not able to be\n \t * checksummed due to arrival speed\n \t */\n-\tif (rx_error & BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_L4E_S))\n+\tif (rx_status0 & BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_L4E_S))\n \t\tgoto checksum_fail;\n \n \t/* check for outer UDP checksum error in tunneled packets */\n-\tif ((rx_stat_err1 & BIT(ICE_RX_FLEX_DESC_STATUS1_NAT_S)) &&\n-\t (rx_error & BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S)))\n+\tif ((rx_status1 & BIT(ICE_RX_FLEX_DESC_STATUS1_NAT_S)) &&\n+\t (rx_status0 & BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S)))\n \t\tgoto checksum_fail;\n \n \t/* If there is an outer header present that might contain a checksum\n", "prefixes": [ "S44", "07/14" ] }