Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291760/?format=api
{ "id": 1291760, "url": "http://patchwork.ozlabs.org/api/patches/1291760/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-4-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516004226.4795-4-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:42:16", "name": "[S44,04/14] ice: Add XDP Tx to VSI ring stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fd4e93a76303a9edd63387699b3714bdd9891528", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-4-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177328, "url": "http://patchwork.ozlabs.org/api/series/177328/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177328", "date": "2020-05-16T00:42:13", "name": "[S44,01/14] ice: Don't allow VLAN stripping change when pvid set", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177328/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291760/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P64h6WLPz9sTL\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:45:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4D74989A30;\n\tSat, 16 May 2020 00:45:07 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MowTaPqRoJvy; Sat, 16 May 2020 00:45:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BCE9189A34;\n\tSat, 16 May 2020 00:45:06 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 457201BF2B9\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:03 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 42CFF8811E\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:03 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id xjo20irTWsNh for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:45:01 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 04D3587F8B\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:00 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:44:59 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga004.fm.intel.com with ESMTP; 15 May 2020 17:44:59 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 1+obTzD5I2B+AJlBinKrJFW/aTY0LYHtrr4hLZdPsQv2BrTbOjgf+Cds9bprFHj6hp5jSxtoid\n YHqmAbg30GDQ==", "\n g5oZuk915M3WwE1L4nb7VzE1V1VOTq0TJLaufu3uzm1VNZe5c+PjAwPgUdAthDTeaDJ+6VqMxt\n L4dwnjzPTR+w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"287960346\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:42:16 -0700", "Message-Id": "<20200516004226.4795-4-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "References": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S44 04/14] ice: Add XDP Tx to VSI ring\n stats", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Marta Plantykow <marta.a.plantykow@intel.com>\n\nWhen XDP Tx program is loaded and packets are sent from\ninterface, VSI statistics are not updated. This patch adds\npackets sent on Tx XDP ring to VSI ring stats.\n\nSigned-off-by: Marta Plantykow <marta.a.plantykow@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 42 ++++++++++++++++++-----\n 1 file changed, 33 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 61c7d0b57f02..a74b2ce6956a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4281,6 +4281,33 @@ ice_fetch_u64_stats_per_ring(struct ice_ring *ring, u64 *pkts, u64 *bytes)\n \t} while (u64_stats_fetch_retry_irq(&ring->syncp, start));\n }\n \n+/**\n+ * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters\n+ * @vsi: the VSI to be updated\n+ * @rings: rings to work on\n+ * @count: number of rings\n+ */\n+static void\n+ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_ring **rings,\n+\t\t\t u16 count)\n+{\n+\tstruct rtnl_link_stats64 *vsi_stats = &vsi->net_stats;\n+\tu16 i;\n+\n+\tfor (i = 0; i < count; i++) {\n+\t\tstruct ice_ring *ring;\n+\t\tu64 pkts, bytes;\n+\n+\t\tring = READ_ONCE(rings[i]);\n+\t\tice_fetch_u64_stats_per_ring(ring, &pkts, &bytes);\n+\t\tvsi_stats->tx_packets += pkts;\n+\t\tvsi_stats->tx_bytes += bytes;\n+\t\tvsi->tx_restart += ring->tx_stats.restart_q;\n+\t\tvsi->tx_busy += ring->tx_stats.tx_busy;\n+\t\tvsi->tx_linearize += ring->tx_stats.tx_linearize;\n+\t}\n+}\n+\n /**\n * ice_update_vsi_ring_stats - Update VSI stats counters\n * @vsi: the VSI to be updated\n@@ -4308,15 +4335,7 @@ static void ice_update_vsi_ring_stats(struct ice_vsi *vsi)\n \trcu_read_lock();\n \n \t/* update Tx rings counters */\n-\tice_for_each_txq(vsi, i) {\n-\t\tring = READ_ONCE(vsi->tx_rings[i]);\n-\t\tice_fetch_u64_stats_per_ring(ring, &pkts, &bytes);\n-\t\tvsi_stats->tx_packets += pkts;\n-\t\tvsi_stats->tx_bytes += bytes;\n-\t\tvsi->tx_restart += ring->tx_stats.restart_q;\n-\t\tvsi->tx_busy += ring->tx_stats.tx_busy;\n-\t\tvsi->tx_linearize += ring->tx_stats.tx_linearize;\n-\t}\n+\tice_update_vsi_tx_ring_stats(vsi, vsi->tx_rings, vsi->num_txq);\n \n \t/* update Rx rings counters */\n \tice_for_each_rxq(vsi, i) {\n@@ -4328,6 +4347,11 @@ static void ice_update_vsi_ring_stats(struct ice_vsi *vsi)\n \t\tvsi->rx_page_failed += ring->rx_stats.alloc_page_failed;\n \t}\n \n+\t/* update XDP Tx rings counters */\n+\tif (ice_is_xdp_ena_vsi(vsi))\n+\t\tice_update_vsi_tx_ring_stats(vsi, vsi->xdp_rings,\n+\t\t\t\t\t vsi->num_xdp_txq);\n+\n \trcu_read_unlock();\n }\n \n", "prefixes": [ "S44", "04/14" ] }