Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291759/?format=api
{ "id": 1291759, "url": "http://patchwork.ozlabs.org/api/patches/1291759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-14-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516004226.4795-14-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:42:26", "name": "[S44,14/14] ice: Declare functions static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce74826ceac3e5af8a5cc59fe774f8dcb9e6d6dc", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516004226.4795-14-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177328, "url": "http://patchwork.ozlabs.org/api/series/177328/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177328", "date": "2020-05-16T00:42:13", "name": "[S44,01/14] ice: Don't allow VLAN stripping change when pvid set", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177328/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291759/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P64h2ythz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:45:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C3D2B88207;\n\tSat, 16 May 2020 00:45:06 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1giJzb77Z41M; Sat, 16 May 2020 00:45:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2674188017;\n\tSat, 16 May 2020 00:45:06 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id B0A0F1BF9C8\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id AE06487F93\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 9aOR8MH-ks9U for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 281E2881F0\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:45:02 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:45:01 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by fmsmga004.fm.intel.com with ESMTP; 15 May 2020 17:45:00 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 5ar5n/tIjWuT6WE/Nl3F6Jb6RMB/jsOA4T8KmwVCAoLhtf7KovJOPHq7NJBE/E92Gy89EQTE6r\n hN7ZTyXeiz6g==", "\n 5NRUnrRqZKbfO2nz/71IXf1Q/kxVPidS3fwLdybiN3hw4vmqahxCrcl8y8WCKxHY9yL4a4hs38\n jRuDHi+5IWgg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"287960359\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:42:26 -0700", "Message-Id": "<20200516004226.4795-14-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "References": "<20200516004226.4795-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S44 14/14] ice: Declare functions static", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ice_get_pfa_module_tlv() and ice_read_sr_word() are not being called\noutside of their file. Declare them as static.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_nvm.c | 5 +++--\n drivers/net/ethernet/intel/ice/ice_nvm.h | 4 ----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c b/drivers/net/ethernet/intel/ice/ice_nvm.c\nindex 7c2a06892bbb..b049c1c30c88 100644\n--- a/drivers/net/ethernet/intel/ice/ice_nvm.c\n+++ b/drivers/net/ethernet/intel/ice/ice_nvm.c\n@@ -172,7 +172,8 @@ void ice_release_nvm(struct ice_hw *hw)\n *\n * Reads one 16 bit word from the Shadow RAM using the ice_read_sr_word_aq.\n */\n-enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)\n+static enum ice_status\n+ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)\n {\n \tenum ice_status status;\n \n@@ -196,7 +197,7 @@ enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)\n * Area (PFA) and returns the TLV pointer and length. The caller can\n * use these to read the variable length TLV value.\n */\n-enum ice_status\n+static enum ice_status\n ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,\n \t\t u16 module_type)\n {\ndiff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h b/drivers/net/ethernet/intel/ice/ice_nvm.h\nindex 999f273ba6ad..165eda07b93d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_nvm.h\n+++ b/drivers/net/ethernet/intel/ice/ice_nvm.h\n@@ -11,10 +11,6 @@ enum ice_status\n ice_read_flat_nvm(struct ice_hw *hw, u32 offset, u32 *length, u8 *data,\n \t\t bool read_shadow_ram);\n enum ice_status\n-ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,\n-\t\t u16 module_type);\n-enum ice_status\n ice_read_pba_string(struct ice_hw *hw, u8 *pba_num, u32 pba_num_size);\n enum ice_status ice_init_nvm(struct ice_hw *hw);\n-enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data);\n #endif /* _ICE_NVM_H_ */\n", "prefixes": [ "S44", "14/14" ] }