Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291751/?format=api
{ "id": 1291751, "url": "http://patchwork.ozlabs.org/api/patches/1291751/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516003644.4658-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:36:36", "name": "[S43,07/15] ice: fix usage of incorrect variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "398b8526d1c145cbd61f89d539c0722e82fb4f7a", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177325, "url": "http://patchwork.ozlabs.org/api/series/177325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177325", "date": "2020-05-16T00:36:39", "name": "[S43,01/15] ice: Call ice_aq_set_mac_cfg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291751/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291751/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P5yH4pvNz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:39:35 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CE3D122795;\n\tSat, 16 May 2020 00:39:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5f+rALmptchA; Sat, 16 May 2020 00:39:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CAEE5227B1;\n\tSat, 16 May 2020 00:39:29 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 015491BF9C6\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id F2AA087740\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id xbtgaH0DumgS for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by whitealder.osuosl.org (Postfix) with ESMTPS id C761B87C20\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:19 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:39:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 17:39:18 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n PlamzVlPqGmEwPsFICcdXojxqylh9Rnq8mLNOyBRpJSWhkDm5k1GPfDUJ6lUQZiv3u8EnihUah\n saWY/5u6kf0Q==", "\n KcM4vH+bXj8KG8GjoReffdwyVGMe76TwuBODDX1EYNjU9Rt03b/LJAiwkCb+rhVxuucEUTYOnU\n 9H9kST6sEGxA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"307560864\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:36:36 -0700", "Message-Id": "<20200516003644.4658-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "References": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S43 07/15] ice: fix usage of incorrect\n variable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver was using rq_last_status where it should have been\nusing sq_last_status. Fix the string to be using the correct\nerror reporting variable.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-\n drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 477ad33e0403..f39d4eb7fd8b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3251,7 +3251,7 @@ static int ice_vsi_set_dflt_rss_lut(struct ice_vsi *vsi, int req_rss_size)\n \tif (status) {\n \t\tdev_err(dev, \"Cannot set RSS lut, err %s aq_err %s\\n\",\n \t\t\tice_stat_str(status),\n-\t\t\tice_aq_str(hw->adminq.rq_last_status));\n+\t\t\tice_aq_str(hw->adminq.sq_last_status));\n \t\terr = -EIO;\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 5675804ba899..4731c919a080 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5317,7 +5317,7 @@ int ice_set_rss(struct ice_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size)\n \t\tif (status) {\n \t\t\tdev_err(dev, \"Cannot set RSS key, err %s aq_err %s\\n\",\n \t\t\t\tice_stat_str(status),\n-\t\t\t\tice_aq_str(hw->adminq.rq_last_status));\n+\t\t\t\tice_aq_str(hw->adminq.sq_last_status));\n \t\t\treturn -EIO;\n \t\t}\n \t}\n@@ -5328,7 +5328,7 @@ int ice_set_rss(struct ice_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size)\n \t\tif (status) {\n \t\t\tdev_err(dev, \"Cannot set RSS lut, err %s aq_err %s\\n\",\n \t\t\t\tice_stat_str(status),\n-\t\t\t\tice_aq_str(hw->adminq.rq_last_status));\n+\t\t\t\tice_aq_str(hw->adminq.sq_last_status));\n \t\t\treturn -EIO;\n \t\t}\n \t}\n@@ -5361,7 +5361,7 @@ int ice_get_rss(struct ice_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size)\n \t\tif (status) {\n \t\t\tdev_err(dev, \"Cannot get RSS key, err %s aq_err %s\\n\",\n \t\t\t\tice_stat_str(status),\n-\t\t\t\tice_aq_str(hw->adminq.rq_last_status));\n+\t\t\t\tice_aq_str(hw->adminq.sq_last_status));\n \t\t\treturn -EIO;\n \t\t}\n \t}\n@@ -5372,7 +5372,7 @@ int ice_get_rss(struct ice_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size)\n \t\tif (status) {\n \t\t\tdev_err(dev, \"Cannot get RSS lut, err %s aq_err %s\\n\",\n \t\t\t\tice_stat_str(status),\n-\t\t\t\tice_aq_str(hw->adminq.rq_last_status));\n+\t\t\t\tice_aq_str(hw->adminq.sq_last_status));\n \t\t\treturn -EIO;\n \t\t}\n \t}\n", "prefixes": [ "S43", "07/15" ] }