Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291750/?format=api
{ "id": 1291750, "url": "http://patchwork.ozlabs.org/api/patches/1291750/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-9-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516003644.4658-9-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:36:38", "name": "[S43,09/15] ice: fix signed vs unsigned comparisons", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6ea12d0a97ace13ef5fde9d805be6d4ca0fb80c5", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-9-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177325, "url": "http://patchwork.ozlabs.org/api/series/177325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177325", "date": "2020-05-16T00:36:39", "name": "[S43,01/15] ice: Call ice_aq_set_mac_cfg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291750/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291750/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P5yG5lcsz9sTL\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:39:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5F9D0227FA;\n\tSat, 16 May 2020 00:39:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gIcK6qG4VPXQ; Sat, 16 May 2020 00:39:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 20BEE22795;\n\tSat, 16 May 2020 00:39:28 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id B7FBC1BF9C6\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id B53638771C\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Xp6EfC9cp1bE for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by whitealder.osuosl.org (Postfix) with ESMTPS id E262287C2E\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:19 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:39:19 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 17:39:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n qzK6QXxO6K7IzLqTjl2LG0Wy7LUSMti8wtKduxn3bONQ2xKc+iYXaVZTlSNhlvj8kr5K6hVKl1\n bisoTcMn0YEQ==", "\n vHDfsKAeHB2COyXMNlEFK+xC/nUGZ3U6bd+jLftcGj1ODJ9wMTbalCrJMGEDIcvgWpCEAQTmgI\n +Mg8/l9KfKJw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"307560866\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:36:38 -0700", "Message-Id": "<20200516003644.4658-9-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "References": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S43 09/15] ice: fix signed vs unsigned\n comparisons", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nFix the remaining signed vs unsigned issues, which appear\nwhen compiling with -Werror=sign-compare.\n\nMany of these are because there is an external interface that is passing\nan int to us (which we can't change) but that we (rightfully) store\nand compare against as an unsigned in our data structures.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_base.c | 4 ++--\n drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++----\n drivers/net/ethernet/intel/ice/ice_txrx.h | 7 ++++---\n 3 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c\nindex 00c072f61a32..ff6a5cf8e06f 100644\n--- a/drivers/net/ethernet/intel/ice/ice_base.c\n+++ b/drivers/net/ethernet/intel/ice/ice_base.c\n@@ -12,7 +12,7 @@\n */\n static int __ice_vsi_get_qs_contig(struct ice_qs_cfg *qs_cfg)\n {\n-\tint offset, i;\n+\tunsigned int offset, i;\n \n \tmutex_lock(qs_cfg->qs_mutex);\n \toffset = bitmap_find_next_zero_area(qs_cfg->pf_map, qs_cfg->pf_map_size,\n@@ -38,7 +38,7 @@ static int __ice_vsi_get_qs_contig(struct ice_qs_cfg *qs_cfg)\n */\n static int __ice_vsi_get_qs_sc(struct ice_qs_cfg *qs_cfg)\n {\n-\tint i, index = 0;\n+\tunsigned int i, index = 0;\n \n \tmutex_lock(qs_cfg->qs_mutex);\n \tfor (i = 0; i < qs_cfg->q_count; i++) {\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex e12413ec2504..e451120d6632 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -5107,7 +5107,7 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)\n \tu8 count = 0;\n \tint err = 0;\n \n-\tif (new_mtu == netdev->mtu) {\n+\tif (new_mtu == (int)netdev->mtu) {\n \t\tnetdev_warn(netdev, \"MTU is already %u\\n\", netdev->mtu);\n \t\treturn 0;\n \t}\n@@ -5122,11 +5122,11 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)\n \t\t}\n \t}\n \n-\tif (new_mtu < netdev->min_mtu) {\n+\tif (new_mtu < (int)netdev->min_mtu) {\n \t\tnetdev_err(netdev, \"new MTU invalid. min_mtu is %d\\n\",\n \t\t\t netdev->min_mtu);\n \t\treturn -EINVAL;\n-\t} else if (new_mtu > netdev->max_mtu) {\n+\t} else if (new_mtu > (int)netdev->max_mtu) {\n \t\tnetdev_err(netdev, \"new MTU invalid. max_mtu is %d\\n\",\n \t\t\t netdev->min_mtu);\n \t\treturn -EINVAL;\n@@ -5151,7 +5151,7 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)\n \tif (!event)\n \t\treturn -ENOMEM;\n \n-\tnetdev->mtu = new_mtu;\n+\tnetdev->mtu = (unsigned int)new_mtu;\n \n \t/* if VSI is up, bring it down and then back up */\n \tif (!test_and_set_bit(__ICE_DOWN, vsi->state)) {\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.h b/drivers/net/ethernet/intel/ice/ice_txrx.h\nindex 7c4030caeea4..4a8006e80f65 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.h\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.h\n@@ -38,7 +38,8 @@\n */\n #if (PAGE_SIZE < 8192)\n #define ICE_2K_TOO_SMALL_WITH_PADDING \\\n-((NET_SKB_PAD + ICE_RXBUF_1536) > SKB_WITH_OVERHEAD(ICE_RXBUF_2048))\n+\t((unsigned int)(NET_SKB_PAD + ICE_RXBUF_1536) > \\\n+\t\t\tSKB_WITH_OVERHEAD(ICE_RXBUF_2048))\n \n /**\n * ice_compute_pad - compute the padding\n@@ -107,8 +108,8 @@ static inline int ice_skb_pad(void)\n #define DESC_NEEDED (MAX_SKB_FRAGS + ICE_DESCS_FOR_CTX_DESC + \\\n \t\t ICE_DESCS_PER_CACHE_LINE + ICE_DESCS_FOR_SKB_DATA_PTR)\n #define ICE_DESC_UNUSED(R)\t\\\n-\t((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \\\n-\t(R)->next_to_clean - (R)->next_to_use - 1)\n+\t(u16)((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \\\n+\t (R)->next_to_clean - (R)->next_to_use - 1)\n \n #define ICE_TX_FLAGS_TSO\tBIT(0)\n #define ICE_TX_FLAGS_HW_VLAN\tBIT(1)\n", "prefixes": [ "S43", "09/15" ] }