Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291747/?format=api
{ "id": 1291747, "url": "http://patchwork.ozlabs.org/api/patches/1291747/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-12-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516003644.4658-12-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:36:41", "name": "[S43,12/15] ice: fix MAC write command", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7eca165fdd8d04e9fc2972f021710d218237e908", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-12-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177325, "url": "http://patchwork.ozlabs.org/api/series/177325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177325", "date": "2020-05-16T00:36:39", "name": "[S43,01/15] ice: Call ice_aq_set_mac_cfg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291747/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P5yF5Lzpz9sTL\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:39:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2A78288209;\n\tSat, 16 May 2020 00:39:32 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OTNwKZcpiaBA; Sat, 16 May 2020 00:39:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DE2EB88017;\n\tSat, 16 May 2020 00:39:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id 17DF41BF2B9\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id 1450089A34\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:22 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 05U4swKCeqIU for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by hemlock.osuosl.org (Postfix) with ESMTPS id 2D85089A2C\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:39:19 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 17:39:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n AAJUn5d4DD0tGL4mkJBq+G/3GgBfnR20Uh2x+Jf1MxUfWD9L+rQ4x9kuZxums1sMFazHz66YRF\n HiGe+wlZPfDg==", "\n JZaqJYr/HB5y/3sgFZ4B708zHsH1QNV81xea/2I2YFjSgzWgRjv+ccol4rJvQL0Y3fN5u6pDR6\n +ebWI9Lr2e8w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"307560869\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:36:41 -0700", "Message-Id": "<20200516003644.4658-12-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "References": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S43 12/15] ice: fix MAC write command", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe manage MAC write command was implemented in an overly complex way\nthat actually didn't work, as it wasn't symmetric to the manage MAC\nread command, and was feeding bytes out of order to the firmware. Fix\nthe implementation by just using a simple array to represent the MAC\naddress when it is being written via firmware command.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 10 ++++------\n drivers/net/ethernet/intel/ice/ice_common.c | 5 +----\n 2 files changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\nindex d0ee14254df1..1d939ff4bf99 100644\n--- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n+++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n@@ -157,13 +157,11 @@ struct ice_aqc_manage_mac_write {\n #define ICE_AQC_MAN_MAC_WR_MC_MAG_EN\t\tBIT(0)\n #define ICE_AQC_MAN_MAC_WR_WOL_LAA_PFR_KEEP\tBIT(1)\n #define ICE_AQC_MAN_MAC_WR_S\t\t6\n-#define ICE_AQC_MAN_MAC_WR_M\t\t(3 << ICE_AQC_MAN_MAC_WR_S)\n+#define ICE_AQC_MAN_MAC_WR_M\t\tICE_M(3, ICE_AQC_MAN_MAC_WR_S)\n #define ICE_AQC_MAN_MAC_UPDATE_LAA\t0\n-#define ICE_AQC_MAN_MAC_UPDATE_LAA_WOL\t(BIT(0) << ICE_AQC_MAN_MAC_WR_S)\n-\t/* High 16 bits of MAC address in big endian order */\n-\t__be16 sah;\n-\t/* Low 32 bits of MAC address in big endian order */\n-\t__be32 sal;\n+#define ICE_AQC_MAN_MAC_UPDATE_LAA_WOL\tBIT(ICE_AQC_MAN_MAC_WR_S)\n+\t/* byte stream in network order */\n+\tu8 mac_addr[ETH_ALEN];\n \t__le32 addr_high;\n \t__le32 addr_low;\n };\ndiff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex 06beae93176e..bba787a6faff 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -2010,10 +2010,7 @@ ice_aq_manage_mac_write(struct ice_hw *hw, const u8 *mac_addr, u8 flags,\n \tice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_manage_mac_write);\n \n \tcmd->flags = flags;\n-\n-\t/* Prep values for flags, sah, sal */\n-\tcmd->sah = htons(*((const u16 *)mac_addr));\n-\tcmd->sal = htonl(*((const u32 *)(mac_addr + 2)));\n+\tether_addr_copy(cmd->mac_addr, mac_addr);\n \n \treturn ice_aq_send_cmd(hw, &desc, NULL, 0, cd);\n }\n", "prefixes": [ "S43", "12/15" ] }