Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291744/?format=api
{ "id": 1291744, "url": "http://patchwork.ozlabs.org/api/patches/1291744/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-8-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516003644.4658-8-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:36:37", "name": "[S43,08/15] ice: cleanup unsigned loops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b487d70e53296a4cbd6441323689b69e54a0684", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-8-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177325, "url": "http://patchwork.ozlabs.org/api/series/177325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177325", "date": "2020-05-16T00:36:39", "name": "[S43,01/15] ice: Call ice_aq_set_mac_cfg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291744/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P5yC06snz9sTC\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:39:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8C2AC2281C;\n\tSat, 16 May 2020 00:39:29 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oj8aKxNXVhOH; Sat, 16 May 2020 00:39:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id DA44D227B1;\n\tSat, 16 May 2020 00:39:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by ash.osuosl.org (Postfix) with ESMTP id A4AB51BF9C8\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by hemlock.osuosl.org (Postfix) with ESMTP id A0FF189A27\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 39X96bnfrYrw for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by hemlock.osuosl.org (Postfix) with ESMTPS id E62A589A23\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:19 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:39:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 17:39:18 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n WLiUh05Y/hCcWGvrtWj190bQm8USiy5zIr1z16rLNqJGYZWk+63FjcNfbmnA3uyv9r28JlEI84\n VQayld3hHUfg==", "\n UcyxQZ0eDhfA2Hl4uNQtKFEzgjdvM3LgsKgGtkrVN038OXCjRoHDNb/FEbUxG2NQQcfHI3CBA1\n 5vsChTITgLqg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"307560865\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:36:37 -0700", "Message-Id": "<20200516003644.4658-8-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "References": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S43 08/15] ice: cleanup unsigned loops", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nFix loop variables that are comparing or assigning signed against\nunsigned values, mostly by declaring loop counters as unsigned.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_dcb_nl.c | 9 +++++----\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 10 +++++-----\n drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 4 ++--\n 4 files changed, 14 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_nl.c b/drivers/net/ethernet/intel/ice/ice_dcb_nl.c\nindex c4c12414083a..93cf70d06fe5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dcb_nl.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dcb_nl.c\n@@ -671,7 +671,7 @@ static bool\n ice_dcbnl_find_app(struct ice_dcbx_cfg *cfg,\n \t\t struct ice_dcb_app_priority_table *app)\n {\n-\tint i;\n+\tunsigned int i;\n \n \tfor (i = 0; i < cfg->numapps; i++) {\n \t\tif (app->selector == cfg->app[i].selector &&\n@@ -746,7 +746,8 @@ static int ice_dcbnl_delapp(struct net_device *netdev, struct dcb_app *app)\n {\n \tstruct ice_pf *pf = ice_netdev_to_pf(netdev);\n \tstruct ice_dcbx_cfg *old_cfg, *new_cfg;\n-\tint i, j, ret = 0;\n+\tunsigned int i, j;\n+\tint ret = 0;\n \n \tif (pf->dcbx_cap & DCB_CAP_DCBX_LLD_MANAGED)\n \t\treturn -EINVAL;\n@@ -869,7 +870,7 @@ void ice_dcbnl_set_all(struct ice_vsi *vsi)\n \tstruct ice_port_info *pi;\n \tstruct dcb_app sapp;\n \tstruct ice_pf *pf;\n-\tint i;\n+\tunsigned int i;\n \n \tif (!netdev)\n \t\treturn;\n@@ -941,7 +942,7 @@ ice_dcbnl_flush_apps(struct ice_pf *pf, struct ice_dcbx_cfg *old_cfg,\n \t\t struct ice_dcbx_cfg *new_cfg)\n {\n \tstruct ice_vsi *main_vsi = ice_get_main_vsi(pf);\n-\tint i;\n+\tunsigned int i;\n \n \tif (!main_vsi)\n \t\treturn;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex f39d4eb7fd8b..fd1849155d85 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -205,7 +205,7 @@ ice_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *p)\n \tstruct ice_pf *pf = np->vsi->back;\n \tstruct ice_hw *hw = &pf->hw;\n \tu32 *regs_buf = (u32 *)p;\n-\tint i;\n+\tunsigned int i;\n \n \tregs->version = 1;\n \n@@ -308,7 +308,7 @@ ice_get_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom,\n */\n static bool ice_active_vfs(struct ice_pf *pf)\n {\n-\tint i;\n+\tunsigned int i;\n \n \tice_for_each_vf(pf, i) {\n \t\tstruct ice_vf *vf = &pf->vf[i];\n@@ -378,7 +378,7 @@ static int ice_reg_pattern_test(struct ice_hw *hw, u32 reg, u32 mask)\n \t\t0x00000000, 0xFFFFFFFF\n \t};\n \tu32 val, orig_val;\n-\tint i;\n+\tunsigned int i;\n \n \torig_val = rd32(hw, reg);\n \tfor (i = 0; i < ARRAY_SIZE(patterns); ++i) {\n@@ -431,7 +431,7 @@ static u64 ice_reg_test(struct net_device *netdev)\n \t\t\tGLINT_ITR(2, 1) - GLINT_ITR(2, 0)},\n \t\t{GLINT_CTL, 0xffff0001, 1, 0}\n \t};\n-\tint i;\n+\tunsigned int i;\n \n \tnetdev_dbg(netdev, \"Register test\\n\");\n \tfor (i = 0; i < ARRAY_SIZE(ice_reg_list); ++i) {\n@@ -3759,10 +3759,10 @@ ice_get_module_eeprom(struct net_device *netdev,\n \tstruct ice_hw *hw = &pf->hw;\n \tenum ice_status status;\n \tbool is_sfp = false;\n+\tunsigned int i;\n \tu16 offset = 0;\n \tu8 value = 0;\n \tu8 page = 0;\n-\tint i;\n \n \tstatus = ice_aq_sff_eeprom(hw, 0, addr, offset, page, 0,\n \t\t\t\t &value, 1, 0, NULL);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 4731c919a080..e12413ec2504 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -453,7 +453,7 @@ static void\n ice_prepare_for_reset(struct ice_pf *pf)\n {\n \tstruct ice_hw *hw = &pf->hw;\n-\tint i;\n+\tunsigned int i;\n \n \t/* already prepared for reset */\n \tif (test_bit(__ICE_PREPARED_FOR_RESET, pf->state))\n@@ -1192,8 +1192,8 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n {\n \tstruct device *dev = ice_pf_to_dev(pf);\n \tstruct ice_hw *hw = &pf->hw;\n+\tunsigned int i;\n \tu32 reg;\n-\tint i;\n \n \tif (!test_and_clear_bit(__ICE_MDD_EVENT_PENDING, pf->state)) {\n \t\t/* Since the VF MDD event logging is rate limited, check if\ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 6ea3d15e1a6d..aec619215b2e 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -80,7 +80,7 @@ ice_vc_vf_broadcast(struct ice_pf *pf, enum virtchnl_ops v_opcode,\n \t\t enum virtchnl_status_code v_retval, u8 *msg, u16 msglen)\n {\n \tstruct ice_hw *hw = &pf->hw;\n-\tint i;\n+\tunsigned int i;\n \n \tice_for_each_vf(pf, i) {\n \t\tstruct ice_vf *vf = &pf->vf[i];\n@@ -325,7 +325,7 @@ void ice_free_vfs(struct ice_pf *pf)\n {\n \tstruct device *dev = ice_pf_to_dev(pf);\n \tstruct ice_hw *hw = &pf->hw;\n-\tint tmp, i;\n+\tunsigned int tmp, i;\n \n \tif (!pf->vf)\n \t\treturn;\n", "prefixes": [ "S43", "08/15" ] }