Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1291737/?format=api
{ "id": 1291737, "url": "http://patchwork.ozlabs.org/api/patches/1291737/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200516003644.4658-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-16T00:36:31", "name": "[S43,02/15] ice: print Rx MDD auto reset message before VF reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d79140fba59c78f9e4f28a9b90c3a6a7c004bab8", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200516003644.4658-2-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 177325, "url": "http://patchwork.ozlabs.org/api/series/177325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=177325", "date": "2020-05-16T00:36:39", "name": "[S43,01/15] ice: Call ice_aq_set_mac_cfg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/177325/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1291737/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1291737/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49P5y52v3nz9sTL\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 16 May 2020 10:39:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 53C2688017;\n\tSat, 16 May 2020 00:39:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id K-qAVqi-cBt3; Sat, 16 May 2020 00:39:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8787987F8B;\n\tSat, 16 May 2020 00:39:21 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 4E7EE1BF2B9\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 4477687C49\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id R+LxN0lBYGFB for <intel-wired-lan@lists.osuosl.org>;\n Sat, 16 May 2020 00:39:19 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 349C387740\n for <intel-wired-lan@lists.osuosl.org>; Sat, 16 May 2020 00:39:19 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 May 2020 17:39:18 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by FMSMGA003.fm.intel.com with ESMTP; 15 May 2020 17:39:18 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n /kBw2fCUO3V0ScTWXn8zBJFKad2iANNkgizWblRPmQLifZCYJ1m+JhS4zFaQJC92czBYanN2mT\n 0LjoYLaP2C8Q==", "\n RBdVAeE0rFaONrnv5pyQVuH7/qzEN0KLap5l59rMOcubYwRZ9zZytFhHGuw1iYr6GkUoq83Rmv\n upaCkf8qQBig==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,397,1583222400\"; d=\"scan'208\";a=\"307560857\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 15 May 2020 17:36:31 -0700", "Message-Id": "<20200516003644.4658-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "References": "<20200516003644.4658-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S43 02/15] ice: print Rx MDD auto reset\n message before VF reset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul Greenwalt <paul.greenwalt@intel.com>\n\nRx MDD auto reset message was not being logged because logging occurred\nafter the VF reset and the VF MDD data was reinitialized.\n\nLog the Rx MDD auto reset message before triggering the VF reset.\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 7 +++++-\n .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 25 ++++++++++++++-----\n .../net/ethernet/intel/ice/ice_virtchnl_pf.h | 2 ++\n 3 files changed, 27 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 6af21510c694..9a05945c6419 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1326,8 +1326,13 @@ static void ice_handle_mdd_event(struct ice_pf *pf)\n \t\t\t * PF can be configured to reset the VF through ethtool\n \t\t\t * private flag mdd-auto-reset-vf.\n \t\t\t */\n-\t\t\tif (test_bit(ICE_FLAG_MDD_AUTO_RESET_VF, pf->flags))\n+\t\t\tif (test_bit(ICE_FLAG_MDD_AUTO_RESET_VF, pf->flags)) {\n+\t\t\t\t/* VF MDD event counters will be cleared by\n+\t\t\t\t * reset, so print the event prior to reset.\n+\t\t\t\t */\n+\t\t\t\tice_print_vf_rx_mdd_event(vf);\n \t\t\t\tice_reset_vf(&pf->vf[i], false);\n+\t\t\t}\n \t\t}\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex a046bd3431c6..7c8c1687f0bf 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -3764,6 +3764,24 @@ int ice_get_vf_stats(struct net_device *netdev, int vf_id,\n \treturn 0;\n }\n \n+/**\n+ * ice_print_vf_rx_mdd_event - print VF Rx malicious driver detect event\n+ * @vf: pointer to the VF structure\n+ */\n+void ice_print_vf_rx_mdd_event(struct ice_vf *vf)\n+{\n+\tstruct ice_pf *pf = vf->pf;\n+\tstruct device *dev;\n+\n+\tdev = ice_pf_to_dev(pf);\n+\n+\tdev_info(dev, \"%d Rx Malicious Driver Detection events detected on PF %d VF %d MAC %pM. mdd-auto-reset-vfs=%s\\n\",\n+\t\t vf->mdd_rx_events.count, pf->hw.pf_id, vf->vf_id,\n+\t\t vf->dflt_lan_addr.addr,\n+\t\t test_bit(ICE_FLAG_MDD_AUTO_RESET_VF, pf->flags)\n+\t\t\t ? \"on\" : \"off\");\n+}\n+\n /**\n * ice_print_vfs_mdd_event - print VFs malicious driver detect event\n * @pf: pointer to the PF structure\n@@ -3793,12 +3811,7 @@ void ice_print_vfs_mdd_events(struct ice_pf *pf)\n \t\tif (vf->mdd_rx_events.count != vf->mdd_rx_events.last_printed) {\n \t\t\tvf->mdd_rx_events.last_printed =\n \t\t\t\t\t\t\tvf->mdd_rx_events.count;\n-\n-\t\t\tdev_info(dev, \"%d Rx Malicious Driver Detection events detected on PF %d VF %d MAC %pM. mdd-auto-reset-vfs=%s\\n\",\n-\t\t\t\t vf->mdd_rx_events.count, hw->pf_id, i,\n-\t\t\t\t vf->dflt_lan_addr.addr,\n-\t\t\t\t test_bit(ICE_FLAG_MDD_AUTO_RESET_VF, pf->flags)\n-\t\t\t\t\t ? \"on\" : \"off\");\n+\t\t\tice_print_vf_rx_mdd_event(vf);\n \t\t}\n \n \t\t/* only print Tx MDD event message if there are new events */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\nindex 474293ff4fe5..0adff89a6749 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h\n@@ -132,6 +132,7 @@ bool ice_is_any_vf_in_promisc(struct ice_pf *pf);\n void\n ice_vf_lan_overflow_event(struct ice_pf *pf, struct ice_rq_event_info *event);\n void ice_print_vfs_mdd_events(struct ice_pf *pf);\n+void ice_print_vf_rx_mdd_event(struct ice_vf *vf);\n #else /* CONFIG_PCI_IOV */\n #define ice_process_vflr_event(pf) do {} while (0)\n #define ice_free_vfs(pf) do {} while (0)\n@@ -141,6 +142,7 @@ void ice_print_vfs_mdd_events(struct ice_pf *pf);\n #define ice_set_vf_state_qs_dis(vf) do {} while (0)\n #define ice_vf_lan_overflow_event(pf, event) do {} while (0)\n #define ice_print_vfs_mdd_events(pf) do {} while (0)\n+#define ice_print_vf_rx_mdd_event(vf) do {} while (0)\n \n static inline bool\n ice_reset_all_vfs(struct ice_pf __always_unused *pf,\n", "prefixes": [ "S43", "02/15" ] }