Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1285693/?format=api
{ "id": 1285693, "url": "http://patchwork.ozlabs.org/api/patches/1285693/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200508004113.39725-11-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200508004113.39725-11-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-05-08T00:41:09", "name": "[S41,11/15] ice: Fix check for removing/adding mac filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53b7bce0714881e791a024a1239c19756982c462", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200508004113.39725-11-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 175527, "url": "http://patchwork.ozlabs.org/api/series/175527/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=175527", "date": "2020-05-08T00:41:10", "name": "[S41,01/15] ice: Add VF promiscuous support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/175527/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1285693/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1285693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=silver.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49JBQr0WNqz9sSG\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 8 May 2020 10:43:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1CE082152F;\n\tFri, 8 May 2020 00:43:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pptK1BJjCs6L; Fri, 8 May 2020 00:43:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 30A1C20496;\n\tFri, 8 May 2020 00:43:42 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 634E61BF2C4\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2020 00:43:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 5E96387871\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2020 00:43:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id u2sUnksVoF7B for <intel-wired-lan@lists.osuosl.org>;\n Fri, 8 May 2020 00:43:36 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 3F64087D6B\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2020 00:43:35 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2020 17:43:34 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.241.65])\n by orsmga007.jf.intel.com with ESMTP; 07 May 2020 17:43:33 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 7Mi8HrCN05fYoGTsDXvkUW8Hr2u+bTWQjjVHE1R8S0n1j3ll5sKUclSFVZxXJ6Z3f5I+AAIwyr\n ggqvlc/49Z5Q==", "\n 1ZrOD+6P40fwY+JY6gLzcDqWegMdX70Xq/YH9E2Wl5IkNrHSQrLUqboUn5oDf7Y7XM4TgseWpf\n u9nliXPs7Unw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,365,1583222400\"; d=\"scan'208\";a=\"249468776\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 May 2020 17:41:09 -0700", "Message-Id": "<20200508004113.39725-11-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200508004113.39725-1-anthony.l.nguyen@intel.com>", "References": "<20200508004113.39725-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S41 11/15] ice: Fix check for\n removing/adding mac filters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lihong Yang <lihong.yang@intel.com>\n\nIn function ice_set_mac_address, we will remove old dev_addr before\nadding the new MAC. In the removing and adding process of the MAC,\nthere is no need to return error if the check finds the to-be-removed\ndev_addr does not exist in the MAC filter list or the to-be-added mac\nalready exists, keep going or return success accordingly.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 99fa36f35a4f..5eca66849e52 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3771,19 +3771,24 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi)\n \t\treturn -EBUSY;\n \t}\n \n-\t/* Clean up old MAC filter before changing the MAC address */\n+\t/* Clean up old MAC filter. Not an error if old filter doesn't exist */\n \tstatus = ice_fltr_remove_mac(vsi, netdev->dev_addr, ICE_FWD_TO_VSI);\n-\tif (status) {\n+\tif (status && status != ICE_ERR_DOES_NOT_EXIST) {\n \t\terr = -EADDRNOTAVAIL;\n \t\tgoto err_update_filters;\n \t}\n \n+\t/* Add filter for new MAC. If filter exists, just return success */\n \tstatus = ice_fltr_add_mac(vsi, mac, ICE_FWD_TO_VSI);\n-\tif (status) {\n-\t\terr = -EADDRNOTAVAIL;\n-\t\tgoto err_update_filters;\n+\tif (status == ICE_ERR_ALREADY_EXISTS) {\n+\t\tnetdev_dbg(netdev, \"filter for MAC %pM already exists\\n\", mac);\n+\t\treturn 0;\n \t}\n \n+\t/* error if the new filter addition failed */\n+\tif (status)\n+\t\terr = -EADDRNOTAVAIL;\n+\n err_update_filters:\n \tif (err) {\n \t\tnetdev_err(netdev, \"can't set MAC %pM. filter update failed\\n\",\n", "prefixes": [ "S41", "11/15" ] }