Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1285511/?format=api
{ "id": 1285511, "url": "http://patchwork.ozlabs.org/api/patches/1285511/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507171406.6883-1-vitaly.lifshits@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200507171406.6883-1-vitaly.lifshits@intel.com>", "list_archive_url": null, "date": "2020-05-07T17:14:06", "name": "[v1] e1000e: disable s0ix entry and exit flows for ME systems", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b1570f04c3747ffffe4fdd4661420252f9ab16ad", "submitter": { "id": 76816, "url": "http://patchwork.ozlabs.org/api/people/76816/?format=api", "name": "Lifshits, Vitaly", "email": "vitaly.lifshits@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507171406.6883-1-vitaly.lifshits@intel.com/mbox/", "series": [ { "id": 175437, "url": "http://patchwork.ozlabs.org/api/series/175437/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=175437", "date": "2020-05-07T17:14:06", "name": "[v1] e1000e: disable s0ix entry and exit flows for ME systems", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/175437/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1285511/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1285511/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49J0S61zkYz9sNH\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 8 May 2020 03:14:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5781E895FA;\n\tThu, 7 May 2020 17:14:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cD89CzCipx7o; Thu, 7 May 2020 17:14:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8BF068961C;\n\tThu, 7 May 2020 17:14:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 2F32F1BF3FB\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 17:14:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 279648821C\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 17:14:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id lTJbu+e4QF1R for <intel-wired-lan@lists.osuosl.org>;\n Thu, 7 May 2020 17:14:09 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by whitealder.osuosl.org (Postfix) with ESMTPS id C892A87657\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 17:14:09 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2020 10:14:08 -0700", "from ccdlinuxdev08.iil.intel.com ([143.185.160.195])\n by orsmga005.jf.intel.com with ESMTP; 07 May 2020 10:14:07 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n 4mJWDnTaZqHunYcivZm3YJk+TNEPNSXTSk1Bk4ylTHH5XPb5qddyv5PlJ1FpjtasAn2Fj0p8O7\n TLPZK78t1znA==", "\n u1YtYqtSHDHoAkROu7cVcz/77wgd4MHWh9AGIiEvSDjIboa3EudiA7pDi4V8ZqL0xVcF2zV9pz\n EmhTCNPjvZhg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,364,1583222400\"; d=\"scan'208\";a=\"435365762\"", "From": "Vitaly Lifshits <vitaly.lifshits@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 May 2020 20:14:06 +0300", "Message-Id": "<20200507171406.6883-1-vitaly.lifshits@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1] e1000e: disable s0ix entry and exit\n flows for ME systems", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Since ME systems do not support SLP_S0 in S0ix state, and S0ix entry\nand exit flows may cause errors on them it is best to avoid using\ne1000e_s0ix_entry_flow and e1000e_s0ix_exit_flow functions.\n\nThis was done by creating a struct of all devices that comes with ME\nand by checking if the current device has ME.\n\nSigned-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 45 ++++++++++++++++++++++++++++--\n 1 file changed, 43 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex e0b074820b47..57af6b81d79d 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -107,6 +107,45 @@ static const struct e1000_reg_info e1000_reg_info_tbl[] = {\n \t{0, NULL}\n };\n \n+struct e1000e_me_supported {\n+\tu16 device_id;\t\t/* supported device ID */\n+};\n+\n+static const struct e1000e_me_supported me_supported[] = {\n+\t{E1000_DEV_ID_PCH_LPT_I217_LM},\n+\t{E1000_DEV_ID_PCH_LPTLP_I218_LM},\n+\t{E1000_DEV_ID_PCH_I218_LM2},\n+\t{E1000_DEV_ID_PCH_I218_LM3},\n+\t{E1000_DEV_ID_PCH_SPT_I219_LM},\n+\t{E1000_DEV_ID_PCH_SPT_I219_LM2},\n+\t{E1000_DEV_ID_PCH_LBG_I219_LM3},\n+\t{E1000_DEV_ID_PCH_SPT_I219_LM4},\n+\t{E1000_DEV_ID_PCH_SPT_I219_LM5},\n+\t{E1000_DEV_ID_PCH_CNP_I219_LM6},\n+\t{E1000_DEV_ID_PCH_CNP_I219_LM7},\n+\t{E1000_DEV_ID_PCH_ICP_I219_LM8},\n+\t{E1000_DEV_ID_PCH_ICP_I219_LM9},\n+\t{E1000_DEV_ID_PCH_CMP_I219_LM10},\n+\t{E1000_DEV_ID_PCH_CMP_I219_LM11},\n+\t{E1000_DEV_ID_PCH_CMP_I219_LM12},\n+\t{E1000_DEV_ID_PCH_TGP_I219_LM13},\n+\t{E1000_DEV_ID_PCH_TGP_I219_LM14},\n+\t{E1000_DEV_ID_PCH_TGP_I219_LM15},\n+\t{0}\n+};\n+\n+static bool e1000e_check_me(u16 device_id)\n+{\n+\tstruct e1000e_me_supported *id;\n+\n+\tfor (id = (struct e1000e_me_supported *)me_supported;\n+\t id->device_id; id++)\n+\t\tif (device_id == id->device_id)\n+\t\t\treturn true;\n+\n+\treturn false;\n+}\n+\n /**\n * __ew32_prepare - prepare to write to MAC CSR register on certain parts\n * @hw: pointer to the HW structure\n@@ -6912,7 +6951,8 @@ static int e1000e_pm_suspend(struct device *dev)\n \t\te1000e_pm_thaw(dev);\n \n \t/* Introduce S0ix implementation */\n-\tif (hw->mac.type >= e1000_pch_cnp)\n+\tif (hw->mac.type >= e1000_pch_cnp &&\n+\t !e1000e_check_me(hw->adapter->pdev->device))\n \t\te1000e_s0ix_entry_flow(adapter);\n \n \treturn rc;\n@@ -6927,7 +6967,8 @@ static int e1000e_pm_resume(struct device *dev)\n \tint rc;\n \n \t/* Introduce S0ix implementation */\n-\tif (hw->mac.type >= e1000_pch_cnp)\n+\tif (hw->mac.type >= e1000_pch_cnp &&\n+\t !e1000e_check_me(hw->adapter->pdev->device))\n \t\te1000e_s0ix_exit_flow(adapter);\n \n \trc = __e1000_resume(pdev);\n", "prefixes": [ "v1" ] }