Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1285356/?format=api
{ "id": 1285356, "url": "http://patchwork.ozlabs.org/api/patches/1285356/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507142108.13090-1-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200507142108.13090-1-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2020-05-07T14:21:07", "name": "e1000e: Disable TSO for buffer overrun workaround", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "579d864f6d02292742bf8aafcc1aa384acfb4ef7", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507142108.13090-1-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 175381, "url": "http://patchwork.ozlabs.org/api/series/175381/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=175381", "date": "2020-05-07T14:21:07", "name": "e1000e: Disable TSO for buffer overrun workaround", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/175381/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1285356/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1285356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49Hwcs3gYMz9sSt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 8 May 2020 00:21:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DD9F6873E9;\n\tThu, 7 May 2020 14:21:31 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ey6L06UbHHCt; Thu, 7 May 2020 14:21:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2CBF7873F2;\n\tThu, 7 May 2020 14:21:30 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id CC7101BF34B\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 14:21:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id C661B88564\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 14:21:28 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id lns7xO9uJtc8 for <intel-wired-lan@lists.osuosl.org>;\n Thu, 7 May 2020 14:21:25 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n [91.189.89.112])\n by whitealder.osuosl.org (Postfix) with ESMTPS id BF51C8855D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 14:21:25 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n helo=localhost) by youngberry.canonical.com with esmtpsa\n (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n (envelope-from <kai.heng.feng@canonical.com>)\n id 1jWhOn-00036d-BO; Thu, 07 May 2020 14:21:17 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Thu, 7 May 2020 22:21:07 +0800", "Message-Id": "<20200507142108.13090-1-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Disable TSO for buffer overrun\n workaround", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"open list:NETWORKING DRIVERS\" <netdev@vger.kernel.org>,\n open list <linux-kernel@vger.kernel.org>,\n Kai-Heng Feng <kai.heng.feng@canonical.com>,\n \"moderated list:INTEL ETHERNET DRIVERS\" <intel-wired-lan@lists.osuosl.org>,\n Dima Ruinskiy <dima.ruinskiy@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit b10effb92e27 (\"e1000e: fix buffer overrun while the I219 is\nprocessing DMA transactions\") imposes roughly 30% performance penalty.\n\nThe commit log states that \"Disabling TSO eliminates performance loss\nfor TCP traffic without a noticeable impact on CPU performance\", so\nlet's disable TSO by default to regain the loss.\n\nFixes: b10effb92e27 (\"e1000e: fix buffer overrun while the I219 is processing DMA transactions\")\nBugLink: https://bugs.launchpad.net/bugs/1802691\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 177c6da80c57..9b5509149578 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -5294,6 +5294,10 @@ static void e1000_watchdog_task(struct work_struct *work)\n \t\t\t\t\t/* oops */\n \t\t\t\t\tbreak;\n \t\t\t\t}\n+\t\t\t\tif (hw->mac.type == e1000_pch_spt) {\n+\t\t\t\t\tnetdev->features &= ~NETIF_F_TSO;\n+\t\t\t\t\tnetdev->features &= ~NETIF_F_TSO6;\n+\t\t\t\t}\n \t\t\t}\n \n \t\t\t/* enable transmits in the hardware, need to do this\n", "prefixes": [] }