Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1285153/?format=api
{ "id": 1285153, "url": "http://patchwork.ozlabs.org/api/patches/1285153/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507110915.38349-1-yanaijie@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200507110915.38349-1-yanaijie@huawei.com>", "list_archive_url": null, "date": "2020-05-07T11:09:15", "name": "[net-next] igb: make igb_set_fc_watermarks() return void", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e20b1fdd904a2ca3f4b19fd652262fc1f9cf1fd9", "submitter": { "id": 71145, "url": "http://patchwork.ozlabs.org/api/people/71145/?format=api", "name": "Jason Yan", "email": "yanaijie@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507110915.38349-1-yanaijie@huawei.com/mbox/", "series": [ { "id": 175314, "url": "http://patchwork.ozlabs.org/api/series/175314/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=175314", "date": "2020-05-07T11:09:15", "name": "[net-next] igb: make igb_set_fc_watermarks() return void", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/175314/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1285153/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1285153/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huawei.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49HrN53HdBz9sSg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 7 May 2020 21:10:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 85E6E873B6;\n\tThu, 7 May 2020 11:10:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dOysaWQkAS2W; Thu, 7 May 2020 11:10:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 68DCB87FBF;\n\tThu, 7 May 2020 11:10:09 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 00B8C1BF575\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 11:10:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id ED36787069\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 11:10:07 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 9rtxZcrpxnZ0 for <intel-wired-lan@lists.osuosl.org>;\n Thu, 7 May 2020 11:10:07 +0000 (UTC)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 722C486DC2\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 11:10:06 +0000 (UTC)", "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])\n by Forcepoint Email with ESMTP id B08031ABE3B00C9375E2;\n Thu, 7 May 2020 19:10:01 +0800 (CST)", "from huawei.com (10.175.124.28) by DGGEMS412-HUB.china.huawei.com\n (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Thu, 7 May 2020\n 19:09:54 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Jason Yan <yanaijie@huawei.com>", "To": "<jeffrey.t.kirsher@intel.com>, <davem@davemloft.net>,\n <yanaijie@huawei.com>, <intel-wired-lan@lists.osuosl.org>,\n <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>", "Date": "Thu, 7 May 2020 19:09:15 +0800", "Message-ID": "<20200507110915.38349-1-yanaijie@huawei.com>", "X-Mailer": "git-send-email 2.21.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.175.124.28]", "X-CFilter-Loop": "Reflected", "Subject": "[Intel-wired-lan] [PATCH net-next] igb: make\n igb_set_fc_watermarks() return void", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This function always return 0 now, we can make it return void to\nsimplify the code. This fixes the following coccicheck warning:\n\ndrivers/net/ethernet/intel/igb/e1000_mac.c:728:5-12: Unneeded variable:\n\"ret_val\". Return \"0\" on line 751\n\nSigned-off-by: Jason Yan <yanaijie@huawei.com>\n---\n drivers/net/ethernet/intel/igb/e1000_mac.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c\nindex 79ee0a747260..3254737c07a3 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_mac.c\n+++ b/drivers/net/ethernet/intel/igb/e1000_mac.c\n@@ -12,7 +12,7 @@\n #include \"igb.h\"\n \n static s32 igb_set_default_fc(struct e1000_hw *hw);\n-static s32 igb_set_fc_watermarks(struct e1000_hw *hw);\n+static void igb_set_fc_watermarks(struct e1000_hw *hw);\n \n /**\n * igb_get_bus_info_pcie - Get PCIe bus information\n@@ -687,7 +687,7 @@ s32 igb_setup_link(struct e1000_hw *hw)\n \n \twr32(E1000_FCTTV, hw->fc.pause_time);\n \n-\tret_val = igb_set_fc_watermarks(hw);\n+\tigb_set_fc_watermarks(hw);\n \n out:\n \n@@ -723,9 +723,8 @@ void igb_config_collision_dist(struct e1000_hw *hw)\n * flow control XON frame transmission is enabled, then set XON frame\n * tansmission as well.\n **/\n-static s32 igb_set_fc_watermarks(struct e1000_hw *hw)\n+static void igb_set_fc_watermarks(struct e1000_hw *hw)\n {\n-\ts32 ret_val = 0;\n \tu32 fcrtl = 0, fcrth = 0;\n \n \t/* Set the flow control receive threshold registers. Normally,\n@@ -747,8 +746,6 @@ static s32 igb_set_fc_watermarks(struct e1000_hw *hw)\n \t}\n \twr32(E1000_FCRTL, fcrtl);\n \twr32(E1000_FCRTH, fcrth);\n-\n-\treturn ret_val;\n }\n \n /**\n", "prefixes": [ "net-next" ] }