Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1284969/?format=api
{ "id": 1284969, "url": "http://patchwork.ozlabs.org/api/patches/1284969/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507062545.15461-1-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200507062545.15461-1-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2020-05-07T06:25:45", "name": "e1000e: Warn if disabling ULP failed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "766f1a483ef4f29292a2cd07f651594187b9dae3", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200507062545.15461-1-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 175243, "url": "http://patchwork.ozlabs.org/api/series/175243/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=175243", "date": "2020-05-07T06:25:45", "name": "e1000e: Warn if disabling ULP failed", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/175243/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1284969/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1284969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=canonical.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49Hk5r1H6Fz9sSW\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 7 May 2020 16:27:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C3D5E88051;\n\tThu, 7 May 2020 06:27:24 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QTAPJDc9QdPP; Thu, 7 May 2020 06:27:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E0D8387EC5;\n\tThu, 7 May 2020 06:27:22 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id E80001BF41D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 06:27:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id DB1B720780\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 06:27:21 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id XRv4rhD0k1Xi for <intel-wired-lan@lists.osuosl.org>;\n Thu, 7 May 2020 06:27:20 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n [91.189.89.112])\n by silver.osuosl.org (Postfix) with ESMTPS id A134B2076E\n for <intel-wired-lan@lists.osuosl.org>; Thu, 7 May 2020 06:27:20 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n helo=localhost) by youngberry.canonical.com with esmtpsa\n (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n (envelope-from <kai.heng.feng@canonical.com>)\n id 1jWZyi-0000tF-64; Thu, 07 May 2020 06:25:52 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Thu, 7 May 2020 14:25:45 +0800", "Message-Id": "<20200507062545.15461-1-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Warn if disabling ULP failed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"open list:NETWORKING DRIVERS\" <netdev@vger.kernel.org>,\n Kai-Heng Feng <kai.heng.feng@canonical.com>,\n \"moderated list:INTEL ETHERNET DRIVERS\" <intel-wired-lan@lists.osuosl.org>,\n \"David S. Miller\" <davem@davemloft.net>,\n open list <linux-kernel@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The hardware may stop working if driver failed to disable ULP mode.\n\nTake the return value of e1000_disable_ulp_lpt_lp() into account, and\npass up the error if it fails.\n\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 15f6c0a4dc63..9cbd2d6c7da4 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -300,7 +300,11 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw)\n \t * so forcibly disable it.\n \t */\n \thw->dev_spec.ich8lan.ulp_state = e1000_ulp_state_unknown;\n-\te1000_disable_ulp_lpt_lp(hw, true);\n+\tret_val = e1000_disable_ulp_lpt_lp(hw, true);\n+\tif (ret_val) {\n+\t\te_warn(\"Failed to disable ULP\\n\");\n+\t\tgoto out;\n+\t}\n \n \tret_val = hw->phy.ops.acquire(hw);\n \tif (ret_val) {\n", "prefixes": [] }