Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1283193/?format=api
{ "id": 1283193, "url": "http://patchwork.ozlabs.org/api/patches/1283193/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200505024521.24635-1-xiexiuqi@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200505024521.24635-1-xiexiuqi@huawei.com>", "list_archive_url": null, "date": "2020-05-05T02:45:21", "name": "[net-next] ixgbe: fix signed-integer-overflow warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a5ac763d5b1974915e51f02ce15dc2d924538a71", "submitter": { "id": 24815, "url": "http://patchwork.ozlabs.org/api/people/24815/?format=api", "name": "Xie XiuQi", "email": "xiexiuqi@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200505024521.24635-1-xiexiuqi@huawei.com/mbox/", "series": [ { "id": 174654, "url": "http://patchwork.ozlabs.org/api/series/174654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=174654", "date": "2020-05-05T02:45:21", "name": "[net-next] ixgbe: fix signed-integer-overflow warning", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/174654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1283193/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1283193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huawei.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49GPD02R5Vz9sSx\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 May 2020 12:43:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4488B89401;\n\tTue, 5 May 2020 02:43:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aD+RMRjUghDp; Tue, 5 May 2020 02:43:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 57D1C893EB;\n\tTue, 5 May 2020 02:43:08 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by ash.osuosl.org (Postfix) with ESMTP id A24C41BF3CC\n for <intel-wired-lan@lists.osuosl.org>; Tue, 5 May 2020 02:41:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by silver.osuosl.org (Postfix) with ESMTP id 92DAC2049C\n for <intel-wired-lan@lists.osuosl.org>; Tue, 5 May 2020 02:41:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id zpnaqu7HcfTJ for <intel-wired-lan@lists.osuosl.org>;\n Tue, 5 May 2020 02:41:22 +0000 (UTC)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by silver.osuosl.org (Postfix) with ESMTPS id 4041A20412\n for <intel-wired-lan@lists.osuosl.org>; Tue, 5 May 2020 02:41:22 +0000 (UTC)", "from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59])\n by Forcepoint Email with ESMTP id 69B3EA10E30D01918601;\n Tue, 5 May 2020 10:41:16 +0800 (CST)", "from localhost.localdomain.localdomain (10.175.113.25) by\n DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id\n 14.3.487.0; Tue, 5 May 2020 10:41:10 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Xie XiuQi <xiexiuqi@huawei.com>", "To": "<jeffrey.t.kirsher@intel.com>, <davem@davemloft.net>", "Date": "Tue, 5 May 2020 10:45:21 +0800", "Message-ID": "<20200505024521.24635-1-xiexiuqi@huawei.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.175.113.25]", "X-CFilter-Loop": "Reflected", "X-Mailman-Approved-At": "Tue, 05 May 2020 02:43:07 +0000", "Subject": "[Intel-wired-lan] [PATCH net-next] ixgbe: fix\n signed-integer-overflow warning", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ubsan report this warning, fix it by adding a unsigned suffix.\n\nUBSAN: signed-integer-overflow in\ndrivers/net/ethernet/intel/ixgbe/ixgbe_common.c:2246:26\n65535 * 65537 cannot be represented in type 'int'\nCPU: 21 PID: 7 Comm: kworker/u256:0 Not tainted 5.7.0-rc3-debug+ #39\nHardware name: Huawei TaiShan 2280 V2/BC82AMDC, BIOS 2280-V2 03/27/2020\nWorkqueue: ixgbe ixgbe_service_task [ixgbe]\nCall trace:\n dump_backtrace+0x0/0x3f0\n show_stack+0x28/0x38\n dump_stack+0x154/0x1e4\n ubsan_epilogue+0x18/0x60\n handle_overflow+0xf8/0x148\n __ubsan_handle_mul_overflow+0x34/0x48\n ixgbe_fc_enable_generic+0x4d0/0x590 [ixgbe]\n ixgbe_service_task+0xc20/0x1f78 [ixgbe]\n process_one_work+0x8f0/0xf18\n worker_thread+0x430/0x6d0\n kthread+0x218/0x238\n ret_from_fork+0x10/0x18\n\nReported-by: Hulk Robot <hulkci@huawei.com>\nSigned-off-by: Xie XiuQi <xiexiuqi@huawei.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\nindex 0bd1294ba517..39c5e6fdb72c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c\n@@ -2243,7 +2243,7 @@ s32 ixgbe_fc_enable_generic(struct ixgbe_hw *hw)\n \t}\n \n \t/* Configure pause time (2 TCs per register) */\n-\treg = hw->fc.pause_time * 0x00010001;\n+\treg = hw->fc.pause_time * 0x00010001U;\n \tfor (i = 0; i < (MAX_TRAFFIC_CLASS / 2); i++)\n \t\tIXGBE_WRITE_REG(hw, IXGBE_FCTTV(i), reg);\n \n", "prefixes": [ "net-next" ] }