Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1276672/?format=api
{ "id": 1276672, "url": "http://patchwork.ozlabs.org/api/patches/1276672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200424201623.10971-16-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200424201623.10971-16-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-04-24T20:16:19", "name": "[15/19] igc: Fix NFC rules leak when driver is unloaded", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0d6a1eb7b9f6fda86c5bd65c2402d111113d3920", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200424201623.10971-16-andre.guedes@intel.com/mbox/", "series": [ { "id": 172579, "url": "http://patchwork.ozlabs.org/api/series/172579/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=172579", "date": "2020-04-24T20:16:07", "name": "igc: Fixes to NFC support code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/172579/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1276672/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1276672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49857q6Dd7z9sSd\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2020 06:17:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 42852868A9;\n\tFri, 24 Apr 2020 20:17:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mUstwowf0FTz; Fri, 24 Apr 2020 20:17:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BB6C386B59;\n\tFri, 24 Apr 2020 20:17:41 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by ash.osuosl.org (Postfix) with ESMTP id 82DC01BF83C\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by whitealder.osuosl.org (Postfix) with ESMTP id 7E38C87FCC\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:32 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Fw8feYW3Difg for <intel-wired-lan@lists.osuosl.org>;\n Fri, 24 Apr 2020 20:17:30 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by whitealder.osuosl.org (Postfix) with ESMTPS id 804DB87FEA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:29 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2020 13:17:28 -0700", "from kleandre-mobl.amr.corp.intel.com ([10.213.164.39])\n by orsmga001.jf.intel.com with ESMTP; 24 Apr 2020 13:17:28 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n a052hZaPiZxAAHebYHCd0mHJvAAHnCyVUHhBXRtxQHzJtmuVqpPsVZd+J3nq4K1FHGbMhLelum\n eTti8C2vFPvw==", "\n 83t1QgCc8hTmTpFWXZnOYcC5WVaJkaEXN3S5LmvTtdJ+JKnLnQ0DiMtizpm+4HDQuvtSPbjHx2\n 1P+SkmfgGHtQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,313,1583222400\"; d=\"scan'208\";a=\"335474522\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 24 Apr 2020 13:16:19 -0700", "Message-Id": "<20200424201623.10971-16-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200424201623.10971-1-andre.guedes@intel.com>", "References": "<20200424201623.10971-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 15/19] igc: Fix NFC rules leak when driver\n is unloaded", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "If we have RFC rules in adapter->nfc_rule_list when the IGC driver\nis unloaded, all rules are leaked. This patch fixes the issue by\nintroducing the helper igc_flush_nfc_rules() and calling it in\nigc_remove(). It also updates igc_set_features() so is reuses the\nnew helper instead of re-implementing it.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 29 +++++++++++++----------\n 1 file changed, 16 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex e09d74331257..64e372f38c6b 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -2545,6 +2545,18 @@ void igc_del_nfc_rule(struct igc_adapter *adapter, struct igc_nfc_rule *rule)\n \tkfree(rule);\n }\n \n+static void igc_flush_nfc_rules(struct igc_adapter *adapter)\n+{\n+\tstruct igc_nfc_rule *rule, *tmp;\n+\n+\tspin_lock(&adapter->nfc_rule_lock);\n+\n+\tlist_for_each_entry_safe(rule, tmp, &adapter->nfc_rule_list, list)\n+\t\tigc_del_nfc_rule(adapter, rule);\n+\n+\tspin_unlock(&adapter->nfc_rule_lock);\n+}\n+\n /**\n * igc_add_nfc_rule() - Add NFC rule.\n * @adapter: Pointer to adapter.\n@@ -3968,19 +3980,8 @@ static int igc_set_features(struct net_device *netdev,\n \tif (!(changed & (NETIF_F_RXALL | NETIF_F_NTUPLE)))\n \t\treturn 0;\n \n-\tif (!(features & NETIF_F_NTUPLE)) {\n-\t\tstruct igc_nfc_rule *rule, *tmp;\n-\n-\t\tspin_lock(&adapter->nfc_rule_lock);\n-\t\tlist_for_each_entry_safe(rule, tmp,\n-\t\t\t\t\t &adapter->nfc_rule_list, list) {\n-\t\t\tigc_disable_nfc_rule(adapter, rule);\n-\t\t\tlist_del(&rule->list);\n-\t\t\tkfree(rule);\n-\t\t}\n-\t\tspin_unlock(&adapter->nfc_rule_lock);\n-\t\tadapter->nfc_rule_count = 0;\n-\t}\n+\tif (!(features & NETIF_F_NTUPLE))\n+\t\tigc_flush_nfc_rules(adapter);\n \n \tnetdev->features = features;\n \n@@ -5250,6 +5251,8 @@ static void igc_remove(struct pci_dev *pdev)\n \n \tpm_runtime_get_noresume(&pdev->dev);\n \n+\tigc_flush_nfc_rules(adapter);\n+\n \tigc_ptp_stop(adapter);\n \n \tset_bit(__IGC_DOWN, &adapter->state);\n", "prefixes": [ "15/19" ] }