Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1276660/?format=api
{ "id": 1276660, "url": "http://patchwork.ozlabs.org/api/patches/1276660/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200424201623.10971-4-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200424201623.10971-4-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-04-24T20:16:07", "name": "[03/19] igc: Cleanup _get|set_rxnfc ethtool ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "492fec8631327d227895ca59fa1a145683128cc8", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200424201623.10971-4-andre.guedes@intel.com/mbox/", "series": [ { "id": 172579, "url": "http://patchwork.ozlabs.org/api/series/172579/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=172579", "date": "2020-04-24T20:16:07", "name": "igc: Fixes to NFC support code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/172579/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1276660/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1276660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49857c3V2Cz9sSJ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2020 06:17:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9157B87FD6;\n\tFri, 24 Apr 2020 20:17:28 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tp-HH+NRGCzT; Fri, 24 Apr 2020 20:17:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9926B87847;\n\tFri, 24 Apr 2020 20:17:27 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 4DD4F1BF9C2\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 4AC17868BC\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Q0zMax_lpK7N for <intel-wired-lan@lists.osuosl.org>;\n Fri, 24 Apr 2020 20:17:25 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id C59CC86B59\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2020 20:17:25 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2020 13:17:25 -0700", "from kleandre-mobl.amr.corp.intel.com ([10.213.164.39])\n by orsmga001.jf.intel.com with ESMTP; 24 Apr 2020 13:17:25 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n WiCtfAgP8/BY2H/RZNFIHkD4plnjm/qhjpJl5Fb1H0qXak87R+l6D2BzT/jg1xAesLfvvUUnNe\n vQuejrHcVBfw==", "\n ivaEIbqkFpE9S+7GVndo4I/GRzp8CXUgT1/4M0VpPR676mlvOPSdrX71PYtS2DgUObntqyjEW5\n WSYz+N3WWByA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,313,1583222400\"; d=\"scan'208\";a=\"335474503\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 24 Apr 2020 13:16:07 -0700", "Message-Id": "<20200424201623.10971-4-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200424201623.10971-1-andre.guedes@intel.com>", "References": "<20200424201623.10971-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 03/19] igc: Cleanup _get|set_rxnfc ethtool\n ops", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch does a trivial change in igc_ethtool_get_rxnfc() and\nigc_ethtool_set_rxnfc() to simplify their logic.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 33 ++++++--------------\n 1 file changed, 10 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex ee2563ef24ac..c67c3ead323f 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -1055,31 +1055,23 @@ static int igc_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,\n \t\t\t u32 *rule_locs)\n {\n \tstruct igc_adapter *adapter = netdev_priv(dev);\n-\tint ret = -EOPNOTSUPP;\n \n \tswitch (cmd->cmd) {\n \tcase ETHTOOL_GRXRINGS:\n \t\tcmd->data = adapter->num_rx_queues;\n-\t\tret = 0;\n-\t\tbreak;\n+\t\treturn 0;\n \tcase ETHTOOL_GRXCLSRLCNT:\n \t\tcmd->rule_cnt = adapter->nfc_filter_count;\n-\t\tret = 0;\n-\t\tbreak;\n+\t\treturn 0;\n \tcase ETHTOOL_GRXCLSRULE:\n-\t\tret = igc_get_ethtool_nfc_entry(adapter, cmd);\n-\t\tbreak;\n+\t\treturn igc_get_ethtool_nfc_entry(adapter, cmd);\n \tcase ETHTOOL_GRXCLSRLALL:\n-\t\tret = igc_get_ethtool_nfc_all(adapter, cmd, rule_locs);\n-\t\tbreak;\n+\t\treturn igc_get_ethtool_nfc_all(adapter, cmd, rule_locs);\n \tcase ETHTOOL_GRXFH:\n-\t\tret = igc_get_rss_hash_opts(adapter, cmd);\n-\t\tbreak;\n+\t\treturn igc_get_rss_hash_opts(adapter, cmd);\n \tdefault:\n-\t\tbreak;\n+\t\treturn -EOPNOTSUPP;\n \t}\n-\n-\treturn ret;\n }\n \n #define UDP_RSS_FLAGS (IGC_FLAG_RSS_FIELD_IPV4_UDP | \\\n@@ -1418,22 +1410,17 @@ static int igc_del_ethtool_nfc_entry(struct igc_adapter *adapter,\n static int igc_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)\n {\n \tstruct igc_adapter *adapter = netdev_priv(dev);\n-\tint ret = -EOPNOTSUPP;\n \n \tswitch (cmd->cmd) {\n \tcase ETHTOOL_SRXFH:\n-\t\tret = igc_set_rss_hash_opt(adapter, cmd);\n-\t\tbreak;\n+\t\treturn igc_set_rss_hash_opt(adapter, cmd);\n \tcase ETHTOOL_SRXCLSRLINS:\n-\t\tret = igc_add_ethtool_nfc_entry(adapter, cmd);\n-\t\tbreak;\n+\t\treturn igc_add_ethtool_nfc_entry(adapter, cmd);\n \tcase ETHTOOL_SRXCLSRLDEL:\n-\t\tret = igc_del_ethtool_nfc_entry(adapter, cmd);\n+\t\treturn igc_del_ethtool_nfc_entry(adapter, cmd);\n \tdefault:\n-\t\tbreak;\n+\t\treturn -EOPNOTSUPP;\n \t}\n-\n-\treturn ret;\n }\n \n void igc_write_rss_indir_tbl(struct igc_adapter *adapter)\n", "prefixes": [ "03/19" ] }