Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1273720/?format=api
{ "id": 1273720, "url": "http://patchwork.ozlabs.org/api/patches/1273720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200420123506.7716-1-yanaijie@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200420123506.7716-1-yanaijie@huawei.com>", "list_archive_url": null, "date": "2020-04-20T12:35:06", "name": "e1000: remove unneeded conversion to bool", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9f321aec358eed1d3f17b25b472fafd3cebe2333", "submitter": { "id": 71145, "url": "http://patchwork.ozlabs.org/api/people/71145/?format=api", "name": "Jason Yan", "email": "yanaijie@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200420123506.7716-1-yanaijie@huawei.com/mbox/", "series": [ { "id": 171536, "url": "http://patchwork.ozlabs.org/api/series/171536/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=171536", "date": "2020-04-20T12:35:06", "name": "e1000: remove unneeded conversion to bool", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/171536/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1273720/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1273720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huawei.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 495dgw1HwGz9sP7\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2020 06:33:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B08D087886;\n\tMon, 20 Apr 2020 20:33:30 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zu1YSNP1VMVg; Mon, 20 Apr 2020 20:33:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6864B87885;\n\tMon, 20 Apr 2020 20:33:27 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 6DB711BF29F\n for <intel-wired-lan@lists.osuosl.org>; Mon, 20 Apr 2020 12:08:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 69D7B85CAA\n for <intel-wired-lan@lists.osuosl.org>; Mon, 20 Apr 2020 12:08:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id LDj4F4RZFFfC for <intel-wired-lan@lists.osuosl.org>;\n Mon, 20 Apr 2020 12:08:34 +0000 (UTC)", "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id EEC5B85C86\n for <intel-wired-lan@lists.osuosl.org>; Mon, 20 Apr 2020 12:08:33 +0000 (UTC)", "from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id C46F9895216008B9E491;\n Mon, 20 Apr 2020 20:08:30 +0800 (CST)", "from huawei.com (10.175.124.28) by DGGEMS414-HUB.china.huawei.com\n (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 20 Apr 2020\n 20:08:24 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Jason Yan <yanaijie@huawei.com>", "To": "<jeffrey.t.kirsher@intel.com>, <davem@davemloft.net>,\n <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,\n <linux-kernel@vger.kernel.org>", "Date": "Mon, 20 Apr 2020 20:35:06 +0800", "Message-ID": "<20200420123506.7716-1-yanaijie@huawei.com>", "X-Mailer": "git-send-email 2.21.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.175.124.28]", "X-CFilter-Loop": "Reflected", "X-Mailman-Approved-At": "Mon, 20 Apr 2020 20:33:26 +0000", "Subject": "[Intel-wired-lan] [PATCH] e1000: remove unneeded conversion to bool", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jason Yan <yanaijie@huawei.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The '==' expression itself is bool, no need to convert it to bool again.\nThis fixes the following coccicheck warning:\n\ndrivers/net/ethernet/intel/e1000/e1000_main.c:1479:44-49: WARNING:\nconversion to bool not needed here\n\nSigned-off-by: Jason Yan <yanaijie@huawei.com>\n---\n drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c\nindex ac5146d53c4c..05bc6e216bca 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_main.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c\n@@ -1476,7 +1476,7 @@ static bool e1000_check_64k_bound(struct e1000_adapter *adapter, void *start,\n \tif (hw->mac_type == e1000_82545 ||\n \t hw->mac_type == e1000_ce4100 ||\n \t hw->mac_type == e1000_82546) {\n-\t\treturn ((begin ^ (end - 1)) >> 16) != 0 ? false : true;\n+\t\treturn ((begin ^ (end - 1)) >> 16) == 0;\n \t}\n \n \treturn true;\n", "prefixes": [] }