Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1269866/?format=api
{ "id": 1269866, "url": "http://patchwork.ozlabs.org/api/patches/1269866/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200413160049.35565-1-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200413160049.35565-1-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-04-13T16:00:50", "name": "[v2,4/4] igc: Enable NFC rules based source MAC address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f251c8b294a4a4070c9561b19ca021eeac5542b8", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200413160049.35565-1-andre.guedes@intel.com/mbox/", "series": [ { "id": 169977, "url": "http://patchwork.ozlabs.org/api/series/169977/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=169977", "date": "2020-04-13T16:00:50", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/169977/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1269866/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1269866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 491D1r2GMhz9sSM\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2020 02:03:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0DF5987924;\n\tMon, 13 Apr 2020 16:03:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mpz6BYyWGhdE; Mon, 13 Apr 2020 16:03:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 38A9C8788B;\n\tMon, 13 Apr 2020 16:03:41 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 434EC1BF318\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2020 16:03:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by fraxinus.osuosl.org (Postfix) with ESMTP id 3E9A784BB6\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2020 16:03:39 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id b2C492RVSUIk for <intel-wired-lan@lists.osuosl.org>;\n Mon, 13 Apr 2020 16:03:38 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by fraxinus.osuosl.org (Postfix) with ESMTPS id 70C9284B80\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2020 16:03:38 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2020 09:03:37 -0700", "from ksmartin-mobl.amr.corp.intel.com ([10.251.159.43])\n by fmsmga001.fm.intel.com with ESMTP; 13 Apr 2020 09:03:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "\n W1trFFcnjGHQDpIQNkvJKyFViWEN+nH4P48bpL3owRdg3BF86O9lvHXnmdUzKL89Euy7HRhxcr\n HosFg061jzgA==", "\n OJ7hfBNb7qKmWKNuRZ2KP93nWeRlQ1/XACD6ALlklZCHw0jD1/npgU8lwbQoTGmaxlJoRCywO6\n cgbmQuRc/87w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,378,1580803200\"; d=\"scan'208\";a=\"363107775\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 13 Apr 2020 09:00:50 -0700", "Message-Id": "<20200413160049.35565-1-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200411002834.13916-5-andre.guedes@intel.com>", "References": "<20200411002834.13916-5-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2 4/4] igc: Enable NFC rules based source\n MAC address", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch adds support for Network Flow Classification (NFC) rules\nbased on source MAC address. Note that the controller doesn't support\nrules with both source and destination addresses set, so this special\ncase is checked in igc_add_ethtool_nfc_entry().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\nv2: Fix memory leak when both dst and src are set.\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 32 ++++++++++++++------\n 1 file changed, 22 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 20d22df52f09..9023dc2a2446 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -1188,16 +1188,8 @@ static int igc_set_rss_hash_opt(struct igc_adapter *adapter,\n \n int igc_add_filter(struct igc_adapter *adapter, struct igc_nfc_filter *input)\n {\n-\tstruct igc_hw *hw = &adapter->hw;\n \tint err = -EINVAL;\n \n-\tif (hw->mac.type == igc_i225 &&\n-\t !(input->filter.match_flags & ~IGC_FILTER_FLAG_SRC_MAC_ADDR)) {\n-\t\tnetdev_err(adapter->netdev,\n-\t\t\t \"i225 doesn't support flow classification rules specifying only source addresses\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n \tif (input->filter.match_flags & IGC_FILTER_FLAG_ETHER_TYPE) {\n \t\tu16 etype = ntohs(input->filter.etype);\n \n@@ -1206,6 +1198,14 @@ int igc_add_filter(struct igc_adapter *adapter, struct igc_nfc_filter *input)\n \t\t\treturn err;\n \t}\n \n+\tif (input->filter.match_flags & IGC_FILTER_FLAG_SRC_MAC_ADDR) {\n+\t\terr = igc_add_mac_filter(adapter, IGC_MAC_FILTER_TYPE_SRC,\n+\t\t\t\t\t input->filter.src_addr,\n+\t\t\t\t\t input->action);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n+\n \tif (input->filter.match_flags & IGC_FILTER_FLAG_DST_MAC_ADDR) {\n \t\terr = igc_add_mac_filter(adapter, IGC_MAC_FILTER_TYPE_DST,\n \t\t\t\t\t input->filter.dst_addr,\n@@ -1239,6 +1239,10 @@ int igc_erase_filter(struct igc_adapter *adapter, struct igc_nfc_filter *input)\n \t\tigc_del_vlan_prio_filter(adapter, prio);\n \t}\n \n+\tif (input->filter.match_flags & IGC_FILTER_FLAG_SRC_MAC_ADDR)\n+\t\tigc_del_mac_filter(adapter, IGC_MAC_FILTER_TYPE_SRC,\n+\t\t\t\t input->filter.src_addr);\n+\n \tif (input->filter.match_flags & IGC_FILTER_FLAG_DST_MAC_ADDR)\n \t\tigc_del_mac_filter(adapter, IGC_MAC_FILTER_TYPE_DST,\n \t\t\t\t input->filter.dst_addr);\n@@ -1334,20 +1338,28 @@ static int igc_add_ethtool_nfc_entry(struct igc_adapter *adapter,\n \t\tinput->filter.match_flags = IGC_FILTER_FLAG_ETHER_TYPE;\n \t}\n \n-\t/* Only support matching addresses by the full mask */\n+\t/* Both source and destination address filters only support the full\n+\t * mask.\n+\t */\n \tif (is_broadcast_ether_addr(fsp->m_u.ether_spec.h_source)) {\n \t\tinput->filter.match_flags |= IGC_FILTER_FLAG_SRC_MAC_ADDR;\n \t\tether_addr_copy(input->filter.src_addr,\n \t\t\t\tfsp->h_u.ether_spec.h_source);\n \t}\n \n-\t/* Only support matching addresses by the full mask */\n \tif (is_broadcast_ether_addr(fsp->m_u.ether_spec.h_dest)) {\n \t\tinput->filter.match_flags |= IGC_FILTER_FLAG_DST_MAC_ADDR;\n \t\tether_addr_copy(input->filter.dst_addr,\n \t\t\t\tfsp->h_u.ether_spec.h_dest);\n \t}\n \n+\tif (input->filter.match_flags & IGC_FILTER_FLAG_DST_MAC_ADDR &&\n+\t input->filter.match_flags & IGC_FILTER_FLAG_SRC_MAC_ADDR) {\n+\t\tnetdev_dbg(netdev, \"Filters with both dst and src are not supported\");\n+\t\terr = -EOPNOTSUPP;\n+\t\tgoto err_out;\n+\t}\n+\n \tif ((fsp->flow_type & FLOW_EXT) && fsp->m_ext.vlan_tci) {\n \t\tif (fsp->m_ext.vlan_tci != htons(VLAN_PRIO_MASK)) {\n \t\t\tnetdev_dbg(netdev, \"VLAN mask not supported\");\n", "prefixes": [ "v2", "4/4" ] }