Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1267657/?format=api
{ "id": 1267657, "url": "http://patchwork.ozlabs.org/api/patches/1267657/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200407221139.2233977-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200407221139.2233977-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2020-04-07T22:11:39", "name": "[next-queue,v2] i40e: Add a check to see if MFS is set", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "79fd3c3e8395d4cac431f9fac5f2f907f14dedb6", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200407221139.2233977-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 169111, "url": "http://patchwork.ozlabs.org/api/series/169111/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=169111", "date": "2020-04-07T22:11:39", "name": "[next-queue,v2] i40e: Add a check to see if MFS is set", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/169111/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1267657/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1267657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48xhTP4zP4z9sSY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Apr 2020 08:11:51 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CDC6486987;\n\tTue, 7 Apr 2020 22:11:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OK0lDVVsq2Ij; Tue, 7 Apr 2020 22:11:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0A36986931;\n\tTue, 7 Apr 2020 22:11:49 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 939861BF40D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 22:11:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8E981221D5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 22:11:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OSnIJ5w19yPK for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 22:11:45 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 30319221C6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 22:11:44 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t07 Apr 2020 15:11:42 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.86])\n\tby fmsmga002.fm.intel.com with ESMTP; 07 Apr 2020 15:11:42 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "49jAmxWqRYOyaDbCXyshumGXRv5xZl8wohmDQe1q5KVvnmlNwXwXhCf3/0NklaF8qehUmsV6jj\n\tWwC8ARYmPwdg==", "0KfA5QrSMJLOlTf9B/rr3Fq57HbW8nUW0qm8S1lcCtnxs/c29PPQFZqYEZhzisxSvSbwfchtT3\n\th0+T+vH7fh6w==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,356,1580803200\"; d=\"scan'208\";a=\"286357438\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Apr 2020 15:11:39 -0700", "Message-Id": "<20200407221139.2233977-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.25.2", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue v2] i40e: Add a check to see if MFS\n\tis set", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Todd Fujinaka <todd.fujinaka@intel.com>\n\nA customer was chain-booting to provision his systems and one of the\nsteps was setting MFS. MFS isn't cleared by normal warm reboots\n(clearing requires a GLOBR) and there was no indication of why Jumbo\nFrame receives were failing.\n\nAdd a warning if MFS is set to anything lower than the default.\n\nSigned-off-by: Todd Fujinaka <todd.fujinaka@intel.com>\nReviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\nv2: added missing defines\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 +++++++++\n drivers/net/ethernet/intel/i40e/i40e_register.h | 8 ++++++++\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b08dccbe6ef2..75189c16604e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -15344,6 +15344,15 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\ti40e_stat_str(&pf->hw, err),\n \t\t\ti40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));\n \n+\t/* make sure the MFS hasn't been set lower than the default */\n+#define MAX_FRAME_SIZE_DEFAULT 0x2600\n+\tfor (i = 0; i < 4; i++) {\n+\t\tval = ((rd32(&pf->hw, I40E_PRTGL_SAH) & I40E_PRTGL_SAH_MFS_MASK)\n+\t\t\t>> I40E_PRTGL_SAH_MFS_SHIFT);\n+\t\tif (val < MAX_FRAME_SIZE_DEFAULT)\n+\t\t\tdev_warn(&pdev->dev, \"MFS for port %x has been set below the default: %x\\n\", i, val);\n+\t}\n+\n \t/* Add a filter to drop all Flow control frames from any VSI from being\n \t * transmitted. By doing so we stop a malicious VF from sending out\n \t * PAUSE or PFC frames and potentially controlling traffic for other\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h\nindex 0653b3bed2f2..4eeedcdee342 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_register.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_register.h\n@@ -349,6 +349,14 @@\n #define I40E_VSILAN_QBASE_VSIQTABLE_ENA_SHIFT 11\n #define I40E_VSILAN_QBASE_VSIQTABLE_ENA_MASK I40E_MASK(0x1, I40E_VSILAN_QBASE_VSIQTABLE_ENA_SHIFT)\n #define I40E_VSILAN_QTABLE(_i, _VSI) (0x00200000 + ((_i) * 2048 + (_VSI) * 4)) /* _i=0...7, _VSI=0...383 */ /* Reset: PFR */\n+#define I40E_PRTGL_SAH\t\t\t0x001E2140 /* Reset: GLOBR */\n+#define I40E_PRTGL_SAH_FC_SAH_SHIFT\t0\n+#define I40E_PRTGL_SAH_FC_SAH_MASK\tI40E_MASK(0xFFFF, I40E_PRTGL_SAH_FC_SAH_SHIFT)\n+#define I40E_PRTGL_SAH_MFS_SHIFT\t16\n+#define I40E_PRTGL_SAH_MFS_MASK\t\tI40E_MASK(0xFFFF, I40E_PRTGL_SAH_MFS_SHIFT)\n+#define I40E_PRTGL_SAL\t\t\t0x001E2120 /* Reset: GLOBR */\n+#define I40E_PRTGL_SAL_FC_SAL_SHIFT\t0\n+#define I40E_PRTGL_SAL_FC_SAL_MASK\tI40E_MASK(0xFFFFFFFF, I40E_PRTGL_SAL_FC_SAL_SHIFT)\n #define I40E_GLNVM_FLA 0x000B6108 /* Reset: POR */\n #define I40E_GLNVM_FLA_LOCKED_SHIFT 6\n #define I40E_GLNVM_FLA_LOCKED_MASK I40E_MASK(0x1, I40E_GLNVM_FLA_LOCKED_SHIFT)\n", "prefixes": [ "next-queue", "v2" ] }