Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1267639/?format=api
{ "id": 1267639, "url": "http://patchwork.ozlabs.org/api/patches/1267639/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200407210711.24371-3-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200407210711.24371-3-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-04-07T21:07:08", "name": "[2/5] igc: Remove ethertype filter in ptp code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3b0e4f707ff18cf77fb4dfd8ff2420a1454a6e5d", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200407210711.24371-3-andre.guedes@intel.com/mbox/", "series": [ { "id": 169099, "url": "http://patchwork.ozlabs.org/api/series/169099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=169099", "date": "2020-04-07T21:07:08", "name": "igc: Fixes for ethertype filtering code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/169099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1267639/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1267639/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48xg341mVdz9sQx\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Apr 2020 07:07:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C766087E30;\n\tTue, 7 Apr 2020 21:07:26 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BVMROXxScDu9; Tue, 7 Apr 2020 21:07:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 71ABF87D46;\n\tTue, 7 Apr 2020 21:07:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 332F61BF616\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 21:07:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2FD70220D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 21:07:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DRyOUZnGx2Ls for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 21:07:22 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 18B5A220C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Apr 2020 21:07:21 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t07 Apr 2020 14:07:20 -0700", "from jyguan-mobl1.amr.corp.intel.com ([10.212.37.126])\n\tby fmsmga006.fm.intel.com with ESMTP; 07 Apr 2020 14:07:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "W74Np4usQiL+/C0hh9vhN0zbUHZ9cF/9tB8/aTlvvKMnL2bQrXYRKLsmd0CkOodLiIpUrCHiKa\n\tM6lqvKluRQfA==", "95dDcbTSisYPzS+4uK18dGz1k5Q09gQhtXqFAKDuTOyMr8NxvG/HdmeDWbLGv6NuUWAVt0BJQq\n\tGXZb5cdjxlow==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,356,1580803200\"; d=\"scan'208\";a=\"452593245\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 7 Apr 2020 14:07:08 -0700", "Message-Id": "<20200407210711.24371-3-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200407210711.24371-1-andre.guedes@intel.com>", "References": "<20200407210711.24371-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 2/5] igc: Remove ethertype filter in ptp\n\tcode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The driver only supports hardware timestamping for all incoming\ntraffic (HWTSTAMP_FILTER_ALL) which is enabled via Rx Time Sync\nControl (TSYNCRXCTL) register already. Therefore, the ethertype\nfilter set in in igc_ptp_set_timestamp_mode() is useless so this\npatch removes it.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc.h | 2 +-\n drivers/net/ethernet/intel/igc/igc_defines.h | 3 ---\n drivers/net/ethernet/intel/igc/igc_ptp.c | 12 ------------\n 3 files changed, 1 insertion(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h\nindex dd2d2f0c312f..3666914724b0 100644\n--- a/drivers/net/ethernet/intel/igc/igc.h\n+++ b/drivers/net/ethernet/intel/igc/igc.h\n@@ -26,7 +26,7 @@ void igc_set_ethtool_ops(struct net_device *);\n #define MAX_Q_VECTORS\t\t\t8\n #define MAX_STD_JUMBO_FRAME_SIZE\t9216\n \n-#define MAX_ETYPE_FILTER\t\t(4 - 1)\n+#define MAX_ETYPE_FILTER\t\t4\n #define IGC_RETA_SIZE\t\t\t128\n \n struct igc_tx_queue_stats {\ndiff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h\nindex 03c3ce86a9b6..1127ef81e374 100644\n--- a/drivers/net/ethernet/intel/igc/igc_defines.h\n+++ b/drivers/net/ethernet/intel/igc/igc_defines.h\n@@ -384,9 +384,6 @@\n \n #define IGC_TSICR_INTERRUPTS\tIGC_TSICR_TXTS\n \n-/* PTP Queue Filter */\n-#define IGC_ETQF_1588\t\tBIT(30)\n-\n #define IGC_FTQF_VF_BP\t\t0x00008000\n #define IGC_FTQF_1588_TIME_STAMP\t0x08000000\n #define IGC_FTQF_MASK\t\t\t0xF0000000\ndiff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c\nindex c292aaf7c79d..825e21a73355 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ptp.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c\n@@ -305,7 +305,6 @@ static int igc_ptp_set_timestamp_mode(struct igc_adapter *adapter,\n \tstruct igc_hw *hw = &adapter->hw;\n \tu32 tsync_rx_cfg = 0;\n \tbool is_l4 = false;\n-\tbool is_l2 = false;\n \tu32 regval;\n \n \t/* reserved for future extensions */\n@@ -346,7 +345,6 @@ static int igc_ptp_set_timestamp_mode(struct igc_adapter *adapter,\n \tcase HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:\n \t\ttsync_rx_ctl |= IGC_TSYNCRXCTL_TYPE_EVENT_V2;\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;\n-\t\tis_l2 = true;\n \t\tis_l4 = true;\n \t\tbreak;\n \tcase HWTSTAMP_FILTER_PTP_V1_L4_EVENT:\n@@ -370,7 +368,6 @@ static int igc_ptp_set_timestamp_mode(struct igc_adapter *adapter,\n \t\ttsync_rx_ctl |= IGC_TSYNCRXCTL_TYPE_ALL;\n \t\ttsync_rx_ctl |= IGC_TSYNCRXCTL_RXSYNSIG;\n \t\tconfig->rx_filter = HWTSTAMP_FILTER_ALL;\n-\t\tis_l2 = true;\n \t\tis_l4 = true;\n \n \t\tif (hw->mac.type == igc_i225) {\n@@ -405,15 +402,6 @@ static int igc_ptp_set_timestamp_mode(struct igc_adapter *adapter,\n \t/* define which PTP packets are time stamped */\n \twr32(IGC_TSYNCRXCFG, tsync_rx_cfg);\n \n-\t/* define ethertype filter for timestamped packets */\n-\tif (is_l2)\n-\t\twr32(IGC_ETQF(3),\n-\t\t (IGC_ETQF_FILTER_ENABLE | /* enable filter */\n-\t\t IGC_ETQF_1588 | /* enable timestamping */\n-\t\t ETH_P_1588)); /* 1588 eth protocol type */\n-\telse\n-\t\twr32(IGC_ETQF(3), 0);\n-\n \t/* L4 Queue Filter[3]: filter by destination port and protocol */\n \tif (is_l4) {\n \t\tu32 ftqf = (IPPROTO_UDP /* UDP */\n", "prefixes": [ "2/5" ] }