Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1266152/?format=api
{ "id": 1266152, "url": "http://patchwork.ozlabs.org/api/patches/1266152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200403181743.23447-4-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200403181743.23447-4-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-04-03T18:17:42", "name": "[3/4] igc: Return -EOPNOTSUPP when VLAN mask doesn't match", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f5ce124ea70bfde028e5ba5c05a7e87136b4c7dc", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200403181743.23447-4-andre.guedes@intel.com/mbox/", "series": [ { "id": 168478, "url": "http://patchwork.ozlabs.org/api/series/168478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=168478", "date": "2020-04-03T18:17:42", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/168478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1266152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1266152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48v7VF0G3Xz9sSh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 4 Apr 2020 05:18:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 660BF877FC;\n\tFri, 3 Apr 2020 18:18:43 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id G3iTNIBnx0Xb; Fri, 3 Apr 2020 18:18:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 93FE9875DB;\n\tFri, 3 Apr 2020 18:18:39 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C02591BF397\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2020 18:18:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B998020390\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2020 18:18:37 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gHrsd3WPYwkn for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2020 18:18:34 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F182926876\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Apr 2020 18:18:33 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t03 Apr 2020 11:18:33 -0700", "from unknown (HELO localhost.localdomain) ([10.254.70.217])\n\tby orsmga006.jf.intel.com with ESMTP; 03 Apr 2020 11:18:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "w22YLvhA3hicHDPYKxl0CkI8hrDmXrwlpNVKxTwE+XB1nlYbJ1GHjGFhT4TeJy5Q3LMC16fKTO\n\tOfrwfqsgWGOA==", "p7UBYU+/LAgg8bQ/k4ENZs2tHEYgshkHed5TAgjuSlkzJ5LI2vHe1dMYabYbWLh0l2oe3UDK6p\n\tLtfPnfABDE9Q==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,340,1580803200\"; d=\"scan'208\";a=\"253445201\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 3 Apr 2020 11:17:42 -0700", "Message-Id": "<20200403181743.23447-4-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200403181743.23447-1-andre.guedes@intel.com>", "References": "<20200403181743.23447-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 3/4] igc: Return -EOPNOTSUPP when VLAN\n\tmask doesn't match", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The I225 controller supports rx queue assignment based on VLAN priority\nonly. Other Tag Control Information (TCI) are valid, but not supported\nby the driver. So this patch changes the returning code from igc_add_\nethtool_nfc_entry() to -EOPNOTSUPP in order to provide more meaningful\ninformation on why the function failed.\n\nIt also adds a debug messages to give the user a hint about what went\nwrong with the NFC setup.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex dfc21908347d..036a2244b76c 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -1446,7 +1446,8 @@ static int igc_add_ethtool_nfc_entry(struct igc_adapter *adapter,\n \n \tif ((fsp->flow_type & FLOW_EXT) && fsp->m_ext.vlan_tci) {\n \t\tif (fsp->m_ext.vlan_tci != htons(VLAN_PRIO_MASK)) {\n-\t\t\terr = -EINVAL;\n+\t\t\tnetdev_dbg(netdev, \"VLAN mask not supported\");\n+\t\t\terr = -EOPNOTSUPP;\n \t\t\tgoto err_out;\n \t\t}\n \t\tinput->filter.vlan_tci = fsp->h_ext.vlan_tci;\n", "prefixes": [ "3/4" ] }