Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261089/?format=api
{ "id": 1261089, "url": "http://patchwork.ozlabs.org/api/patches/1261089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-11-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-11-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:24", "name": "[10/10] igc: Remove '\\n' from log strings in igc_phy.c", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "9d3489264e63f32b43f3e29bedf06379f4fb7b94", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-11-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261089/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PW1HVfz9sRY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7A372235B8;\n\tWed, 25 Mar 2020 00:38:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F7UztCyvQCt8; Wed, 25 Mar 2020 00:38:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F2EB72034C;\n\tWed, 25 Mar 2020 00:38:45 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 56AAF1BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3A84E23B7F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 45RviU1oj0vl for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 96D5720035\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:38 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "Hel3hlOgyYnmJf1moM05bYrd69tBMKwEJB5aKGDVX/bmB2Ug36lSmHKzXFbbnUZ8mdjd2UBw6T\n\tFeM7a9Ati3dw==", "SkjDWBGqThfAjb1wWicMtVEH4t5lvxsKVloyivD7W+SH6PvW+vMVxSe9oqLjeVz7aV6X1jTEMB\n\tZP5drrgVMrYQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099358\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:24 -0700", "Message-Id": "<20200325003824.5487-11-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 10/10] igc: Remove '\\n' from log strings\n\tin igc_phy.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "To keep log strings in igc_phy.c consistent with the rest of the driver\ncode, this patch removes the '\\n' character at the end. The newline\ncharacter is automatically added by netdev_dbg() so there is no changes\nin the output.\n\nNote: hw_dbg() is a macro that expands to netdev_dbg().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_phy.c | 52 ++++++++++++------------\n 1 file changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c\nindex 8e1799508edc..a11c2e45d894 100644\n--- a/drivers/net/ethernet/intel/igc/igc_phy.c\n+++ b/drivers/net/ethernet/intel/igc/igc_phy.c\n@@ -207,7 +207,7 @@ s32 igc_phy_hw_reset(struct igc_hw *hw)\n \t} while (!(phpm & IGC_PHY_RST_COMP) && timeout);\n \n \tif (!timeout)\n-\t\thw_dbg(\"Timeout is expired after a phy reset\\n\");\n+\t\thw_dbg(\"Timeout is expired after a phy reset\");\n \n \tusleep_range(100, 150);\n \n@@ -278,49 +278,49 @@ static s32 igc_phy_setup_autoneg(struct igc_hw *hw)\n \t\t\t\t NWAY_AR_10T_HD_CAPS);\n \tmii_1000t_ctrl_reg &= ~(CR_1000T_HD_CAPS | CR_1000T_FD_CAPS);\n \n-\thw_dbg(\"autoneg_advertised %x\\n\", phy->autoneg_advertised);\n+\thw_dbg(\"autoneg_advertised %x\", phy->autoneg_advertised);\n \n \t/* Do we want to advertise 10 Mb Half Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_10_HALF) {\n-\t\thw_dbg(\"Advertise 10mb Half duplex\\n\");\n+\t\thw_dbg(\"Advertise 10mb Half duplex\");\n \t\tmii_autoneg_adv_reg |= NWAY_AR_10T_HD_CAPS;\n \t}\n \n \t/* Do we want to advertise 10 Mb Full Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_10_FULL) {\n-\t\thw_dbg(\"Advertise 10mb Full duplex\\n\");\n+\t\thw_dbg(\"Advertise 10mb Full duplex\");\n \t\tmii_autoneg_adv_reg |= NWAY_AR_10T_FD_CAPS;\n \t}\n \n \t/* Do we want to advertise 100 Mb Half Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_100_HALF) {\n-\t\thw_dbg(\"Advertise 100mb Half duplex\\n\");\n+\t\thw_dbg(\"Advertise 100mb Half duplex\");\n \t\tmii_autoneg_adv_reg |= NWAY_AR_100TX_HD_CAPS;\n \t}\n \n \t/* Do we want to advertise 100 Mb Full Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_100_FULL) {\n-\t\thw_dbg(\"Advertise 100mb Full duplex\\n\");\n+\t\thw_dbg(\"Advertise 100mb Full duplex\");\n \t\tmii_autoneg_adv_reg |= NWAY_AR_100TX_FD_CAPS;\n \t}\n \n \t/* We do not allow the Phy to advertise 1000 Mb Half Duplex */\n \tif (phy->autoneg_advertised & ADVERTISE_1000_HALF)\n-\t\thw_dbg(\"Advertise 1000mb Half duplex request denied!\\n\");\n+\t\thw_dbg(\"Advertise 1000mb Half duplex request denied\");\n \n \t/* Do we want to advertise 1000 Mb Full Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_1000_FULL) {\n-\t\thw_dbg(\"Advertise 1000mb Full duplex\\n\");\n+\t\thw_dbg(\"Advertise 1000mb Full duplex\");\n \t\tmii_1000t_ctrl_reg |= CR_1000T_FD_CAPS;\n \t}\n \n \t/* We do not allow the Phy to advertise 2500 Mb Half Duplex */\n \tif (phy->autoneg_advertised & ADVERTISE_2500_HALF)\n-\t\thw_dbg(\"Advertise 2500mb Half duplex request denied!\\n\");\n+\t\thw_dbg(\"Advertise 2500mb Half duplex request denied\");\n \n \t/* Do we want to advertise 2500 Mb Full Duplex? */\n \tif (phy->autoneg_advertised & ADVERTISE_2500_FULL) {\n-\t\thw_dbg(\"Advertise 2500mb Full duplex\\n\");\n+\t\thw_dbg(\"Advertise 2500mb Full duplex\");\n \t\taneg_multigbt_an_ctrl |= CR_2500T_FD_CAPS;\n \t} else {\n \t\taneg_multigbt_an_ctrl &= ~CR_2500T_FD_CAPS;\n@@ -376,7 +376,7 @@ static s32 igc_phy_setup_autoneg(struct igc_hw *hw)\n \t\tmii_autoneg_adv_reg |= (NWAY_AR_ASM_DIR | NWAY_AR_PAUSE);\n \t\tbreak;\n \tdefault:\n-\t\thw_dbg(\"Flow control param set incorrectly\\n\");\n+\t\thw_dbg(\"Flow control param set incorrectly\");\n \t\treturn -IGC_ERR_CONFIG;\n \t}\n \n@@ -384,7 +384,7 @@ static s32 igc_phy_setup_autoneg(struct igc_hw *hw)\n \tif (ret_val)\n \t\treturn ret_val;\n \n-\thw_dbg(\"Auto-Neg Advertising %x\\n\", mii_autoneg_adv_reg);\n+\thw_dbg(\"Auto-Neg Advertising %x\", mii_autoneg_adv_reg);\n \n \tif (phy->autoneg_mask & ADVERTISE_1000_FULL)\n \t\tret_val = phy->ops.write_reg(hw, PHY_1000T_CTRL,\n@@ -458,13 +458,13 @@ static s32 igc_copper_link_autoneg(struct igc_hw *hw)\n \tif (phy->autoneg_advertised == 0)\n \t\tphy->autoneg_advertised = phy->autoneg_mask;\n \n-\thw_dbg(\"Reconfiguring auto-neg advertisement params\\n\");\n+\thw_dbg(\"Reconfiguring auto-neg advertisement params\");\n \tret_val = igc_phy_setup_autoneg(hw);\n \tif (ret_val) {\n-\t\thw_dbg(\"Error Setting up Auto-Negotiation\\n\");\n+\t\thw_dbg(\"Error Setting up Auto-Negotiation\");\n \t\tgoto out;\n \t}\n-\thw_dbg(\"Restarting Auto-Neg\\n\");\n+\thw_dbg(\"Restarting Auto-Neg\");\n \n \t/* Restart auto-negotiation by setting the Auto Neg Enable bit and\n \t * the Auto Neg Restart bit in the PHY control register.\n@@ -484,7 +484,7 @@ static s32 igc_copper_link_autoneg(struct igc_hw *hw)\n \tif (phy->autoneg_wait_to_complete) {\n \t\tret_val = igc_wait_autoneg(hw);\n \t\tif (ret_val) {\n-\t\t\thw_dbg(\"Error while waiting for autoneg to complete\\n\");\n+\t\t\thw_dbg(\"Error while waiting for autoneg to complete\");\n \t\t\tgoto out;\n \t\t}\n \t}\n@@ -520,10 +520,10 @@ s32 igc_setup_copper_link(struct igc_hw *hw)\n \t\t/* PHY will be set to 10H, 10F, 100H or 100F\n \t\t * depending on user settings.\n \t\t */\n-\t\thw_dbg(\"Forcing Speed and Duplex\\n\");\n+\t\thw_dbg(\"Forcing Speed and Duplex\");\n \t\tret_val = hw->phy.ops.force_speed_duplex(hw);\n \t\tif (ret_val) {\n-\t\t\thw_dbg(\"Error Forcing Speed and Duplex\\n\");\n+\t\t\thw_dbg(\"Error Forcing Speed and Duplex\");\n \t\t\tgoto out;\n \t\t}\n \t}\n@@ -536,11 +536,11 @@ s32 igc_setup_copper_link(struct igc_hw *hw)\n \t\tgoto out;\n \n \tif (link) {\n-\t\thw_dbg(\"Valid link established!!!\\n\");\n+\t\thw_dbg(\"Valid link established\");\n \t\tigc_config_collision_dist(hw);\n \t\tret_val = igc_config_fc_after_link_up(hw);\n \t} else {\n-\t\thw_dbg(\"Unable to establish link!!!\\n\");\n+\t\thw_dbg(\"Unable to establish link\");\n \t}\n \n out:\n@@ -563,7 +563,7 @@ static s32 igc_read_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 *data)\n \ts32 ret_val = 0;\n \n \tif (offset > MAX_PHY_REG_ADDRESS) {\n-\t\thw_dbg(\"PHY Address %d is out of range\\n\", offset);\n+\t\thw_dbg(\"PHY Address %d is out of range\", offset);\n \t\tret_val = -IGC_ERR_PARAM;\n \t\tgoto out;\n \t}\n@@ -589,12 +589,12 @@ static s32 igc_read_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 *data)\n \t\t\tbreak;\n \t}\n \tif (!(mdic & IGC_MDIC_READY)) {\n-\t\thw_dbg(\"MDI Read did not complete\\n\");\n+\t\thw_dbg(\"MDI Read did not complete\");\n \t\tret_val = -IGC_ERR_PHY;\n \t\tgoto out;\n \t}\n \tif (mdic & IGC_MDIC_ERROR) {\n-\t\thw_dbg(\"MDI Error\\n\");\n+\t\thw_dbg(\"MDI Error\");\n \t\tret_val = -IGC_ERR_PHY;\n \t\tgoto out;\n \t}\n@@ -619,7 +619,7 @@ static s32 igc_write_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 data)\n \ts32 ret_val = 0;\n \n \tif (offset > MAX_PHY_REG_ADDRESS) {\n-\t\thw_dbg(\"PHY Address %d is out of range\\n\", offset);\n+\t\thw_dbg(\"PHY Address %d is out of range\", offset);\n \t\tret_val = -IGC_ERR_PARAM;\n \t\tgoto out;\n \t}\n@@ -646,12 +646,12 @@ static s32 igc_write_phy_reg_mdic(struct igc_hw *hw, u32 offset, u16 data)\n \t\t\tbreak;\n \t}\n \tif (!(mdic & IGC_MDIC_READY)) {\n-\t\thw_dbg(\"MDI Write did not complete\\n\");\n+\t\thw_dbg(\"MDI Write did not complete\");\n \t\tret_val = -IGC_ERR_PHY;\n \t\tgoto out;\n \t}\n \tif (mdic & IGC_MDIC_ERROR) {\n-\t\thw_dbg(\"MDI Error\\n\");\n+\t\thw_dbg(\"MDI Error\");\n \t\tret_val = -IGC_ERR_PHY;\n \t\tgoto out;\n \t}\n", "prefixes": [ "10/10" ] }